From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver
Date: Thu, 04 Sep 2014 23:42:43 +0200 [thread overview]
Message-ID: <7546804.XWPgHM2sst@wuerfel> (raw)
In-Reply-To: <1409750292-24105-1-git-send-email-kaixu.xia@linaro.org>
On Wednesday 03 September 2014 21:18:12 Xia Kaixu wrote:
>
> +#ifdef CONFIG_PCI
> +extern int __init cns3xxx_pcie_init_late(void);
> +#else
> +static inline int __init cns3xxx_pcie_init_late(void)
> +{
> + return -ENXIO;
> +}
> +#endif
> +
> void __init cns3xxx_map_io(void);
>
I found another problem: we get a new compile-time warning
because the function returns an 'int' while the .init_late
callback expects a function returning 'void'.
I've fixed it up locally, but please be more careful about
introducing warnings in the future.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Xia Kaixu <kaixu.xia@linaro.org>,
linux-kernel@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>,
linaro-kernel@lists.linaro.org,
Anton Vorontsov <anton@enomsg.org>,
Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver
Date: Thu, 04 Sep 2014 23:42:43 +0200 [thread overview]
Message-ID: <7546804.XWPgHM2sst@wuerfel> (raw)
In-Reply-To: <1409750292-24105-1-git-send-email-kaixu.xia@linaro.org>
On Wednesday 03 September 2014 21:18:12 Xia Kaixu wrote:
>
> +#ifdef CONFIG_PCI
> +extern int __init cns3xxx_pcie_init_late(void);
> +#else
> +static inline int __init cns3xxx_pcie_init_late(void)
> +{
> + return -ENXIO;
> +}
> +#endif
> +
> void __init cns3xxx_map_io(void);
>
I found another problem: we get a new compile-time warning
because the function returns an 'int' while the .init_late
callback expects a function returning 'void'.
I've fixed it up locally, but please be more careful about
introducing warnings in the future.
Arnd
next prev parent reply other threads:[~2014-09-04 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <kaixu.xia@linaro.org>
2014-09-03 13:18 ` [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver Xia Kaixu
2014-09-03 13:18 ` Xia Kaixu
2014-09-03 13:27 ` Arnd Bergmann
2014-09-03 13:27 ` Arnd Bergmann
2014-09-04 3:46 ` xiakaixu
2014-09-04 3:46 ` xiakaixu
2014-09-04 20:32 ` Arnd Bergmann
2014-09-04 20:32 ` Arnd Bergmann
2014-09-04 21:42 ` Arnd Bergmann [this message]
2014-09-04 21:42 ` Arnd Bergmann
2014-09-03 12:39 Xia Kaixu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7546804.XWPgHM2sst@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.