From: Shuah Khan <shuah@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: David Valleau <valleau@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Valentina Manea <valentina.manea.m@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <alexander.levin@microsoft.com>,
shuah <shuah@kernel.org>
Subject: tools: usb: usbip: adding support for older kernel versions
Date: Mon, 25 Mar 2019 18:04:12 -0600 [thread overview]
Message-ID: <759fcefa-974b-7430-e7cf-64eabd219d61@kernel.org> (raw)
On 3/25/19 5:02 PM, Brian Norris wrote:
> On Mon, Mar 25, 2019 at 3:07 PM shuah <shuah@kernel.org> wrote:
>> On 3/25/19 11:56 AM, Brian Norris wrote:
>>> On Mon, Mar 25, 2019 at 8:51 AM shuah <shuah@kernel.org> wrote:
>>>> In general the ABI is stable.
>>>
>>> No, it really isn't. This commit was a breaking change:
> ...
>>> But this one is definitely a break:
>>>
>>> commit 1c9de5bf428612458427943b724bea51abde520a
>>> Author: Yuyang Du <yuyang.du@intel.com>
>>> Date: Thu Jun 8 13:04:10 2017 +0800
>>>
>>> usbip: vhci-hcd: Add USB3 SuperSpeed support
>>>
>>> You can't just arbitrarily add columns to the beginning of a file like
>>> that and claim that you're not breaking ABI. And I shouldn't need to
>>> remind you that Thou Shalt Not Break User Space.
>>
>> USB 3.0 driver and tool support went in, I would say it was oversight to
>> not make sure the tool continues to work on older kernels.
>
> While that's true, you're still not grokking my main point when asking
> about ABI stability:
>
> *old* tools should still work on *new* kernels
>
> The above commit broke that.
>
Agreed. Let's move forward with the assumption that this won't happen
in the future.
On a side note, in this specific tool case, the newer version is more
secure than the older version.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah <shuah@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: David Valleau <valleau@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Valentina Manea <valentina.manea.m@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <alexander.levin@microsoft.com>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions
Date: Mon, 25 Mar 2019 18:04:12 -0600 [thread overview]
Message-ID: <759fcefa-974b-7430-e7cf-64eabd219d61@kernel.org> (raw)
In-Reply-To: <CA+ASDXOEkG36W-6rONqDntzChtq65=cQh6JVyjWhftBykXVTbw@mail.gmail.com>
On 3/25/19 5:02 PM, Brian Norris wrote:
> On Mon, Mar 25, 2019 at 3:07 PM shuah <shuah@kernel.org> wrote:
>> On 3/25/19 11:56 AM, Brian Norris wrote:
>>> On Mon, Mar 25, 2019 at 8:51 AM shuah <shuah@kernel.org> wrote:
>>>> In general the ABI is stable.
>>>
>>> No, it really isn't. This commit was a breaking change:
> ...
>>> But this one is definitely a break:
>>>
>>> commit 1c9de5bf428612458427943b724bea51abde520a
>>> Author: Yuyang Du <yuyang.du@intel.com>
>>> Date: Thu Jun 8 13:04:10 2017 +0800
>>>
>>> usbip: vhci-hcd: Add USB3 SuperSpeed support
>>>
>>> You can't just arbitrarily add columns to the beginning of a file like
>>> that and claim that you're not breaking ABI. And I shouldn't need to
>>> remind you that Thou Shalt Not Break User Space.
>>
>> USB 3.0 driver and tool support went in, I would say it was oversight to
>> not make sure the tool continues to work on older kernels.
>
> While that's true, you're still not grokking my main point when asking
> about ABI stability:
>
> *old* tools should still work on *new* kernels
>
> The above commit broke that.
>
Agreed. Let's move forward with the assumption that this won't happen
in the future.
On a side note, in this specific tool case, the newer version is more
secure than the older version.
thanks,
-- Shuah
next reply other threads:[~2019-03-26 0:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 0:04 Shuah Khan [this message]
2019-03-26 0:04 ` [PATCH] tools: usb: usbip: adding support for older kernel versions shuah
-- strict thread matches above, loose matches on Subject: below --
2019-03-27 1:16 Brian Norris
2019-03-27 1:16 ` [PATCH] " Brian Norris
2019-03-26 1:59 Shuah Khan
2019-03-26 1:59 ` [PATCH] " shuah
2019-03-26 1:29 Brian Norris
2019-03-26 1:29 ` [PATCH] " Brian Norris
2019-03-26 1:28 Brian Norris
2019-03-26 1:28 ` [PATCH] " Brian Norris
2019-03-26 0:55 Greg Kroah-Hartman
2019-03-26 0:55 ` [PATCH] " Greg Kroah-Hartman
2019-03-26 0:49 Brian Norris
2019-03-26 0:49 ` [PATCH] " Brian Norris
2019-03-26 0:13 Greg Kroah-Hartman
2019-03-26 0:13 ` [PATCH] " Greg Kroah-Hartman
2019-03-25 23:02 Brian Norris
2019-03-25 23:02 ` [PATCH] " Brian Norris
2019-03-25 22:07 Shuah Khan
2019-03-25 22:07 ` [PATCH] " shuah
2019-03-25 17:56 Brian Norris
2019-03-25 17:56 ` [PATCH] " Brian Norris
2019-03-25 15:51 Shuah Khan
2019-03-25 15:51 ` [PATCH] " shuah
2019-03-18 18:23 Brian Norris
2019-03-18 18:23 ` [PATCH] " Brian Norris
2019-03-16 23:39 Shuah Khan
2019-03-16 23:39 ` [PATCH] " shuah
2019-03-06 21:47 David Valleau
2019-03-06 21:47 ` [PATCH] " David Valleau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759fcefa-974b-7430-e7cf-64eabd219d61@kernel.org \
--to=shuah@kernel.org \
--cc=alexander.levin@microsoft.com \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=valentina.manea.m@gmail.com \
--cc=valleau@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.