All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Kossifidis <mick@ics.forth.gr>
To: Alex Ghiti <alex@ghiti.fr>
Cc: Nick Kossifidis <mick@ics.forth.gr>,
	linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] RISC-V: Add kdump support
Date: Fri, 09 Apr 2021 13:21:48 +0300	[thread overview]
Message-ID: <75abd98990bfaae51262b72cf7d59831@mailhost.ics.forth.gr> (raw)
In-Reply-To: <1385f2a4-53a9-535b-851a-3c470f1f3bc1@ghiti.fr>

Στις 2021-04-06 21:36, Alex Ghiti έγραψε:
> 
>> +	/* Switch to physical addressing */
>> +	la	s4, 1f
>> +	sub	s4, s4, s3
>> +	csrw	stvec, s4
>> +	csrw	sptbr, zero
> 
> satp is used everywhere instead of sptbr. And maybe you could CSR_****
> naming, like you did in riscv_crash_save_regs and like it's done in
> head.S too.
> 

ACK

>> +		crash_base = memblock_find_in_range(search_start, search_end,
>> +#ifdef CONFIG_64BIT
>> +						    crash_size, SZ_2M);
>> +#else
>> +						    crash_size, SZ_4M);
>> +#endif
> 
> You can use PMD_SIZE here and get rid of #ifdef.
> 
>> +
>> +#ifdef CONFIG_64BIT
>> +		if (!IS_ALIGNED(crash_base, SZ_2M)) {
>> +#else
>> +		if (!IS_ALIGNED(crash_base, SZ_4M)) {
>> +#endif
> 
> Ditto here.
> 

Will do.

Thanks a lot for your review !

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Nick Kossifidis <mick@ics.forth.gr>
To: Alex Ghiti <alex@ghiti.fr>
Cc: Nick Kossifidis <mick@ics.forth.gr>,
	linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] RISC-V: Add kdump support
Date: Fri, 09 Apr 2021 13:21:48 +0300	[thread overview]
Message-ID: <75abd98990bfaae51262b72cf7d59831@mailhost.ics.forth.gr> (raw)
In-Reply-To: <1385f2a4-53a9-535b-851a-3c470f1f3bc1@ghiti.fr>

Στις 2021-04-06 21:36, Alex Ghiti έγραψε:
> 
>> +	/* Switch to physical addressing */
>> +	la	s4, 1f
>> +	sub	s4, s4, s3
>> +	csrw	stvec, s4
>> +	csrw	sptbr, zero
> 
> satp is used everywhere instead of sptbr. And maybe you could CSR_****
> naming, like you did in riscv_crash_save_regs and like it's done in
> head.S too.
> 

ACK

>> +		crash_base = memblock_find_in_range(search_start, search_end,
>> +#ifdef CONFIG_64BIT
>> +						    crash_size, SZ_2M);
>> +#else
>> +						    crash_size, SZ_4M);
>> +#endif
> 
> You can use PMD_SIZE here and get rid of #ifdef.
> 
>> +
>> +#ifdef CONFIG_64BIT
>> +		if (!IS_ALIGNED(crash_base, SZ_2M)) {
>> +#else
>> +		if (!IS_ALIGNED(crash_base, SZ_4M)) {
>> +#endif
> 
> Ditto here.
> 

Will do.

Thanks a lot for your review !

  reply	other threads:[~2021-04-09 10:22 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05  8:57 [PATCH v3 0/5] RISC-V: Add kexec/kdump support Nick Kossifidis
2021-04-05  8:57 ` Nick Kossifidis
2021-04-05  8:57 ` [PATCH v3 1/5] RISC-V: Add EM_RISCV to kexec UAPI header Nick Kossifidis
2021-04-05  8:57   ` Nick Kossifidis
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-05  8:57 ` [PATCH v3 2/5] RISC-V: Add kexec support Nick Kossifidis
2021-04-05  8:57   ` Nick Kossifidis
2021-04-06 18:38   ` Alex Ghiti
2021-04-06 18:38     ` Alex Ghiti
2021-04-09 10:19     ` Nick Kossifidis
2021-04-09 10:19       ` Nick Kossifidis
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-05  8:57 ` [PATCH v3 3/5] RISC-V: Improve init_resources Nick Kossifidis
2021-04-05  8:57   ` Nick Kossifidis
2021-04-06  7:19   ` Geert Uytterhoeven
2021-04-06  7:19     ` Geert Uytterhoeven
2021-04-06  8:11     ` Nick Kossifidis
2021-04-06  8:11       ` Nick Kossifidis
2021-04-06  8:22       ` Geert Uytterhoeven
2021-04-06  8:22         ` Geert Uytterhoeven
2021-04-09 10:11         ` Nick Kossifidis
2021-04-09 10:11           ` Nick Kossifidis
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-05  8:57 ` [PATCH v3 4/5] RISC-V: Add kdump support Nick Kossifidis
2021-04-05  8:57   ` Nick Kossifidis
2021-04-06 18:36   ` Alex Ghiti
2021-04-06 18:36     ` Alex Ghiti
2021-04-09 10:21     ` Nick Kossifidis [this message]
2021-04-09 10:21       ` Nick Kossifidis
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-05  8:57 ` [PATCH v3 5/5] RISC-V: Add crash kernel support Nick Kossifidis
2021-04-05  8:57   ` Nick Kossifidis
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:30     ` Palmer Dabbelt
2021-04-07  7:45 ` [PATCH v3 0/5] RISC-V: Add kexec/kdump support Yixun Lan
2021-04-07  7:45   ` Yixun Lan
2021-04-07 16:29 ` Rob Herring
2021-04-07 16:29   ` Rob Herring
2021-04-09 10:02   ` Nick Kossifidis
2021-04-09 10:02     ` Nick Kossifidis
2021-04-23  3:30 ` Palmer Dabbelt
2021-04-23  3:30   ` Palmer Dabbelt
2021-04-23  3:36   ` Nick Kossifidis
2021-04-23  3:36     ` Nick Kossifidis
2021-04-23  3:48     ` Palmer Dabbelt
2021-04-23  3:48       ` Palmer Dabbelt
2021-04-23  3:53       ` Nick Kossifidis
2021-04-23  3:53         ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75abd98990bfaae51262b72cf7d59831@mailhost.ics.forth.gr \
    --to=mick@ics.forth.gr \
    --cc=alex@ghiti.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.