From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
Hu Mingkai-B21284 <B21284@freescale.com>,
Zang Roy-R61911 <r61911@freescale.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: Layerscape: Add Layerscape PCIe driver
Date: Thu, 04 Sep 2014 15:57:35 +0200 [thread overview]
Message-ID: <7601888.KPBqiDOLoa@wuerfel> (raw)
In-Reply-To: <3055252.byHHPbPjpA@wuerfel>
On Thursday 04 September 2014 15:51:22 Arnd Bergmann wrote:
> On Thursday 04 September 2014 14:14:48 Arnd Bergmann wrote:
> >
> > My impression is that you have two distinct MSI controller
> > implementations, one for LS1021A and the other one for everything
> > else. How about using separate pcie_host_ops for them, possibly
> > also moving them into separate files?
> >
>
> One more thing: you should really use the msi-parent property to
> find the MSI controller: Sooner or later this PCI block is likely
> to end up in a real product that has GICv2m or GICv3 support, so
> you will have to pick which of the two MSI controllers to use.
Ah, I missed the fact that LS1021A is a real product already, I was
confusing it with the LS2085A patches that are also on the list
at the moment and that only work in a simulator at present.
Note that LS2085A does have GICv3. I don't know if it has a similar
PCIe implementation, but if it does, the DT representation should
definitely provide a way to pick the MSI controller (you will always
want the GIC in practice).
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] PCI: Layerscape: Add Layerscape PCIe driver
Date: Thu, 04 Sep 2014 15:57:35 +0200 [thread overview]
Message-ID: <7601888.KPBqiDOLoa@wuerfel> (raw)
In-Reply-To: <3055252.byHHPbPjpA@wuerfel>
On Thursday 04 September 2014 15:51:22 Arnd Bergmann wrote:
> On Thursday 04 September 2014 14:14:48 Arnd Bergmann wrote:
> >
> > My impression is that you have two distinct MSI controller
> > implementations, one for LS1021A and the other one for everything
> > else. How about using separate pcie_host_ops for them, possibly
> > also moving them into separate files?
> >
>
> One more thing: you should really use the msi-parent property to
> find the MSI controller: Sooner or later this PCI block is likely
> to end up in a real product that has GICv2m or GICv3 support, so
> you will have to pick which of the two MSI controllers to use.
Ah, I missed the fact that LS1021A is a real product already, I was
confusing it with the LS2085A patches that are also on the list
at the moment and that only work in a simulator at present.
Note that LS2085A does have GICv3. I don't know if it has a similar
PCIe implementation, but if it does, the DT representation should
definitely provide a way to pick the MSI controller (you will always
want the GIC in practice).
Arnd
next prev parent reply other threads:[~2014-09-04 13:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 18:45 [PATCH 1/2] PCI: designware: change MSI-related pcie_host_ops Minghuan Lian
2014-09-04 18:45 ` Minghuan Lian
2014-09-04 13:20 ` Bjorn Helgaas
2014-09-04 13:20 ` Bjorn Helgaas
2014-09-05 6:15 ` 答复: " Minghuan.Lian at freescale.com
2014-09-04 18:45 ` [PATCH 2/2] PCI: Layerscape: Add Layerscape PCIe driver Minghuan Lian
2014-09-04 18:45 ` Minghuan Lian
2014-09-04 12:14 ` Arnd Bergmann
2014-09-04 12:14 ` Arnd Bergmann
2014-09-04 13:51 ` Arnd Bergmann
2014-09-04 13:51 ` Arnd Bergmann
2014-09-04 13:57 ` Arnd Bergmann [this message]
2014-09-04 13:57 ` Arnd Bergmann
2014-09-05 7:22 ` 答复: " Minghuan.Lian at freescale.com
2014-09-05 8:44 ` Arnd Bergmann
2014-09-05 8:44 ` Arnd Bergmann
2014-09-09 17:25 ` Lian Minghuan-B31939
2014-09-09 17:25 ` Lian Minghuan-B31939
2014-09-09 9:56 ` Arnd Bergmann
2014-09-09 9:56 ` Arnd Bergmann
2014-09-09 18:46 ` Lian Minghuan-B31939
2014-09-09 18:46 ` Lian Minghuan-B31939
2014-09-09 10:50 ` Arnd Bergmann
2014-09-09 10:50 ` Arnd Bergmann
2014-09-09 19:16 ` Lian Minghuan-B31939
2014-09-09 19:16 ` Lian Minghuan-B31939
2014-09-09 11:58 ` Arnd Bergmann
2014-09-09 11:58 ` Arnd Bergmann
2014-09-10 11:29 ` Lian Minghuan-B31939
2014-09-10 11:29 ` Lian Minghuan-B31939
2014-09-04 13:24 ` Bjorn Helgaas
2014-09-04 13:24 ` Bjorn Helgaas
2014-09-05 7:24 ` 答复: " Minghuan.Lian at freescale.com
2014-09-04 20:21 ` Fabio Estevam
2014-09-04 20:21 ` Fabio Estevam
2014-09-04 21:12 ` Arnd Bergmann
2014-09-04 21:12 ` Arnd Bergmann
2014-09-05 6:43 ` 答复: " Minghuan.Lian at freescale.com
2014-09-05 7:40 ` Minghuan.Lian at freescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7601888.KPBqiDOLoa@wuerfel \
--to=arnd@arndb.de \
--cc=B21284@freescale.com \
--cc=Minghuan.Lian@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.