* [PATCH] perf tools: Fix incorrect --user-regs comments
@ 2025-04-02 8:21 Dapeng Mi
2025-04-02 16:55 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Dapeng Mi @ 2025-04-02 8:21 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin,
Kan Liang
Cc: linux-perf-users, linux-kernel, Dapeng Mi, Dapeng Mi
The comment of "--user-regs" option is not correct, fix it.
"on interrupt," -> "on user space,"
Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
---
tools/perf/builtin-record.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ba20bf7c011d..f21b133691d7 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
"sample selected machine registers on interrupt,"
" use '-I?' to list register names", parse_intr_regs),
OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
- "sample selected machine registers on interrupt,"
+ "sample selected machine registers on user space,"
" use '--user-regs=?' to list register names", parse_user_regs),
OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
"Record running/enabled time of read (:S) events"),
base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix incorrect --user-regs comments
2025-04-02 8:21 [PATCH] perf tools: Fix incorrect --user-regs comments Dapeng Mi
@ 2025-04-02 16:55 ` Ian Rogers
2025-04-03 0:42 ` Mi, Dapeng
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2025-04-02 16:55 UTC (permalink / raw)
To: Dapeng Mi
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Adrian Hunter, Alexander Shishkin, Kan Liang,
linux-perf-users, linux-kernel, Dapeng Mi
On Tue, Apr 1, 2025 at 8:58 PM Dapeng Mi <dapeng1.mi@linux.intel.com> wrote:
>
> The comment of "--user-regs" option is not correct, fix it.
>
> "on interrupt," -> "on user space,"
nit: I think "in user space" is more grammatical.
> Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> ---
> tools/perf/builtin-record.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index ba20bf7c011d..f21b133691d7 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
> "sample selected machine registers on interrupt,"
> " use '-I?' to list register names", parse_intr_regs),
> OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
> - "sample selected machine registers on interrupt,"
> + "sample selected machine registers on user space,"
nit: "sample selected machine registers in user space"
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> " use '--user-regs=?' to list register names", parse_user_regs),
> OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
> "Record running/enabled time of read (:S) events"),
>
> base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix incorrect --user-regs comments
2025-04-02 16:55 ` Ian Rogers
@ 2025-04-03 0:42 ` Mi, Dapeng
0 siblings, 0 replies; 3+ messages in thread
From: Mi, Dapeng @ 2025-04-03 0:42 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Adrian Hunter, Alexander Shishkin, Kan Liang,
linux-perf-users, linux-kernel, Dapeng Mi
On 4/3/2025 12:55 AM, Ian Rogers wrote:
> On Tue, Apr 1, 2025 at 8:58 PM Dapeng Mi <dapeng1.mi@linux.intel.com> wrote:
>> The comment of "--user-regs" option is not correct, fix it.
>>
>> "on interrupt," -> "on user space,"
> nit: I think "in user space" is more grammatical.
Sure.
>
>> Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
>> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>> ---
>> tools/perf/builtin-record.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
>> index ba20bf7c011d..f21b133691d7 100644
>> --- a/tools/perf/builtin-record.c
>> +++ b/tools/perf/builtin-record.c
>> @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
>> "sample selected machine registers on interrupt,"
>> " use '-I?' to list register names", parse_intr_regs),
>> OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
>> - "sample selected machine registers on interrupt,"
>> + "sample selected machine registers on user space,"
> nit: "sample selected machine registers in user space"
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Sure. Thanks for reviewing.
>
> Thanks,
> Ian
>
>> " use '--user-regs=?' to list register names", parse_user_regs),
>> OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
>> "Record running/enabled time of read (:S) events"),
>>
>> base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
>> --
>> 2.40.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-03 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-02 8:21 [PATCH] perf tools: Fix incorrect --user-regs comments Dapeng Mi
2025-04-02 16:55 ` Ian Rogers
2025-04-03 0:42 ` Mi, Dapeng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.