From: dsahern at gmail.com (David Ahern)
Subject: [PATCH] selftests: fib_tests: sleep after changing carrier. again.
Date: Fri, 22 Feb 2019 17:37:41 -0500 [thread overview]
Message-ID: <767c0a6e-41a4-e1cd-00a4-197cbcb41af5@gmail.com> (raw)
In-Reply-To: <20190222102741.31173-1-cascardo@canonical.com>
On 2/22/19 5:27 AM, Thadeu Lima de Souza Cascardo wrote:
> Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after
> changing carrier"), wait one second to allow linkwatch to propagate the
> carrier change to the stack.
>
> There are two sets of carrier tests. The first slept after the carrier
> was set to off, and when the second set ran, it was likely that the
> linkwatch would be able to run again without much delay, reducing the
> likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a
> loop, you will quickly notice the failures.
>
> Sleeping on the second set of tests make the failures go away.
>
> Cc: David Ahern <dsahern at gmail.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: David Ahern <dsahern at gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: dsahern@gmail.com (David Ahern)
Subject: [PATCH] selftests: fib_tests: sleep after changing carrier. again.
Date: Fri, 22 Feb 2019 17:37:41 -0500 [thread overview]
Message-ID: <767c0a6e-41a4-e1cd-00a4-197cbcb41af5@gmail.com> (raw)
Message-ID: <20190222223741.khuDLmpQzJy0D2VbV8GiV6675IJes19P1vRz3SzBm5E@z> (raw)
In-Reply-To: <20190222102741.31173-1-cascardo@canonical.com>
On 2/22/19 5:27 AM, Thadeu Lima de Souza Cascardo wrote:
> Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after
> changing carrier"), wait one second to allow linkwatch to propagate the
> carrier change to the stack.
>
> There are two sets of carrier tests. The first slept after the carrier
> was set to off, and when the second set ran, it was likely that the
> linkwatch would be able to run again without much delay, reducing the
> likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a
> loop, you will quickly notice the failures.
>
> Sleeping on the second set of tests make the failures go away.
>
> Cc: David Ahern <dsahern at gmail.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: David Ahern <dsahern at gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] selftests: fib_tests: sleep after changing carrier. again.
Date: Fri, 22 Feb 2019 17:37:41 -0500 [thread overview]
Message-ID: <767c0a6e-41a4-e1cd-00a4-197cbcb41af5@gmail.com> (raw)
In-Reply-To: <20190222102741.31173-1-cascardo@canonical.com>
On 2/22/19 5:27 AM, Thadeu Lima de Souza Cascardo wrote:
> Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after
> changing carrier"), wait one second to allow linkwatch to propagate the
> carrier change to the stack.
>
> There are two sets of carrier tests. The first slept after the carrier
> was set to off, and when the second set ran, it was likely that the
> linkwatch would be able to run again without much delay, reducing the
> likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a
> loop, you will quickly notice the failures.
>
> Sleeping on the second set of tests make the failures go away.
>
> Cc: David Ahern <dsahern@gmail.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
> tools/testing/selftests/net/fib_tests.sh | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2019-02-22 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 10:27 [PATCH] selftests: fib_tests: sleep after changing carrier. again cascardo
2019-02-22 10:27 ` Thadeu Lima de Souza Cascardo
2019-02-22 10:27 ` Thadeu Lima de Souza Cascardo
2019-02-22 22:37 ` dsahern [this message]
2019-02-22 22:37 ` David Ahern
2019-02-22 22:37 ` David Ahern
2019-02-24 2:34 ` davem
2019-02-24 2:34 ` David Miller
2019-02-24 2:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=767c0a6e-41a4-e1cd-00a4-197cbcb41af5@gmail.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.