All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: usb: qcom,dwc3: Add ipq5210 to USB DWC3 bindings
Date: Fri, 15 May 2026 13:05:56 +0200	[thread overview]
Message-ID: <76fa199b-d0dd-46e2-a927-15371d4c0d09@kernel.org> (raw)
In-Reply-To: <20260515-usb2phy-v1-3-5f8338d466bf@oss.qualcomm.com>

On 15/05/2026 12:47, Varadarajan Narayanan wrote:
> Update dt-bindings to add ipq5210 to USB DWC3 controller list.
> 
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>  1 file changed, 1 insertion(+)

Same feedback as usually. What USB patch is doing here?

Also, other typical comment:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Considering that did not pass through internal review toolset and it has
trivial issues, which this toolset and internal review is suppose to
catch, I drop all patches from you from the DT Patchwork.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: usb: qcom,dwc3: Add ipq5210 to USB DWC3 bindings
Date: Fri, 15 May 2026 13:05:56 +0200	[thread overview]
Message-ID: <76fa199b-d0dd-46e2-a927-15371d4c0d09@kernel.org> (raw)
In-Reply-To: <20260515-usb2phy-v1-3-5f8338d466bf@oss.qualcomm.com>

On 15/05/2026 12:47, Varadarajan Narayanan wrote:
> Update dt-bindings to add ipq5210 to USB DWC3 controller list.
> 
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>  1 file changed, 1 insertion(+)

Same feedback as usually. What USB patch is doing here?

Also, other typical comment:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Considering that did not pass through internal review toolset and it has
trivial issues, which this toolset and internal review is suppose to
catch, I drop all patches from you from the DT Patchwork.

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-05-15 11:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 10:47 [PATCH 0/5] Enable ipq5210 USB support Varadarajan Narayanan
2026-05-15 10:47 ` Varadarajan Narayanan
2026-05-15 10:47 ` [PATCH 1/5] dt-bindings: phy: qcom,qusb2: Document ipq5210 compatible Varadarajan Narayanan
2026-05-15 10:47   ` Varadarajan Narayanan
2026-05-15 10:47 ` [PATCH 2/5] dt-bindings: phy: qcom,qmp-usb: Add ipq5210 USB3 PHY Varadarajan Narayanan
2026-05-15 10:47   ` Varadarajan Narayanan
2026-05-15 11:13   ` sashiko-bot
2026-05-15 11:13     ` sashiko-bot
2026-05-15 10:47 ` [PATCH 3/5] dt-bindings: usb: qcom,dwc3: Add ipq5210 to USB DWC3 bindings Varadarajan Narayanan
2026-05-15 10:47   ` Varadarajan Narayanan
2026-05-15 11:05   ` Krzysztof Kozlowski [this message]
2026-05-15 11:05     ` Krzysztof Kozlowski
2026-05-15 11:18   ` sashiko-bot
2026-05-15 11:18     ` sashiko-bot
2026-05-15 10:47 ` [PATCH 4/5] phy: qcom: qmp: Enable ipq5210 support Varadarajan Narayanan
2026-05-15 10:47   ` Varadarajan Narayanan
2026-05-15 11:29   ` Konrad Dybcio
2026-05-15 11:29     ` Konrad Dybcio
2026-05-15 10:47 ` [PATCH 5/5] phy: qcom-qusb2: add QUSB2 support for ipq5210 Varadarajan Narayanan
2026-05-15 10:47   ` Varadarajan Narayanan
2026-05-15 11:28   ` sashiko-bot
2026-05-15 11:28     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76fa199b-d0dd-46e2-a927-15371d4c0d09@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=varadarajan.narayanan@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.