Implement PCIeType Property

Implement PCIeType Property

[Spencer Ku (古世瑜)]

Hi All,
  We would like to implement PCIeInterface "PCIeType" property on both peci-pcie and bmcweb, then I find the PR which implement inventory properties like SparePartNumber, Model, PartNumber, SerialNumber for PCIe devices in bmcweb: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40051

I think we modify similar part of bmcweb, but I am not sure does it will implement "PCIeType" property in the future. So could we implement "PCIeType" property first since the PR status is WIP? 

About the implement method, for peci-pcie part, first we use peci command to get the pointer of capability in PCI configure space. Then go through capability structure to find capability ID in 3rd capability structure. If the ID is PCI Express, then get the link speed in link status register. Finally, set the PCIeType property to D-Bus after translating (under /xyz/openbmc_project/PCIe/<str>) .

And for bmcweb part, we will create PCIeInterface {"PCIeType"} level (under /redfish/v1/Systems/system/PCIeDevices/<str>/ ) and fill the info from D-bus. 

On the other hand, we also interested about how to get PartNumber and SerialNumber information? I already try to get from FRU over I2C but I cannot mapping the info between FRU and peci-pcie, or is it can easily get by peci-pcie? Any comments and suggestions are welcome!

Please let us know if there's any issue, thank you!

Sincerely,
Spencer Ku

Re: Implement PCIeType Property

[Bills, Jason M]

On 5/27/2021 12:09 AM, Spencer Ku (古世瑜) wrote:
> Hi All,
>    We would like to implement PCIeInterface "PCIeType" property on both peci-pcie and bmcweb, then I find the PR which implement inventory properties like SparePartNumber, Model, PartNumber, SerialNumber for PCIe devices in bmcweb: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40051
> 
> I think we modify similar part of bmcweb, but I am not sure does it will implement "PCIeType" property in the future. So could we implement "PCIeType" property first since the PR status is WIP?
> 
> About the implement method, for peci-pcie part, first we use peci command to get the pointer of capability in PCI configure space. Then go through capability structure to find capability ID in 3rd capability structure. If the ID is PCI Express, then get the link speed in link status register. Finally, set the PCIeType property to D-Bus after translating (under /xyz/openbmc_project/PCIe/<str>) . >
> And for bmcweb part, we will create PCIeInterface {"PCIeType"} level (under /redfish/v1/Systems/system/PCIeDevices/<str>/ ) and fill the info from D-bus.
> 
> On the other hand, we also interested about how to get PartNumber and SerialNumber information? I already try to get from FRU over I2C but I cannot mapping the info between FRU and peci-pcie, or is it can easily get by peci-pcie? Any comments and suggestions are welcome!
peci-pcie currently can only get information that is available over PCI. 
  If these new fields come from somewhere other than PCI, it could be 
difficult to add them.

If these new fields all come from the FRU, then we should already have 
that data in other applications, so we shouldn't need to get it in a PCI 
application.

It may be good to discuss the design a bit for 
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40051.  For 
example, I think FruDevice already has the FRU information for the PCIe 
devices.  Does the PCI application need to communicate with FruDevice 
and expose the same information again in the PCIe inventory on D-Bus? 
Or, should bmcweb directly look for the FruDevice to populate these new 
fields?
> 
> Please let us know if there's any issue, thank you!
> 
> Sincerely,
> Spencer Ku
> 

RE: Implement PCIeType Property

[Spencer Ku (古世瑜)]

Hi Bills,
Thanks for your suggestions!

> -----Original Message-----
> From: openbmc
> <openbmc-bounces+spencer.ku=quantatw.com@lists.ozlabs.org> On Behalf Of
> Bills, Jason M
> Sent: Thursday, May 27, 2021 11:27 PM
> To: openbmc@lists.ozlabs.org
> Subject: Re: Implement PCIeType Property
> 
> 
> 
> On 5/27/2021 12:09 AM, Spencer Ku (古世瑜) wrote:
> > Hi All,
> >    We would like to implement PCIeInterface "PCIeType" property on
> > both peci-pcie and bmcweb, then I find the PR which implement
> > inventory properties like SparePartNumber, Model, PartNumber,
> > SerialNumber for PCIe devices in bmcweb:
> > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerr
> >
> it.openbmc-project.xyz%2Fc%2Fopenbmc%2Fbmcweb%2F%2B%2F40051&amp;
> data=0
> >
> 4%7C01%7CSpencer.Ku%40quantatw.com%7Ccbc719c5057040f0540308d9212
> 42702%
> >
> 7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637577261446247949
> %7CUnkn
> >
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> aWwi
> >
> LCJXVCI6Mn0%3D%7C1000&amp;sdata=cp1tGa%2FR7fp2yKODaB8HX8%2BXPS
> mVGjHj4R
> > E6XANstic%3D&amp;reserved=0
> >
> > I think we modify similar part of bmcweb, but I am not sure does it will
> implement "PCIeType" property in the future. So could we implement
> "PCIeType" property first since the PR status is WIP?
> >
> > About the implement method, for peci-pcie part, first we use peci
> > command to get the pointer of capability in PCI configure space. Then go
> through capability structure to find capability ID in 3rd capability structure. If
> the ID is PCI Express, then get the link speed in link status register. Finally, set
> the PCIeType property to D-Bus after translating (under
> /xyz/openbmc_project/PCIe/<str>) . > And for bmcweb part, we will create
> PCIeInterface {"PCIeType"} level (under
> /redfish/v1/Systems/system/PCIeDevices/<str>/ ) and fill the info from D-bus.
> >
> > On the other hand, we also interested about how to get PartNumber and
> SerialNumber information? I already try to get from FRU over I2C but I cannot
> mapping the info between FRU and peci-pcie, or is it can easily get by
> peci-pcie? Any comments and suggestions are welcome!
> peci-pcie currently can only get information that is available over PCI.
>   If these new fields come from somewhere other than PCI, it could be
> difficult to add them.
Yes, it is actually the question what I meet. Since it is hard to add them together, I am try to find is there a way to get those data over PCI. 
>
> If these new fields all come from the FRU, then we should already have that
> data in other applications, so we shouldn't need to get it in a PCI application.
I think this is because redfish schema defined the property and it is convenience if we can get PCI information through one redfish URI.
But of course it should be a feasible method.
> 
> It may be good to discuss the design a bit for
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.op
> enbmc-project.xyz%2Fc%2Fopenbmc%2Fbmcweb%2F%2B%2F40051&amp;data
> =04%7C01%7CSpencer.Ku%40quantatw.com%7Ccbc719c5057040f0540308d92
> 1242702%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637577261
> 446247949%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=cp1tGa%2FR
> 7fp2yKODaB8HX8%2BXPSmVGjHj4RE6XANstic%3D&amp;reserved=0.  For
> example, I think FruDevice already has the FRU information for the PCIe
> devices.  Does the PCI application need to communicate with FruDevice and
> expose the same information again in the PCIe inventory on D-Bus?
> Or, should bmcweb directly look for the FruDevice to populate these new
> fields?
Yes, I think that's the good point to discuss about the design. I will put my comment to the PR.
> >
> > Please let us know if there's any issue, thank you!
> >
> > Sincerely,
> > Spencer Ku
> >

RE: Implement PCIeType Property

[Spencer Ku (古世瑜)]

> -----Original Message-----
> From: openbmc
> <openbmc-bounces+spencer.ku=quantatw.com@lists.ozlabs.org> On Behalf Of
> Bills, Jason M
> Sent: Thursday, May 27, 2021 11:27 PM
> To: openbmc@lists.ozlabs.org
> Subject: Re: Implement PCIeType Property
> 
> 
> 
> On 5/27/2021 12:09 AM, Spencer Ku (古世瑜) wrote:
> > Hi All,
> >    We would like to implement PCIeInterface "PCIeType" property on
> > both peci-pcie and bmcweb, then I find the PR which implement
> > inventory properties like SparePartNumber, Model, PartNumber,
> > SerialNumber for PCIe devices in bmcweb:
> > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerr
> >
> it.openbmc-project.xyz%2Fc%2Fopenbmc%2Fbmcweb%2F%2B%2F40051&amp;
> data=0
> >
> 4%7C01%7CSpencer.Ku%40quantatw.com%7Ccbc719c5057040f0540308d9212
> 42702%
> >
> 7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637577261446247949
> %7CUnkn
> >
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> aWwi
> >
> LCJXVCI6Mn0%3D%7C1000&amp;sdata=cp1tGa%2FR7fp2yKODaB8HX8%2BXPS
> mVGjHj4R
> > E6XANstic%3D&amp;reserved=0
> >
> > I think we modify similar part of bmcweb, but I am not sure does it will
> implement "PCIeType" property in the future. So could we implement
> "PCIeType" property first since the PR status is WIP?
> >
> > About the implement method, for peci-pcie part, first we use peci
> > command to get the pointer of capability in PCI configure space. Then go
> through capability structure to find capability ID in 3rd capability structure. If
> the ID is PCI Express, then get the link speed in link status register. Finally, set
> the PCIeType property to D-Bus after translating (under
> /xyz/openbmc_project/PCIe/<str>) . > And for bmcweb part, we will create
> PCIeInterface {"PCIeType"} level (under
> /redfish/v1/Systems/system/PCIeDevices/<str>/ ) and fill the info from D-bus.
> >
> > On the other hand, we also interested about how to get PartNumber and
> SerialNumber information? I already try to get from FRU over I2C but I cannot
> mapping the info between FRU and peci-pcie, or is it can easily get by
> peci-pcie? Any comments and suggestions are welcome!
> peci-pcie currently can only get information that is available over PCI.
>   If these new fields come from somewhere other than PCI, it could be
> difficult to add them.

Hi Jason,
Thanks for your suggestions! Yes, it is actually the question what I meet. Since it is hard to add them together, I am try to find is there a way to get those data over PCI.

> 
> If these new fields all come from the FRU, then we should already have that
> data in other applications, so we shouldn't need to get it in a PCI application.

I think this is because redfish schema defined the property and it is convenience if we can get PCI information through one redfish URI.
But of course it should be a feasible method.

> 
> It may be good to discuss the design a bit for
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.op
> enbmc-project.xyz%2Fc%2Fopenbmc%2Fbmcweb%2F%2B%2F40051&amp;data
> =04%7C01%7CSpencer.Ku%40quantatw.com%7Ccbc719c5057040f0540308d92
> 1242702%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637577261
> 446247949%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=cp1tGa%2FR
> 7fp2yKODaB8HX8%2BXPSmVGjHj4RE6XANstic%3D&amp;reserved=0.  For
> example, I think FruDevice already has the FRU information for the PCIe
> devices.  Does the PCI application need to communicate with FruDevice and
> expose the same information again in the PCIe inventory on D-Bus?
> Or, should bmcweb directly look for the FruDevice to populate these new
> fields?

Yes, I think that's the good point to discuss about the design. I will put my comment to the PR.
Hi Sunny, Do you have any opinion on this topic?

> >
> > Please let us know if there's any issue, thank you!
> >
> > Sincerely,
> > Spencer Ku
> >