[PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Vignesh Raman]

Add jobs to validate devicetrees and run KUnit tests.

Pipeline link,
https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550

Link to v1,
https://lore.kernel.org/all/20250327160117.945165-1-vignesh.raman@collabora.com/

Vignesh Raman (2):
  drm/ci: Add jobs to validate devicetrees
  drm/ci: Add jobs to run KUnit tests

 drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
 drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
 drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
 drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
 drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
 drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
 6 files changed, 123 insertions(+)
 create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
 create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
 create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
 create mode 100755 drivers/gpu/drm/ci/kunit.sh
 create mode 100644 drivers/gpu/drm/ci/kunit.yml

-- 
2.47.2

[PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

[Vignesh Raman]

Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
exit with a non-zero error code while configuring them as warning in
the GitLab CI pipeline.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---

v2:
  - Use LLVM to build.

---
 drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
 drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
 drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
 drivers/gpu/drm/ci/gitlab-ci.yml         |  1 +
 4 files changed, 79 insertions(+)
 create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
 create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
 create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh

diff --git a/drivers/gpu/drm/ci/check-devicetrees.yml b/drivers/gpu/drm/ci/check-devicetrees.yml
new file mode 100644
index 000000000000..bc96061abe5b
--- /dev/null
+++ b/drivers/gpu/drm/ci/check-devicetrees.yml
@@ -0,0 +1,43 @@
+.dt-check-base:
+  timeout: "30m"
+  variables:
+    FF_USE_NEW_BASH_EVAL_STRATEGY: 'true'
+    SCHEMA: "display"
+  before_script:
+    - apt-get update -qq
+    - apt-get install -y --no-install-recommends clang lld llvm python3-pip yamllint
+    - pip3 install dtschema
+  script:
+    - drivers/gpu/drm/ci/${SCRIPT_NAME}
+  artifacts:
+    when: on_failure
+    paths:
+      - ${ARTIFACT_FILE}
+  allow_failure:
+    exit_codes:
+      - 102
+
+dtbs-check:arm32:
+  extends:
+    - .build:arm32
+    - .dt-check-base
+  variables:
+    SCRIPT_NAME: "dtbs-check.sh"
+    ARTIFACT_FILE: "dtbs-check.log"
+
+dtbs-check:arm64:
+  extends:
+    - .build:arm64
+    - .dt-check-base
+  variables:
+    SCRIPT_NAME: "dtbs-check.sh"
+    ARTIFACT_FILE: "dtbs-check.log"
+
+dt-binding-check:
+  extends:
+    - .build
+    - .use-debian/x86_64_build
+    - .dt-check-base
+  variables:
+    SCRIPT_NAME: "dt-binding-check.sh"
+    ARTIFACT_FILE: "dt-binding-check.log"
diff --git a/drivers/gpu/drm/ci/dt-binding-check.sh b/drivers/gpu/drm/ci/dt-binding-check.sh
new file mode 100755
index 000000000000..5e9a439c48a4
--- /dev/null
+++ b/drivers/gpu/drm/ci/dt-binding-check.sh
@@ -0,0 +1,16 @@
+#!/bin/bash
+# SPDX-License-Identifier: MIT
+
+set -euxo pipefail
+
+if ! make -j"${FDO_CI_CONCURRENT:-4}" dt_binding_check \
+        DT_SCHEMA_FILES="${SCHEMA:-}" 2>dt-binding-check.log; then
+    echo "ERROR: 'make dt_binding_check' failed. Please check dt-binding-check.log for details."
+    exit 1
+fi
+
+if [[ -s dt-binding-check.log ]]; then
+    echo "WARNING: dt_binding_check reported warnings. Please check dt-binding-check.log" \
+         "for details."
+    exit 102
+fi
diff --git a/drivers/gpu/drm/ci/dtbs-check.sh b/drivers/gpu/drm/ci/dtbs-check.sh
new file mode 100755
index 000000000000..91212f19fb98
--- /dev/null
+++ b/drivers/gpu/drm/ci/dtbs-check.sh
@@ -0,0 +1,19 @@
+#!/bin/bash
+# SPDX-License-Identifier: MIT
+
+set -euxo pipefail
+
+: "${KERNEL_ARCH:?ERROR: KERNEL_ARCH must be set}"
+
+make LLVM=1 ARCH="${KERNEL_ARCH}" defconfig
+
+if ! make -j"${FDO_CI_CONCURRENT:-4}" ARCH="${KERNEL_ARCH}" LLVM=1 dtbs_check \
+        DT_SCHEMA_FILES="${SCHEMA:-}" 2>dtbs-check.log; then
+    echo "ERROR: 'make dtbs_check' failed. Please check dtbs-check.log for details."
+    exit 1
+fi
+
+if [[ -s dtbs-check.log ]]; then
+    echo "WARNING: dtbs_check reported warnings. Please check dtbs-check.log for details."
+    exit 102
+fi
diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
index 65adcd97e06b..9e61b49e9960 100644
--- a/drivers/gpu/drm/ci/gitlab-ci.yml
+++ b/drivers/gpu/drm/ci/gitlab-ci.yml
@@ -108,6 +108,7 @@ include:
   - drivers/gpu/drm/ci/static-checks.yml
   - drivers/gpu/drm/ci/build.yml
   - drivers/gpu/drm/ci/test.yml
+  - drivers/gpu/drm/ci/check-devicetrees.yml
   - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'
 
 
-- 
2.47.2

Re: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

[Maxime Ripard]

On Wed, 9 Apr 2025 11:45:38 +0530, Vignesh Raman wrote:
> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
> exit with a non-zero error code while configuring them as warning in
> the GitLab CI pipeline.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

Re: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

[Dmitry Baryshkov]

On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote:
> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
> exit with a non-zero error code while configuring them as warning in
> the GitLab CI pipeline.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
> 
> v2:
>   - Use LLVM to build.

Why?

>

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

[Vignesh Raman]

Hi Dmitry,

On 11/04/25 01:02, Dmitry Baryshkov wrote:
> On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote:
>> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
>> exit with a non-zero error code while configuring them as warning in
>> the GitLab CI pipeline.
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>> ---
>>
>> v2:
>>    - Use LLVM to build.
> 
> Why?

We are using LLVM/Clang instead of GCC to avoid architecture-specific 
toolchain for cross compiling. This is done to make the script generic 
and run only kunit tests. I will update this section.

> 
>>
> 
> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> 
> 

Thanks.

Regards,
Vignesh

Re: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

[Dmitry Baryshkov]

On Fri, 11 Apr 2025 at 11:32, Vignesh Raman <vignesh.raman@collabora.com> wrote:
>
> Hi Dmitry,
>
> On 11/04/25 01:02, Dmitry Baryshkov wrote:
> > On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote:
> >> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen,
> >> exit with a non-zero error code while configuring them as warning in
> >> the GitLab CI pipeline.
> >>
> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> >> ---
> >>
> >> v2:
> >>    - Use LLVM to build.
> >
> > Why?
>
> We are using LLVM/Clang instead of GCC to avoid architecture-specific
> toolchain for cross compiling. This is done to make the script generic
> and run only kunit tests. I will update this section.

Ack




-- 
With best wishes
Dmitry

[PATCH v2 2/2] drm/ci: Add jobs to run KUnit tests

[Vignesh Raman]

Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---

v2:
  - Run KUnit tests with LLVM.

---
 drivers/gpu/drm/ci/gitlab-ci.yml |  1 +
 drivers/gpu/drm/ci/kunit.sh      | 11 +++++++++++
 drivers/gpu/drm/ci/kunit.yml     | 32 ++++++++++++++++++++++++++++++++
 3 files changed, 44 insertions(+)
 create mode 100755 drivers/gpu/drm/ci/kunit.sh
 create mode 100644 drivers/gpu/drm/ci/kunit.yml

diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
index 9e61b49e9960..90ae57ca86a1 100644
--- a/drivers/gpu/drm/ci/gitlab-ci.yml
+++ b/drivers/gpu/drm/ci/gitlab-ci.yml
@@ -109,6 +109,7 @@ include:
   - drivers/gpu/drm/ci/build.yml
   - drivers/gpu/drm/ci/test.yml
   - drivers/gpu/drm/ci/check-devicetrees.yml
+  - drivers/gpu/drm/ci/kunit.yml
   - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'
 
 
diff --git a/drivers/gpu/drm/ci/kunit.sh b/drivers/gpu/drm/ci/kunit.sh
new file mode 100755
index 000000000000..90b8713ce7a2
--- /dev/null
+++ b/drivers/gpu/drm/ci/kunit.sh
@@ -0,0 +1,11 @@
+#!/bin/bash
+# SPDX-License-Identifier: MIT
+
+set -euxo pipefail
+
+: "${KERNEL_ARCH:?ERROR: KERNEL_ARCH must be set}"
+
+./tools/testing/kunit/kunit.py run \
+  --arch "${KERNEL_ARCH}" \
+  --make_option LLVM=1 \
+  --kunitconfig=drivers/gpu/drm/tests
diff --git a/drivers/gpu/drm/ci/kunit.yml b/drivers/gpu/drm/ci/kunit.yml
new file mode 100644
index 000000000000..405c8fc8239a
--- /dev/null
+++ b/drivers/gpu/drm/ci/kunit.yml
@@ -0,0 +1,32 @@
+.kunit-packages: &kunit-packages
+  - apt-get update -qq
+  - apt-get install -y --no-install-recommends clang lld llvm
+
+.kunit-base:
+  timeout: "30m"
+  script:
+    - drivers/gpu/drm/ci/kunit.sh
+
+kunit:arm32:
+  extends:
+    - .build:arm32
+    - .kunit-base
+  before_script:
+    - *kunit-packages
+    - apt-get install -y --no-install-recommends qemu-system-arm
+
+kunit:arm64:
+  extends:
+    - .build:arm64
+    - .kunit-base
+  before_script:
+    - *kunit-packages
+    - apt-get install -y --no-install-recommends qemu-system-aarch64
+
+kunit:x86_64:
+  extends:
+    - .build:x86_64
+    - .kunit-base
+  before_script:
+    - *kunit-packages
+    - apt-get install -y --no-install-recommends qemu-system-x86
-- 
2.47.2

Re: [PATCH v2 2/2] drm/ci: Add jobs to run KUnit tests

[Maxime Ripard]

On Wed, 9 Apr 2025 11:45:39 +0530, Vignesh Raman wrote:
> Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool.
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Reviewed-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Helen Koike]

Hi Vignesh,

Thank you for your patch.

On 09/04/2025 03:15, Vignesh Raman wrote:
> Add jobs to validate devicetrees and run KUnit tests.
> 
> Pipeline link,
> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550

I see the checks are in the same stage as build, does it make sense to 
create another stage? Similar to what was proposed on kci-gitlab?

Also, I don't think it make sense for kunit to be in the build stage. 
Maybe in software-driver? Since kunit runs on a qemu.

Helen

> 
> Link to v1,
> https://lore.kernel.org/all/20250327160117.945165-1-vignesh.raman@collabora.com/
> 
> Vignesh Raman (2):
>    drm/ci: Add jobs to validate devicetrees
>    drm/ci: Add jobs to run KUnit tests
> 
>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>   6 files changed, 123 insertions(+)
>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
> 

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Vignesh Raman]

Hi Helen,

On 09/04/25 23:53, Helen Koike wrote:
> Hi Vignesh,
> 
> Thank you for your patch.
> 
> On 09/04/2025 03:15, Vignesh Raman wrote:
>> Add jobs to validate devicetrees and run KUnit tests.
>>
>> Pipeline link,
>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550
> 
> I see the checks are in the same stage as build, does it make sense to 
> create another stage? Similar to what was proposed on kci-gitlab?
> 
> Also, I don't think it make sense for kunit to be in the build stage. 
> Maybe in software-driver? Since kunit runs on a qemu.

We can add a `test` stage for kunit and a `static-checks` stage for 
devicetree validation and check patch. What do you think?

Regards,
Vignesh

> 
> Helen
> 
>>
>> Link to v1,
>> https://lore.kernel.org/all/20250327160117.945165-1- 
>> vignesh.raman@collabora.com/
>>
>> Vignesh Raman (2):
>>    drm/ci: Add jobs to validate devicetrees
>>    drm/ci: Add jobs to run KUnit tests
>>
>>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
>>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>>   6 files changed, 123 insertions(+)
>>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>
> 

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Helen Koike]

On 10/04/2025 05:07, Vignesh Raman wrote:
> Hi Helen,
> 
> On 09/04/25 23:53, Helen Koike wrote:
>> Hi Vignesh,
>>
>> Thank you for your patch.
>>
>> On 09/04/2025 03:15, Vignesh Raman wrote:
>>> Add jobs to validate devicetrees and run KUnit tests.
>>>
>>> Pipeline link,
>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550
>>
>> I see the checks are in the same stage as build, does it make sense to 
>> create another stage? Similar to what was proposed on kci-gitlab?
>>
>> Also, I don't think it make sense for kunit to be in the build stage. 
>> Maybe in software-driver? Since kunit runs on a qemu.
> 
> We can add a `test` stage for kunit and a `static-checks` stage for 
> devicetree validation and check patch. What do you think?

Ack on static-checks stage.

`test` stage confuses me, because all the other stages with driver names 
are also tests, this is why I suggested to move to `software-driver`.

Or maybe we could just have a kunit stage for now.

Helen

> 
> Regards,
> Vignesh
> 
>>
>> Helen
>>
>>>
>>> Link to v1,
>>> https://lore.kernel.org/all/20250327160117.945165-1- 
>>> vignesh.raman@collabora.com/
>>>
>>> Vignesh Raman (2):
>>>    drm/ci: Add jobs to validate devicetrees
>>>    drm/ci: Add jobs to run KUnit tests
>>>
>>>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
>>>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>>>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>>>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>>>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>>>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>>>   6 files changed, 123 insertions(+)
>>>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>>>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>>>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>>>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>>>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>>
>>
> 

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Vignesh Raman]

Hi Helen,

On 10/04/25 20:10, Helen Koike wrote:
> 
> 
> On 10/04/2025 05:07, Vignesh Raman wrote:
>> Hi Helen,
>>
>> On 09/04/25 23:53, Helen Koike wrote:
>>> Hi Vignesh,
>>>
>>> Thank you for your patch.
>>>
>>> On 09/04/2025 03:15, Vignesh Raman wrote:
>>>> Add jobs to validate devicetrees and run KUnit tests.
>>>>
>>>> Pipeline link,
>>>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550
>>>
>>> I see the checks are in the same stage as build, does it make sense 
>>> to create another stage? Similar to what was proposed on kci-gitlab?
>>>
>>> Also, I don't think it make sense for kunit to be in the build stage. 
>>> Maybe in software-driver? Since kunit runs on a qemu.
>>
>> We can add a `test` stage for kunit and a `static-checks` stage for 
>> devicetree validation and check patch. What do you think?
> 
> Ack on static-checks stage.

I will update it.

> 
> `test` stage confuses me, because all the other stages with driver names 
> are also tests, this is why I suggested to move to `software-driver`.
> 
> Or maybe we could just have a kunit stage for now.

Yes, we can add kunit stage. Let the `software-driver` have only vkms 
and virtio-gpu tests.

Regards,
Vignesh

> 
> Helen
> 
>>
>> Regards,
>> Vignesh
>>
>>>
>>> Helen
>>>
>>>>
>>>> Link to v1,
>>>> https://lore.kernel.org/all/20250327160117.945165-1- 
>>>> vignesh.raman@collabora.com/
>>>>
>>>> Vignesh Raman (2):
>>>>    drm/ci: Add jobs to validate devicetrees
>>>>    drm/ci: Add jobs to run KUnit tests
>>>>
>>>>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++ 
>>>> ++++
>>>>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>>>>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>>>>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>>>>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>>>>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>>>>   6 files changed, 123 insertions(+)
>>>>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>>>>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>>>>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>>>>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>>>>   create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>>>
>>>
>>
>