Re: [PATCH v6 2/4] x86/ucode: refactor xen-ucode to utilize getopt

[Jan Beulich <jbeulich@suse.com>]

On 25.07.2024 10:27, Fouad Hilly wrote:
> @@ -71,12 +72,29 @@ static void show_curr_cpu(FILE *f)
>      }
>  }
>  
> +static void usage(FILE *stream, const char *name)
> +{
> +    fprintf(stream,
> +            "%s: Xen microcode updating tool\n"
> +            "options:\n"
> +            "  -h, --help            display this help\n"
> +            "  -s, --show-cpu-info   show CPU information\n"
> +            "Usage: %s [microcode file | options]\n", name, name);

You did see Anthony's comments on this before sending the new version,
didn't you? I agree with him (and I'm somewhat embarrassed that I didn't
notice this myself earlier on).

> @@ -146,4 +176,10 @@ int main(int argc, char *argv[])
>      close(fd);
>  
>      return 0;
> +
> + ext_err:
> +    fprintf(stderr,
> +            "%s: unable to process command line arguments\n", argv[0]);
> +    usage(stderr, argv[0]);
> +    exit(EXIT_FAILURE);
>  }

And there was a comment on this, too.

Jan