From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Mark Brown <broonie@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jinmei Wei <weijinmei@linux.spacemit.com>
Subject: Re: [PATCH v4 2/2] ASoC: spacemit: add i2s support for K1 SoC
Date: Tue, 14 Oct 2025 09:14:57 +0800 [thread overview]
Message-ID: <775044E19528DA5A+aO2kEerOWeY8ad0h@kernel.org> (raw)
In-Reply-To: <d1d965c4-f0f4-4b09-b5c3-5925d5f7ce1b@sirena.org.uk>
On Mon, Oct 13, 2025 at 01:05:58PM +0100, Mark Brown wrote:
> On Sun, Sep 21, 2025 at 04:52:17PM +0800, Troy Mitchell wrote:
>
> > + case SND_SOC_DAIFMT_DSP_A:
> > + case SND_SOC_DAIFMT_DSP_B:
> > + snd_pcm_hw_constraint_minmax(substream->runtime,
> > + SNDRV_PCM_HW_PARAM_CHANNELS,
> > + 1, 1);
> > + snd_pcm_hw_constraint_mask64(substream->runtime,
> > + SNDRV_PCM_HW_PARAM_FORMAT,
> > + SNDRV_PCM_FMTBIT_S32_LE);
> > + break;
>
> The handling for one of these is buggy, DSP A and B are distinct modes
> but throughout the driver they're handled identically AFAICT.
Thanks! Indeed, this bug was introduced in this version.
I’ll fix it and send v5 ASAP.
- Troy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Mark Brown <broonie@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jinmei Wei <weijinmei@linux.spacemit.com>
Subject: Re: [PATCH v4 2/2] ASoC: spacemit: add i2s support for K1 SoC
Date: Tue, 14 Oct 2025 09:14:57 +0800 [thread overview]
Message-ID: <775044E19528DA5A+aO2kEerOWeY8ad0h@kernel.org> (raw)
In-Reply-To: <d1d965c4-f0f4-4b09-b5c3-5925d5f7ce1b@sirena.org.uk>
On Mon, Oct 13, 2025 at 01:05:58PM +0100, Mark Brown wrote:
> On Sun, Sep 21, 2025 at 04:52:17PM +0800, Troy Mitchell wrote:
>
> > + case SND_SOC_DAIFMT_DSP_A:
> > + case SND_SOC_DAIFMT_DSP_B:
> > + snd_pcm_hw_constraint_minmax(substream->runtime,
> > + SNDRV_PCM_HW_PARAM_CHANNELS,
> > + 1, 1);
> > + snd_pcm_hw_constraint_mask64(substream->runtime,
> > + SNDRV_PCM_HW_PARAM_FORMAT,
> > + SNDRV_PCM_FMTBIT_S32_LE);
> > + break;
>
> The handling for one of these is buggy, DSP A and B are distinct modes
> but throughout the driver they're handled identically AFAICT.
Thanks! Indeed, this bug was introduced in this version.
I’ll fix it and send v5 ASAP.
- Troy
next prev parent reply other threads:[~2025-10-14 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 8:52 [PATCH v4 0/2] ASoC: spacemit: add i2s support to K1 SoC Troy Mitchell
2025-09-21 8:52 ` Troy Mitchell
2025-09-21 8:52 ` [PATCH v4 1/2] ASoC: dt-bindings: Add bindings for SpacemiT K1 Troy Mitchell
2025-09-21 8:52 ` Troy Mitchell
2025-09-21 8:52 ` [PATCH v4 2/2] ASoC: spacemit: add i2s support for K1 SoC Troy Mitchell
2025-09-21 8:52 ` Troy Mitchell
2025-10-13 12:05 ` Mark Brown
2025-10-13 12:05 ` Mark Brown
2025-10-14 1:14 ` Troy Mitchell [this message]
2025-10-14 1:14 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=775044E19528DA5A+aO2kEerOWeY8ad0h@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=weijinmei@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.