Re: kernel/trace/rv/monitors/wip/wip.c:20:1: sparse: sparse: symbol 'da_mon_wip' was not declared. Should it be static?

[Daniel Bristot de Oliveira <bristot@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3008 bytes --]

On 8/22/22 16:43, Steven Rostedt wrote:
> On Sun, 21 Aug 2022 03:57:25 +0800
> kernel test robot <lkp@intel.com> wrote:
> 
>> Hi Stephen,
>>
> 
> I don't know who this "Stephen" is. There's no-one on the Cc list named
> that.
> 
>> First bad commit (maybe != root cause):
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   50cd95ac46548429e5bba7ca75cc97d11a697947
>> commit: 10bde81c74863472047f31304064018c40f488ee rv/monitor: Add the wip monitor
>> date:   3 weeks ago
>> config: arm64-randconfig-s032-20220820 (https://download.01.org/0day-ci/archive/20220821/202208210332.gtHXje45-lkp(a)intel.com/config)
>> compiler: aarch64-linux-gcc (GCC) 12.1.0
>> reproduce:
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # apt-get install sparse
>>         # sparse version: v0.6.4-39-gce1a6720-dirty
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10bde81c74863472047f31304064018c40f488ee
>>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>         git fetch --no-tags linus master
>>         git checkout 10bde81c74863472047f31304064018c40f488ee
>>         # save the config file
>>         mkdir build_dir && cp config build_dir/.config
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash kernel/trace/rv/
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> sparse warnings: (new ones prefixed by >>)
>>    kernel/trace/rv/monitors/wip/wip.c: note: in included file:
>>    kernel/trace/rv/monitors/wip/wip.h:30:22: sparse: sparse: symbol 'automaton_wip' was not declared. Should it be static?
> 
> So we have:
> 
> 
>    struct automaton_wip automaton_wip = {
> 
> Which is used only in the one file that includes it. I'm guessing it should
> be static. Daniel?

Yep, I think it should be. I will change the monitors and to dot2k tomorrow, and test them.

/me is back to work after vacations.

-- Daniel

> -- Steve
> 
> 
>>
>> vim +/da_mon_wip +20 kernel/trace/rv/monitors/wip/wip.c
>>
>> 8812d21219b9c6 Daniel Bristot de Oliveira 2022-07-29  18  
>> 8812d21219b9c6 Daniel Bristot de Oliveira 2022-07-29  19  struct rv_monitor rv_wip;
>> 8812d21219b9c6 Daniel Bristot de Oliveira 2022-07-29 @20  DECLARE_DA_MON_PER_CPU(wip, unsigned char);
>> 8812d21219b9c6 Daniel Bristot de Oliveira 2022-07-29  21  
>>
>> :::::: The code at line 20 was first introduced by commit
>> :::::: 8812d21219b9c649dd25eb93915e00939944aeb7 rv/monitor: Add the wip monitor skeleton created by dot2k
>>
>> :::::: TO: Daniel Bristot de Oliveira <bristot@kernel.org>
>> :::::: CC: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>