From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: ben@simtec.co.uk, linuxppc-dev@ozlabs.org,
linux-mtd@lists.infradead.org,
Laurent Pinchart <laurentp@cse-semaphore.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.
Date: Wed, 26 Mar 2008 16:34:58 +0100 [thread overview]
Message-ID: <777c028aa41fe870542afdb4fa7d2db6@kernel.crashing.org> (raw)
In-Reply-To: <47EA6B11.7050804@ru.mvista.com>
>>> {
>>> + .compatible = "physmap-ram",
>>> + .data = (void *)"map_ram",
>>> + },
>>> + {
>>> + .compatible = "physmap-rom",
>>> + .data = (void *)"map_rom",
>>> + },
>
>> Why the cast? It's redundant afaics.
>
> To be in line with the surrounding code...
I see _that_, but it's not a great argument IMNSHO. Could I trick
you into preceding this patch with a cleanup patch for the existing
casts?
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: ben@simtec.co.uk, linuxppc-dev@ozlabs.org,
linux-mtd@lists.infradead.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.
Date: Wed, 26 Mar 2008 16:34:58 +0100 [thread overview]
Message-ID: <777c028aa41fe870542afdb4fa7d2db6@kernel.crashing.org> (raw)
In-Reply-To: <47EA6B11.7050804@ru.mvista.com>
>>> {
>>> + .compatible = "physmap-ram",
>>> + .data = (void *)"map_ram",
>>> + },
>>> + {
>>> + .compatible = "physmap-rom",
>>> + .data = (void *)"map_rom",
>>> + },
>
>> Why the cast? It's redundant afaics.
>
> To be in line with the surrounding code...
I see _that_, but it's not a great argument IMNSHO. Could I trick
you into preceding this patch with a cleanup patch for the existing
casts?
Segher
next prev parent reply other threads:[~2008-03-26 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 12:44 [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver Laurent Pinchart
2008-03-26 12:44 ` Laurent Pinchart
2008-03-26 14:45 ` Segher Boessenkool
2008-03-26 15:26 ` Sergei Shtylyov
2008-03-26 15:26 ` Sergei Shtylyov
2008-03-26 15:34 ` Segher Boessenkool [this message]
2008-03-26 15:34 ` Segher Boessenkool
2008-03-26 23:37 ` David Gibson
2008-03-26 23:37 ` David Gibson
2008-03-27 9:26 ` Laurent Pinchart
2008-03-27 9:26 ` Laurent Pinchart
2008-04-22 20:09 ` David Woodhouse
2008-04-22 20:09 ` David Woodhouse
2008-04-22 20:16 ` Sergei Shtylyov
2008-04-22 20:16 ` Sergei Shtylyov
2008-04-22 20:18 ` David Woodhouse
2008-04-22 20:18 ` David Woodhouse
2008-04-23 11:12 ` Sergei Shtylyov
2008-04-23 11:12 ` Sergei Shtylyov
2008-04-25 11:53 ` Laurent Pinchart
2008-04-28 16:26 ` [PATCH 1/2] [MTD] Add support for RAM & ROMmappings " Rune Torgersen
2008-04-28 20:30 ` Scott Wood
2008-04-28 20:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777c028aa41fe870542afdb4fa7d2db6@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=ben@simtec.co.uk \
--cc=david@gibson.dropbear.id.au \
--cc=laurentp@cse-semaphore.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.