From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-block@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Jan Kara <jack@suse.cz>, Rabin Vincent <rabinv@axis.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Wei Fang <fangwei1@huawei.com>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime
Date: Mon, 23 Jan 2017 19:17:21 -0200 [thread overview]
Message-ID: <7780787.RVFXFXDN3H@morokweng> (raw)
In-Reply-To: <148375097100.37020.495735345355345658.stgit@dwillia2-desk3.amr.corp.intel.com>
Hello Dan,
Am Freitag, 6. Januar 2017, 17:02:51 BRST schrieb Dan Williams:
> v1 of these changes [1] was a one line change to bdev_get_queue() to
> prevent a shutdown crash when del_gendisk() races the final
> __blkdev_put().
>
> While it is known at del_gendisk() time that the queue is still alive,
> Jan Kara points to other paths [2] that are racing __blkdev_put() where
> the assumption that ->bd_queue, or inode->i_wb is valid does not hold.
>
> Fix that broken assumption, make it the case that if you have a live
> block_device, or block_device-inode that the corresponding queue and
> inode-write-back data is still valid.
>
> These changes survive a run of the libnvdimm unit test suite which puts
> some stress on the block_device shutdown path.
I realize that the kernel test robot found problems with this series, but FWIW
it fixes the bug mentioned in [2].
> [1]: http://marc.info/?l=linux-block&m=148366637105761&w=2
> [2]: http://www.spinics.net/lists/linux-fsdevel/msg105153.html
--
Thiago Jung Bauermann
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Rabin Vincent <rabinv@axis.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Wei Fang <fangwei1@huawei.com>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime
Date: Mon, 23 Jan 2017 19:17:21 -0200 [thread overview]
Message-ID: <7780787.RVFXFXDN3H@morokweng> (raw)
In-Reply-To: <148375097100.37020.495735345355345658.stgit@dwillia2-desk3.amr.corp.intel.com>
Hello Dan,
Am Freitag, 6. Januar 2017, 17:02:51 BRST schrieb Dan Williams:
> v1 of these changes [1] was a one line change to bdev_get_queue() to
> prevent a shutdown crash when del_gendisk() races the final
> __blkdev_put().
>
> While it is known at del_gendisk() time that the queue is still alive,
> Jan Kara points to other paths [2] that are racing __blkdev_put() where
> the assumption that ->bd_queue, or inode->i_wb is valid does not hold.
>
> Fix that broken assumption, make it the case that if you have a live
> block_device, or block_device-inode that the corresponding queue and
> inode-write-back data is still valid.
>
> These changes survive a run of the libnvdimm unit test suite which puts
> some stress on the block_device shutdown path.
I realize that the kernel test robot found problems with this series, but FWIW
it fixes the bug mentioned in [2].
> [1]: http://marc.info/?l=linux-block&m=148366637105761&w=2
> [2]: http://www.spinics.net/lists/linux-fsdevel/msg105153.html
--
Thiago Jung Bauermann
IBM Linux Technology Center
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-block@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Jan Kara <jack@suse.cz>, Rabin Vincent <rabinv@axis.com>,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Wei Fang <fangwei1@huawei.com>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime
Date: Mon, 23 Jan 2017 19:17:21 -0200 [thread overview]
Message-ID: <7780787.RVFXFXDN3H@morokweng> (raw)
In-Reply-To: <148375097100.37020.495735345355345658.stgit@dwillia2-desk3.amr.corp.intel.com>
Hello Dan,
Am Freitag, 6. Januar 2017, 17:02:51 BRST schrieb Dan Williams:
> v1 of these changes [1] was a one line change to bdev_get_queue() to
> prevent a shutdown crash when del_gendisk() races the final
> __blkdev_put().
>
> While it is known at del_gendisk() time that the queue is still alive,
> Jan Kara points to other paths [2] that are racing __blkdev_put() where
> the assumption that ->bd_queue, or inode->i_wb is valid does not hold.
>
> Fix that broken assumption, make it the case that if you have a live
> block_device, or block_device-inode that the corresponding queue and
> inode-write-back data is still valid.
>
> These changes survive a run of the libnvdimm unit test suite which puts
> some stress on the block_device shutdown path.
I realize that the kernel test robot found problems with this series, but FWIW
it fixes the bug mentioned in [2].
> [1]: http://marc.info/?l=linux-block&m=148366637105761&w=2
> [2]: http://www.spinics.net/lists/linux-fsdevel/msg105153.html
--
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2017-01-23 21:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 1:02 [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime Dan Williams
2017-01-07 1:02 ` Dan Williams
2017-01-07 1:02 ` Dan Williams
2017-01-07 1:02 ` [RFC PATCH v2 1/2] block: fix lifetime of request_queue / backing_dev_info relative to bdev Dan Williams
2017-01-07 1:02 ` Dan Williams
2017-01-07 1:02 ` Dan Williams
2017-01-09 2:39 ` [lkp-developer] [block] 1442488925: WARNING:at_mm/backing-dev.c:#bdi_exit kernel test robot
2017-01-09 2:39 ` kernel test robot
2017-01-09 2:39 ` kernel test robot
2017-01-09 2:39 ` kernel test robot
2017-01-07 1:03 ` [RFC PATCH v2 2/2] block: fix blk_get_backing_dev_info() crash, use bdev->bd_queue Dan Williams
2017-01-07 1:03 ` Dan Williams
2017-01-07 1:03 ` Dan Williams
2017-01-23 21:17 ` Thiago Jung Bauermann [this message]
2017-01-23 21:17 ` [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime Thiago Jung Bauermann
2017-01-23 21:17 ` Thiago Jung Bauermann
2017-01-25 21:43 ` Dan Williams
2017-01-25 21:43 ` Dan Williams
2017-01-25 21:43 ` Dan Williams
2017-01-26 10:06 ` Jan Kara
2017-01-26 10:06 ` Jan Kara
2017-01-26 10:06 ` Jan Kara
2017-01-26 13:17 ` Christoph Hellwig
2017-01-26 13:17 ` Christoph Hellwig
2017-01-26 13:17 ` Christoph Hellwig
2017-01-26 16:39 ` Dan Williams
2017-01-26 16:39 ` Dan Williams
2017-01-26 16:39 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7780787.RVFXFXDN3H@morokweng \
--to=bauerman@linux.vnet.ibm.com \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=fangwei1@huawei.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.