From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org
Cc: drinkcat@chromium.org, Yongqiang Niu <yongqiang.niu@mediatek.com>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, CK Hu <ck.hu@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node
Date: Thu, 21 May 2020 12:10:12 +0200 [thread overview]
Message-ID: <77a11bb2-83a1-07b8-e949-eb9e5b37549d@gmail.com> (raw)
In-Reply-To: <2369225e-2a92-c493-d089-e03f792df8cf@gmail.com>
On 14/02/2020 11:06, Matthias Brugger wrote:
>
>
> On 14/02/2020 05:49, Bibby Hsieh wrote:
>> In order to use GCE function, we need add some information
>> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
>>
>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
>> ---
>
> For the next time please provide some context on which patches this are based
> on. Bet below the '---' with a link.
>
> For this time, on which patch/series is this based? :)
Bibby can you please help and rebase the patch against my for-next branch [1].
I'm then happy to queue it. Not sure if we can make it for v5.8 as we are really
late, but we could try :)
Thanks!
Matthias
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=for-next
>
> Thanks,
> Matthias
>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index be4428c92f35..8b522b039a37 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -9,6 +9,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/power/mt8183-power.h>
>> +#include <dt-bindings/gce/mt8183-gce.h>
>> #include "mt8183-pinfunc.h"
>>
>> / {
>> @@ -664,6 +665,9 @@
>> reg = <0 0x14000000 0 0x1000>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> #clock-cells = <1>;
>> + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>,
>> + <&gce 1 CMDQ_THR_PRIO_HIGHEST>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
>> };
>>
>> ovl0: ovl@14008000 {
>> @@ -672,6 +676,7 @@
>> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x8000 0x1000>;
>> };
>>
>> ovl_2l0: ovl@14009000 {
>> @@ -680,6 +685,7 @@
>> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x9000 0x1000>;
>> };
>>
>> ovl_2l1: ovl@1400a000 {
>> @@ -688,6 +694,7 @@
>> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL1_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xa000 0x1000>;
>> };
>>
>> rdma0: rdma@1400b000 {
>> @@ -697,6 +704,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA0>;
>> mediatek,rdma_fifo_size = <5120>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xb000 0x1000>;
>> };
>>
>> rdma1: rdma@1400c000 {
>> @@ -706,6 +714,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA1>;
>> mediatek,rdma_fifo_size = <2048>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
>> };
>>
>> color0: color@1400e000 {
>> @@ -715,6 +724,7 @@
>> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_COLOR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
>> };
>>
>> ccorr0: ccorr@1400f000 {
>> @@ -723,6 +733,7 @@
>> interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_CCORR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
>> };
>>
>> aal0: aal@14010000 {
>> @@ -732,6 +743,7 @@
>> interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_AAL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
>> };
>>
>> gamma0: gamma@14011000 {
>> @@ -741,6 +753,7 @@
>> interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_GAMMA0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
>> };
>>
>> dither0: dither@14012000 {
>> @@ -749,6 +762,7 @@
>> interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_DITHER0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
>> };
>>
>> mutex: mutex@14016000 {
>> @@ -756,6 +770,8 @@
>> reg = <0 0x14016000 0 0x1000>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
>> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
>> };
>>
>> smi_common: smi@14019000 {
>>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org
Cc: drinkcat@chromium.org, Yongqiang Niu <yongqiang.niu@mediatek.com>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, CK Hu <ck.hu@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
YT Shen <yt.shen@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node
Date: Thu, 21 May 2020 12:10:12 +0200 [thread overview]
Message-ID: <77a11bb2-83a1-07b8-e949-eb9e5b37549d@gmail.com> (raw)
In-Reply-To: <2369225e-2a92-c493-d089-e03f792df8cf@gmail.com>
On 14/02/2020 11:06, Matthias Brugger wrote:
>
>
> On 14/02/2020 05:49, Bibby Hsieh wrote:
>> In order to use GCE function, we need add some information
>> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
>>
>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
>> ---
>
> For the next time please provide some context on which patches this are based
> on. Bet below the '---' with a link.
>
> For this time, on which patch/series is this based? :)
Bibby can you please help and rebase the patch against my for-next branch [1].
I'm then happy to queue it. Not sure if we can make it for v5.8 as we are really
late, but we could try :)
Thanks!
Matthias
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=for-next
>
> Thanks,
> Matthias
>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index be4428c92f35..8b522b039a37 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -9,6 +9,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/power/mt8183-power.h>
>> +#include <dt-bindings/gce/mt8183-gce.h>
>> #include "mt8183-pinfunc.h"
>>
>> / {
>> @@ -664,6 +665,9 @@
>> reg = <0 0x14000000 0 0x1000>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> #clock-cells = <1>;
>> + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>,
>> + <&gce 1 CMDQ_THR_PRIO_HIGHEST>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
>> };
>>
>> ovl0: ovl@14008000 {
>> @@ -672,6 +676,7 @@
>> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x8000 0x1000>;
>> };
>>
>> ovl_2l0: ovl@14009000 {
>> @@ -680,6 +685,7 @@
>> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x9000 0x1000>;
>> };
>>
>> ovl_2l1: ovl@1400a000 {
>> @@ -688,6 +694,7 @@
>> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL1_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xa000 0x1000>;
>> };
>>
>> rdma0: rdma@1400b000 {
>> @@ -697,6 +704,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA0>;
>> mediatek,rdma_fifo_size = <5120>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xb000 0x1000>;
>> };
>>
>> rdma1: rdma@1400c000 {
>> @@ -706,6 +714,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA1>;
>> mediatek,rdma_fifo_size = <2048>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
>> };
>>
>> color0: color@1400e000 {
>> @@ -715,6 +724,7 @@
>> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_COLOR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
>> };
>>
>> ccorr0: ccorr@1400f000 {
>> @@ -723,6 +733,7 @@
>> interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_CCORR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
>> };
>>
>> aal0: aal@14010000 {
>> @@ -732,6 +743,7 @@
>> interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_AAL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
>> };
>>
>> gamma0: gamma@14011000 {
>> @@ -741,6 +753,7 @@
>> interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_GAMMA0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
>> };
>>
>> dither0: dither@14012000 {
>> @@ -749,6 +762,7 @@
>> interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_DITHER0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
>> };
>>
>> mutex: mutex@14016000 {
>> @@ -756,6 +770,8 @@
>> reg = <0 0x14016000 0 0x1000>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
>> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
>> };
>>
>> smi_common: smi@14019000 {
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org
Cc: drinkcat@chromium.org, Yongqiang Niu <yongqiang.niu@mediatek.com>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node
Date: Thu, 21 May 2020 12:10:12 +0200 [thread overview]
Message-ID: <77a11bb2-83a1-07b8-e949-eb9e5b37549d@gmail.com> (raw)
In-Reply-To: <2369225e-2a92-c493-d089-e03f792df8cf@gmail.com>
On 14/02/2020 11:06, Matthias Brugger wrote:
>
>
> On 14/02/2020 05:49, Bibby Hsieh wrote:
>> In order to use GCE function, we need add some information
>> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
>>
>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
>> ---
>
> For the next time please provide some context on which patches this are based
> on. Bet below the '---' with a link.
>
> For this time, on which patch/series is this based? :)
Bibby can you please help and rebase the patch against my for-next branch [1].
I'm then happy to queue it. Not sure if we can make it for v5.8 as we are really
late, but we could try :)
Thanks!
Matthias
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=for-next
>
> Thanks,
> Matthias
>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index be4428c92f35..8b522b039a37 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -9,6 +9,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/power/mt8183-power.h>
>> +#include <dt-bindings/gce/mt8183-gce.h>
>> #include "mt8183-pinfunc.h"
>>
>> / {
>> @@ -664,6 +665,9 @@
>> reg = <0 0x14000000 0 0x1000>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> #clock-cells = <1>;
>> + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>,
>> + <&gce 1 CMDQ_THR_PRIO_HIGHEST>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
>> };
>>
>> ovl0: ovl@14008000 {
>> @@ -672,6 +676,7 @@
>> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x8000 0x1000>;
>> };
>>
>> ovl_2l0: ovl@14009000 {
>> @@ -680,6 +685,7 @@
>> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x9000 0x1000>;
>> };
>>
>> ovl_2l1: ovl@1400a000 {
>> @@ -688,6 +694,7 @@
>> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL1_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xa000 0x1000>;
>> };
>>
>> rdma0: rdma@1400b000 {
>> @@ -697,6 +704,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA0>;
>> mediatek,rdma_fifo_size = <5120>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xb000 0x1000>;
>> };
>>
>> rdma1: rdma@1400c000 {
>> @@ -706,6 +714,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA1>;
>> mediatek,rdma_fifo_size = <2048>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
>> };
>>
>> color0: color@1400e000 {
>> @@ -715,6 +724,7 @@
>> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_COLOR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
>> };
>>
>> ccorr0: ccorr@1400f000 {
>> @@ -723,6 +733,7 @@
>> interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_CCORR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
>> };
>>
>> aal0: aal@14010000 {
>> @@ -732,6 +743,7 @@
>> interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_AAL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
>> };
>>
>> gamma0: gamma@14011000 {
>> @@ -741,6 +753,7 @@
>> interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_GAMMA0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
>> };
>>
>> dither0: dither@14012000 {
>> @@ -749,6 +762,7 @@
>> interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_DITHER0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
>> };
>>
>> mutex: mutex@14016000 {
>> @@ -756,6 +770,8 @@
>> reg = <0 0x14016000 0 0x1000>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
>> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
>> };
>>
>> smi_common: smi@14019000 {
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
YT Shen <yt.shen@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>,
CK Hu <ck.hu@mediatek.com>,
linux-arm-kernel@lists.infradead.org, tfiga@chromium.org,
drinkcat@chromium.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com,
Yongqiang Niu <yongqiang.niu@mediatek.com>
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node
Date: Thu, 21 May 2020 12:10:12 +0200 [thread overview]
Message-ID: <77a11bb2-83a1-07b8-e949-eb9e5b37549d@gmail.com> (raw)
In-Reply-To: <2369225e-2a92-c493-d089-e03f792df8cf@gmail.com>
On 14/02/2020 11:06, Matthias Brugger wrote:
>
>
> On 14/02/2020 05:49, Bibby Hsieh wrote:
>> In order to use GCE function, we need add some information
>> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
>>
>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
>> ---
>
> For the next time please provide some context on which patches this are based
> on. Bet below the '---' with a link.
>
> For this time, on which patch/series is this based? :)
Bibby can you please help and rebase the patch against my for-next branch [1].
I'm then happy to queue it. Not sure if we can make it for v5.8 as we are really
late, but we could try :)
Thanks!
Matthias
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=for-next
>
> Thanks,
> Matthias
>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index be4428c92f35..8b522b039a37 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -9,6 +9,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/power/mt8183-power.h>
>> +#include <dt-bindings/gce/mt8183-gce.h>
>> #include "mt8183-pinfunc.h"
>>
>> / {
>> @@ -664,6 +665,9 @@
>> reg = <0 0x14000000 0 0x1000>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> #clock-cells = <1>;
>> + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>,
>> + <&gce 1 CMDQ_THR_PRIO_HIGHEST>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
>> };
>>
>> ovl0: ovl@14008000 {
>> @@ -672,6 +676,7 @@
>> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x8000 0x1000>;
>> };
>>
>> ovl_2l0: ovl@14009000 {
>> @@ -680,6 +685,7 @@
>> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL0_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x9000 0x1000>;
>> };
>>
>> ovl_2l1: ovl@1400a000 {
>> @@ -688,6 +694,7 @@
>> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_OVL1_2L>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xa000 0x1000>;
>> };
>>
>> rdma0: rdma@1400b000 {
>> @@ -697,6 +704,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA0>;
>> mediatek,rdma_fifo_size = <5120>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xb000 0x1000>;
>> };
>>
>> rdma1: rdma@1400c000 {
>> @@ -706,6 +714,7 @@
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_RDMA1>;
>> mediatek,rdma_fifo_size = <2048>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
>> };
>>
>> color0: color@1400e000 {
>> @@ -715,6 +724,7 @@
>> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_COLOR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
>> };
>>
>> ccorr0: ccorr@1400f000 {
>> @@ -723,6 +733,7 @@
>> interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_CCORR0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
>> };
>>
>> aal0: aal@14010000 {
>> @@ -732,6 +743,7 @@
>> interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_AAL0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
>> };
>>
>> gamma0: gamma@14011000 {
>> @@ -741,6 +753,7 @@
>> interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_GAMMA0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
>> };
>>
>> dither0: dither@14012000 {
>> @@ -749,6 +762,7 @@
>> interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> clocks = <&mmsys CLK_MM_DISP_DITHER0>;
>> + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
>> };
>>
>> mutex: mutex@14016000 {
>> @@ -756,6 +770,8 @@
>> reg = <0 0x14016000 0 0x1000>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
>> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
>> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
>> };
>>
>> smi_common: smi@14019000 {
>>
next prev parent reply other threads:[~2020-05-21 10:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 4:49 [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` [PATCH 2/3] drm/mediatek: make sure previous message done or be aborted before send Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 6:48 ` CK Hu
2020-02-14 6:48 ` CK Hu
2020-02-14 6:48 ` CK Hu
2020-02-14 6:48 ` CK Hu
2020-02-18 8:22 ` CK Hu
2020-02-18 8:22 ` CK Hu
2020-02-18 8:22 ` CK Hu
2020-02-18 8:22 ` CK Hu
2020-02-14 4:49 ` [PATCH 3/3] drm/mediatek: move gce event property to mutex device node Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 4:49 ` Bibby Hsieh
2020-02-14 10:06 ` [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node Matthias Brugger
2020-02-14 10:06 ` Matthias Brugger
2020-02-14 10:06 ` Matthias Brugger
2020-02-14 10:06 ` Matthias Brugger
2020-05-21 10:10 ` Matthias Brugger [this message]
2020-05-21 10:10 ` Matthias Brugger
2020-05-21 10:10 ` Matthias Brugger
2020-05-21 10:10 ` Matthias Brugger
2020-05-21 10:47 ` Bibby Hsieh
2020-05-21 10:47 ` Bibby Hsieh
2020-05-21 10:47 ` Bibby Hsieh
2020-05-21 10:47 ` Bibby Hsieh
2020-05-21 12:38 ` Matthias Brugger
2020-05-21 12:38 ` Matthias Brugger
2020-05-21 12:38 ` Matthias Brugger
2020-05-21 12:38 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a11bb2-83a1-07b8-e949-eb9e5b37549d@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.