All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: shmobile: marzen: enable HSPI0 in DTS
Date: Tue, 26 Nov 2013 02:09:50 +0000	[thread overview]
Message-ID: <7829758.zdhJHbHjWn@avalon> (raw)
In-Reply-To: <1385341216-27101-4-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thank you for the patch.

On Monday 25 November 2013 10:00:16 Simon Horman wrote:
> Based on work for the bockw board by Kuninori Morimoto.
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a7779-marzen-reference.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> b/arch/arm/boot/dts/r8a7779-marzen-reference.dts index 918085c..76f5eef
> 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> @@ -97,6 +97,11 @@
>  		renesas,groups = "sdhi0_data4", "sdhi0_ctrl", "sdhi0_cd";
>  		renesas,function = "sdhi0";
>  	};
> +
> +	hspi0_pins: hspi0 {
> +		renesas,groups = "hspi0";
> +		renesas,function = "hspi0";
> +	};

What about keeping the nodes in alphabetical order ?

>  };
> 
>  &sdhi0 {
> @@ -107,3 +112,9 @@
>  	bus-width = <4>;
>  	status = "okay";
>  };
> +
> +&hspi0 {
> +	pinctrl-0 = <&hspi0_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +};

And here too ?

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: shmobile: marzen: enable HSPI0 in DTS
Date: Tue, 26 Nov 2013 03:09:50 +0100	[thread overview]
Message-ID: <7829758.zdhJHbHjWn@avalon> (raw)
In-Reply-To: <1385341216-27101-4-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thank you for the patch.

On Monday 25 November 2013 10:00:16 Simon Horman wrote:
> Based on work for the bockw board by Kuninori Morimoto.
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a7779-marzen-reference.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> b/arch/arm/boot/dts/r8a7779-marzen-reference.dts index 918085c..76f5eef
> 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> @@ -97,6 +97,11 @@
>  		renesas,groups = "sdhi0_data4", "sdhi0_ctrl", "sdhi0_cd";
>  		renesas,function = "sdhi0";
>  	};
> +
> +	hspi0_pins: hspi0 {
> +		renesas,groups = "hspi0";
> +		renesas,function = "hspi0";
> +	};

What about keeping the nodes in alphabetical order ?

>  };
> 
>  &sdhi0 {
> @@ -107,3 +112,9 @@
>  	bus-width = <4>;
>  	status = "okay";
>  };
> +
> +&hspi0 {
> +	pinctrl-0 = <&hspi0_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +};

And here too ?

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2013-11-26  2:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  1:00 [PATCH 0/3] ARM: shmobile: marzen: enable HSPI0 to DTS Simon Horman
2013-11-25  1:00 ` Simon Horman
2013-11-25  1:00 ` [PATCH 1/3] ARM: shmobile: r8a7779: add HSPI clock support for DT Simon Horman
2013-11-25  1:00   ` Simon Horman
2013-11-25  2:15   ` Kuninori Morimoto
2013-11-25  2:15     ` Kuninori Morimoto
2013-11-25  2:21     ` Simon Horman
2013-11-25  2:21       ` Simon Horman
2013-11-25  9:38   ` Sergei Shtylyov
2013-11-25  9:38     ` Sergei Shtylyov
2013-11-26  0:25     ` Simon Horman
2013-11-26  0:25       ` Simon Horman
2013-11-25  1:00 ` [PATCH 2/3] ARM: shmobile: r8a7779: add HSPI support to DTSI Simon Horman
2013-11-25  1:00   ` Simon Horman
2013-11-25  1:00 ` [PATCH 3/3] ARM: shmobile: marzen: enable HSPI0 in DTS Simon Horman
2013-11-25  1:00   ` Simon Horman
2013-11-26  2:09   ` Laurent Pinchart [this message]
2013-11-26  2:09     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7829758.zdhJHbHjWn@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.