All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: dts: mt8135: Add pinctrl node for mt8135.
Date: Tue, 23 Sep 2014 16:10:09 +0200	[thread overview]
Message-ID: <7840459.vtELiqVIOL@wuerfel> (raw)
In-Reply-To: <1411480694.21299.18.camel@mtksdaap41>

On Tuesday 23 September 2014 21:58:14 Joe. C wrote:
> Thanks for review. 
> The intend for these macros is helpin pinctrl user to write DT node.
> With these macro, we could write like this for i2c0:
> 
> mediatek,pinfunc = <MT8135_PIN_100_SDA0__FUNC_SDA0 
>                         MT8135_PIN_101_SCL0__FUNC_SCL0>;
> 
> We feel this is less error prone and easier to write than this:
> 
> mediatek,pinfunc = <MT_PIN_FUNC(100, 1) MT_PIN_FUNC(101, 1)>

But you don't actually use the same macros in the driver, so in effect
you just move the definitions from the file they are needed in to another
file as a macro.

It is no less error prone to define those macros in mt8135-pinfunc.h
than in the pinctrl node, just less readable.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: "Joe. C" <srv_yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Hongzhou. Yang"
	<srv_hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>Hongzhou
	Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Ashwin Chaugule
	<ashwin.chaugule-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	dandan.he-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 4/4] ARM: dts: mt8135: Add pinctrl node for mt8135.
Date: Tue, 23 Sep 2014 16:10:09 +0200	[thread overview]
Message-ID: <7840459.vtELiqVIOL@wuerfel> (raw)
In-Reply-To: <1411480694.21299.18.camel@mtksdaap41>

On Tuesday 23 September 2014 21:58:14 Joe. C wrote:
> Thanks for review. 
> The intend for these macros is helpin pinctrl user to write DT node.
> With these macro, we could write like this for i2c0:
> 
> mediatek,pinfunc = <MT8135_PIN_100_SDA0__FUNC_SDA0 
>                         MT8135_PIN_101_SCL0__FUNC_SCL0>;
> 
> We feel this is less error prone and easier to write than this:
> 
> mediatek,pinfunc = <MT_PIN_FUNC(100, 1) MT_PIN_FUNC(101, 1)>

But you don't actually use the same macros in the driver, so in effect
you just move the definitions from the file they are needed in to another
file as a macro.

It is no less error prone to define those macros in mt8135-pinfunc.h
than in the pinctrl node, just less readable.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Joe. C" <srv_yingjoe.chen@mediatek.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Hongzhou. Yang" <srv_hongzhou.yang@mediatek.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	srv_heupstream@mediatek.com,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Hongzhou Yang <hongzhou.yang@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Kumar Gala <galak@codeaurora.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dandan.he@mediatek.com
Subject: Re: [PATCH v2 4/4] ARM: dts: mt8135: Add pinctrl node for mt8135.
Date: Tue, 23 Sep 2014 16:10:09 +0200	[thread overview]
Message-ID: <7840459.vtELiqVIOL@wuerfel> (raw)
In-Reply-To: <1411480694.21299.18.camel@mtksdaap41>

On Tuesday 23 September 2014 21:58:14 Joe. C wrote:
> Thanks for review. 
> The intend for these macros is helpin pinctrl user to write DT node.
> With these macro, we could write like this for i2c0:
> 
> mediatek,pinfunc = <MT8135_PIN_100_SDA0__FUNC_SDA0 
>                         MT8135_PIN_101_SCL0__FUNC_SCL0>;
> 
> We feel this is less error prone and easier to write than this:
> 
> mediatek,pinfunc = <MT_PIN_FUNC(100, 1) MT_PIN_FUNC(101, 1)>

But you don't actually use the same macros in the driver, so in effect
you just move the definitions from the file they are needed in to another
file as a macro.

It is no less error prone to define those macros in mt8135-pinfunc.h
than in the pinctrl node, just less readable.

	Arnd

  reply	other threads:[~2014-09-23 14:10 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  3:39 [PATCH v2 0/4] Add Mediatek SoC Pinctrl/GPIO driver for MT8135 Hongzhou.Yang
2014-09-23  3:39 ` Hongzhou.Yang
2014-09-23  3:39 ` [PATCH v2 1/4] arm: mediatek: Add config option for mediatek SoCs Hongzhou.Yang
2014-09-23  3:39   ` Hongzhou.Yang
2014-09-23  3:39 ` [PATCH v2 2/4] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135 Hongzhou.Yang
2014-09-23  3:39   ` Hongzhou.Yang
2014-10-02 13:38   ` Linus Walleij
2014-10-02 13:38     ` Linus Walleij
2014-10-06 10:35     ` Joe.C
2014-10-06 10:35       ` Joe.C
2014-10-21  9:08       ` Linus Walleij
2014-10-21  9:08         ` Linus Walleij
2014-10-21  9:08         ` Linus Walleij
2014-09-23  3:39 ` [PATCH v2 3/4] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx Hongzhou.Yang
2014-09-23  3:39   ` Hongzhou.Yang
2014-10-02 14:00   ` Linus Walleij
2014-10-02 14:00     ` Linus Walleij
2014-10-02 14:00     ` Linus Walleij
2014-10-02 14:41     ` Lucas Stach
2014-10-02 14:41       ` Lucas Stach
2014-10-02 14:41       ` Lucas Stach
2014-10-21  8:45       ` Linus Walleij
2014-10-21  8:45         ` Linus Walleij
2014-10-21  8:45         ` Linus Walleij
2014-09-23  3:39 ` [PATCH v2 4/4] ARM: dts: mt8135: Add pinctrl node for mt8135 Hongzhou.Yang
2014-09-23  3:39   ` Hongzhou.Yang
2014-09-23 13:03   ` Arnd Bergmann
2014-09-23 13:03     ` Arnd Bergmann
2014-09-23 13:03     ` Arnd Bergmann
2014-09-23 13:58     ` Joe.C
2014-09-23 13:58       ` Joe.C
2014-09-23 14:10       ` Arnd Bergmann [this message]
2014-09-23 14:10         ` Arnd Bergmann
2014-09-23 14:10         ` Arnd Bergmann
2014-09-23 14:29         ` Joe.C
2014-09-23 14:29           ` Joe.C
2014-09-23 14:55         ` Sascha Hauer
2014-09-23 14:55           ` Sascha Hauer
2014-09-23 14:55           ` Sascha Hauer
2014-09-23 14:16       ` Chen-Yu Tsai
2014-09-23 14:16         ` Chen-Yu Tsai
2014-09-23 14:16         ` Chen-Yu Tsai
2014-09-23 15:08         ` Joe.C
2014-09-23 15:08           ` Joe.C
2014-09-24 11:23   ` Linus Walleij
2014-09-24 11:23     ` Linus Walleij
2014-09-24 12:40     ` Sascha Hauer
2014-09-24 12:40       ` Sascha Hauer
2014-09-24 12:40       ` Sascha Hauer
2014-09-26  5:32       ` Sascha Hauer
2014-09-26  5:32         ` Sascha Hauer
2014-09-26  5:32         ` Sascha Hauer
2014-10-02 14:02       ` Linus Walleij
2014-10-02 14:02         ` Linus Walleij
2014-10-02 14:02         ` Linus Walleij
2014-10-02 14:28         ` Lucas Stach
2014-10-02 14:28           ` Lucas Stach
2014-10-02 14:28           ` Lucas Stach
2014-10-21  8:58           ` Linus Walleij
2014-10-21  8:58             ` Linus Walleij
2014-10-21  8:58             ` Linus Walleij
2014-10-06  7:18         ` Sascha Hauer
2014-10-06  7:18           ` Sascha Hauer
2014-10-06  7:18           ` Sascha Hauer
2014-10-21  9:02           ` Linus Walleij
2014-10-21  9:02             ` Linus Walleij
2014-10-21  9:02             ` Linus Walleij
2014-09-23 13:28 ` [PATCH v2 0/4] Add Mediatek SoC Pinctrl/GPIO driver for MT8135 Matthias Brugger
2014-09-23 13:28   ` Matthias Brugger
2014-09-23 13:28   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7840459.vtELiqVIOL@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.