From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Timur Tabi <timur@codeaurora.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: qcom: qdf2xxx: improve error checking and reporting
Date: Tue, 17 Nov 2015 15:15:31 +0100 [thread overview]
Message-ID: <7846916.TvyJAMuMZQ@wuerfel> (raw)
In-Reply-To: <CACRpkdb4Ck4XCUEKX7TEgCg8723vZA-sxqmd753O1q9uTBszfQ@mail.gmail.com>
On Tuesday 17 November 2015 14:33:49 Linus Walleij wrote:
> On Tue, Nov 10, 2015 at 4:57 PM, Timur Tabi <timur@codeaurora.org> wrote:
>
> > The driver doesn't report an error message if the ACPI tables are missing
> > the num-gpios property (which indicates how many GPIOs there are on this
> > SOC), and it didn't check to ensure that the mallocs didn't fail.
> >
> > Signed-off-by: Timur Tabi <timur@codeaurora.org>
>
> Waiting for Björn's ACK on this.
>
> And I suspect Arnd would be interested to know if you are doing
> ACPI on something that is certainly not a server-class hardware.
> Because you shouldn't.
>
It's more fun just watching this really. No comment.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: qcom: qdf2xxx: improve error checking and reporting
Date: Tue, 17 Nov 2015 15:15:31 +0100 [thread overview]
Message-ID: <7846916.TvyJAMuMZQ@wuerfel> (raw)
In-Reply-To: <CACRpkdb4Ck4XCUEKX7TEgCg8723vZA-sxqmd753O1q9uTBszfQ@mail.gmail.com>
On Tuesday 17 November 2015 14:33:49 Linus Walleij wrote:
> On Tue, Nov 10, 2015 at 4:57 PM, Timur Tabi <timur@codeaurora.org> wrote:
>
> > The driver doesn't report an error message if the ACPI tables are missing
> > the num-gpios property (which indicates how many GPIOs there are on this
> > SOC), and it didn't check to ensure that the mallocs didn't fail.
> >
> > Signed-off-by: Timur Tabi <timur@codeaurora.org>
>
> Waiting for Bj?rn's ACK on this.
>
> And I suspect Arnd would be interested to know if you are doing
> ACPI on something that is certainly not a server-class hardware.
> Because you shouldn't.
>
It's more fun just watching this really. No comment.
Arnd
next prev parent reply other threads:[~2015-11-17 14:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 15:57 [PATCH] pinctrl: qcom: qdf2xxx: improve error checking and reporting Timur Tabi
2015-11-10 15:57 ` Timur Tabi
2015-11-17 13:33 ` Linus Walleij
2015-11-17 13:33 ` Linus Walleij
2015-11-17 13:36 ` Timur Tabi
2015-11-17 13:36 ` Timur Tabi
2015-11-17 14:44 ` Linus Walleij
2015-11-17 14:44 ` Linus Walleij
2015-11-17 14:15 ` Arnd Bergmann [this message]
2015-11-17 14:15 ` Arnd Bergmann
2015-11-23 18:02 ` Bjorn Andersson
2015-11-23 18:02 ` Bjorn Andersson
2015-12-01 8:59 ` Linus Walleij
2015-12-01 8:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7846916.TvyJAMuMZQ@wuerfel \
--to=arnd@arndb.de \
--cc=bjorn.andersson@sonymobile.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.