Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_universal_plane: Flush pending cleanups
Date: Thu, 28 Jun 2018 13:06:35 +0200	[thread overview]
Message-ID: <7855dd66-00a8-ecf6-e8d6-180c32a32549@linux.intel.com> (raw)
In-Reply-To: <20180628105140.7125-1-chris@chris-wilson.co.uk>

Op 28-06-18 om 12:51 schreef Chris Wilson:
> drm_atomic_helper allows for up to one outstanding cleanup task to be in
> flight before a new modeset (see stall_commit in stall_checks()), In
> lieu of hooking up a debugfs to force flushing of the outstanding work,
> submit enough blocking modesets to ensure that the pending work is
> completed before continuing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_universal_plane.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> index 58f329e68..f875fd194 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -638,6 +638,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  	igt_plane_set_fb(primary, NULL);
>  	igt_plane_set_fb(cursor, NULL);
>  	igt_display_commit2(display, COMMIT_LEGACY);
> +	igt_display_commit2(display, COMMIT_LEGACY);
>  	cursor_leak_test_fini(data, output, &background_fb, cursor_fb);
>  
>  	/* We should be back to the same framebuffer count as when we started */

This won't work, we won't commit anything without anything changed, probably best to put the set_fb in the loop too.

Testcase: kms_universal_plane@cursor-fb-leak-*

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev