All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <stefano.stabellini@amd.com>,
	Michal Orzel <michal.orzel@amd.com>,
	xenia.ragiadakou@amd.com, Ayan Kumar Halder <ayankuma@amd.com>,
	consulting@bugseng.com, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>
Subject: Address MISRA C:2012 Rule 8.4
Date: Thu, 03 Aug 2023 11:20:24 +0200	[thread overview]
Message-ID: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> (raw)

The headline of Rule 8.4 is as follows:
"A compatible declaration shall be visible when an object or
function with external linkage is defined".

Some functions reported in [1][2] are lacking a declaration in the 
respective header files;
as remarked on xen-devel's IRC channel, this is ok since they are only 
called from asm code (e.g., start_xen). A similar discussion
had taken place in the past (see [3]) and the general consensus was to 
deviate these cases.
If that is still the case, a suitable project-wide deviation can be 
added to address these violations.

[1] 
https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html
[2] 
https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html
[3] 
https://lore.kernel.org/all/20220705210218.483854-2-burzalodowa@gmail.com/

Regards,

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)


             reply	other threads:[~2023-08-03  9:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  9:20 Nicola Vetrini [this message]
2023-08-04  0:35 ` Address MISRA C:2012 Rule 8.4 Stefano Stabellini
2023-08-04  9:47   ` Nicola Vetrini
2023-08-04 11:39     ` Jan Beulich
2023-08-04 14:09       ` Nicola Vetrini
2023-08-07  7:26         ` Jan Beulich
2023-08-04 20:40       ` Stefano Stabellini
2023-08-04 14:00     ` Nicola Vetrini
2023-08-07  7:34       ` Jan Beulich
2023-08-07 10:40         ` Nicola Vetrini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=786d24b044bfa503a73a36d2a01eae8c@bugseng.com \
    --to=nicola.vetrini@bugseng.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ayankuma@amd.com \
    --cc=consulting@bugseng.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=stefano.stabellini@amd.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xenia.ragiadakou@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.