From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <stefano.stabellini@amd.com>,
Michal Orzel <michal.orzel@amd.com>,
xenia.ragiadakou@amd.com, Ayan Kumar Halder <ayankuma@amd.com>,
consulting@bugseng.com, Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien@xen.org>,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: Address MISRA C:2012 Rule 8.4
Date: Mon, 07 Aug 2023 12:40:30 +0200 [thread overview]
Message-ID: <2c9becb505cc0ebc528ad02ab8ebbe6e@bugseng.com> (raw)
In-Reply-To: <ce365fcb-2a9c-dd41-6abb-e7ecee53d7ff@suse.com>
>> One further question is whether functions under
>> 'xen/common/coverage/gcov_base.c' should gain
>> a declaration in 'gcov.h' or not, as they exist just for the purpose
>> of
>> being referenced
>> by autogenerated profiling code. I see no reason why they shouldn't,
>> but
>> they can also be safely deviated,
>> since they are not called by Xen code.
>
> Imo it should be the compiler to provide a prototype for these (much
> like it does for builtins), thus ensuring that an implementation
> actually matches the compiler's expectations. Yet afaics it doesn't.
>
> Jan
Then it's perhaps best to deviate them.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
prev parent reply other threads:[~2023-08-07 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 9:20 Address MISRA C:2012 Rule 8.4 Nicola Vetrini
2023-08-04 0:35 ` Stefano Stabellini
2023-08-04 9:47 ` Nicola Vetrini
2023-08-04 11:39 ` Jan Beulich
2023-08-04 14:09 ` Nicola Vetrini
2023-08-07 7:26 ` Jan Beulich
2023-08-04 20:40 ` Stefano Stabellini
2023-08-04 14:00 ` Nicola Vetrini
2023-08-07 7:34 ` Jan Beulich
2023-08-07 10:40 ` Nicola Vetrini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c9becb505cc0ebc528ad02ab8ebbe6e@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayankuma@amd.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.