From: "Heiko Stübner" <heiko@sntech.de>
To: Artem Lapkin <email2tema@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, nick@khadas.com, jbx6244@gmail.com,
art@khadas.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes
Date: Wed, 23 Sep 2020 13:02:25 +0200 [thread overview]
Message-ID: <7887815.vmt15hixIf@diego> (raw)
In-Reply-To: <20200923101225.1513392-3-email2tema@gmail.com>
Hi Artem,
Am Mittwoch, 23. September 2020, 12:12:25 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
>
> add missed ir receivier to Khadas Edge board
> Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio
Missing Signed-off-by
> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index 42ebbd6fa46..389ae43d869 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 {
> vin-supply = <&vsys>;
> };
>
> + ir-receiver {
please sort alphabetically.
Also more importantly, is this really part of all Khadas Edge board variants?
[just making sure ;-) ]
> + compatible = "gpio-ir-receiver";
> + gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ir_rx>;
> + linux,rc-map-name = "rc-khadas";
> + };
> +
> adc-keys {
> compatible = "adc-keys";
> io-channels = <&saradc 1>;
> @@ -682,6 +690,14 @@ &sdmmc {
> status = "okay";
> };
>
> +&pinctrl {
there is already a "&pinctrl" node in the "rk3399-khadas-edge.dtsi"
please don't add another one, and make sure things are somewhat
sorted alphabetically ;-) .
Thanks
Heiko
> + ir {
> + ir_rx: ir-rx {
> + rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> +
> &sdhci {
> bus-width = <8>;
> mmc-hs400-1_8v;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Artem Lapkin <email2tema@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
art@khadas.com, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, nick@khadas.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes
Date: Wed, 23 Sep 2020 13:02:25 +0200 [thread overview]
Message-ID: <7887815.vmt15hixIf@diego> (raw)
In-Reply-To: <20200923101225.1513392-3-email2tema@gmail.com>
Hi Artem,
Am Mittwoch, 23. September 2020, 12:12:25 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
>
> add missed ir receivier to Khadas Edge board
> Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio
Missing Signed-off-by
> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index 42ebbd6fa46..389ae43d869 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 {
> vin-supply = <&vsys>;
> };
>
> + ir-receiver {
please sort alphabetically.
Also more importantly, is this really part of all Khadas Edge board variants?
[just making sure ;-) ]
> + compatible = "gpio-ir-receiver";
> + gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ir_rx>;
> + linux,rc-map-name = "rc-khadas";
> + };
> +
> adc-keys {
> compatible = "adc-keys";
> io-channels = <&saradc 1>;
> @@ -682,6 +690,14 @@ &sdmmc {
> status = "okay";
> };
>
> +&pinctrl {
there is already a "&pinctrl" node in the "rk3399-khadas-edge.dtsi"
please don't add another one, and make sure things are somewhat
sorted alphabetically ;-) .
Thanks
Heiko
> + ir {
> + ir_rx: ir-rx {
> + rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> +
> &sdhci {
> bus-width = <8>;
> mmc-hs400-1_8v;
>
next prev parent reply other threads:[~2020-09-23 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:12 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
2020-09-23 10:12 ` Artem Lapkin
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
2020-09-23 10:12 ` Artem Lapkin
2020-09-23 10:57 ` Heiko Stübner
2020-09-23 10:57 ` Heiko Stübner
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
2020-09-23 10:12 ` Artem Lapkin
2020-09-23 11:02 ` Heiko Stübner [this message]
2020-09-23 11:02 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2020-09-23 9:32 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
2020-09-23 9:32 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7887815.vmt15hixIf@diego \
--to=heiko@sntech.de \
--cc=art@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=email2tema@gmail.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.