From: Marc Zyngier <maz@kernel.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com,
guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com,
linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org,
paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com,
stefan.kristiansson@saunalahti.fi, tglx@linutronix.de,
torvalds@linux-foundation.org, tsbogend@alpha.franken.de,
vgupta@kernel.org, will@kernel.org
Subject: Re: [PATCH 09/15] irq: arm: perform irqentry in entry code
Date: Wed, 01 Dec 2021 07:56:29 +0000 [thread overview]
Message-ID: <78cc83d10cb6d251e53f5947ddc52735@kernel.org> (raw)
In-Reply-To: <59cb8da0-7dbd-6e70-56be-a40615fd694b@arm.com>
On 2021-11-30 08:49, Vladimir Murzin wrote:
> One month and a week later...
>
> I observe that in terms of performance
>
> MRS r0, ipsr
>
> is equivalent to readl_relaxed(BASEADDR_V7M_SCB + V7M_SCB_ICSR)
>
> MOV.W r3, #3758153728
> LDR.W r0, [r3, #3332]
>
> Old compilers can produce less performant sequence like
>
> LDR r3,0xbcc0
> ADD.W r3,r3,#0xaf00
> LDR r0,[r3,#0]
>
> So, what would be your preference?
If there is no significant overhead to reading the MMIO register
and that you see a benefit in enabling COMPILE_TEST, then this
probably is the way to go.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com,
guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com,
linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org,
paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com,
stefan.kristiansson@saunalahti.fi, tglx@linutronix.de,
torvalds@linux-foundation.org, tsbogend@alpha.franken.de,
vgupta@kernel.org, will@kernel.org
Subject: Re: [PATCH 09/15] irq: arm: perform irqentry in entry code
Date: Wed, 01 Dec 2021 07:56:29 +0000 [thread overview]
Message-ID: <78cc83d10cb6d251e53f5947ddc52735@kernel.org> (raw)
In-Reply-To: <59cb8da0-7dbd-6e70-56be-a40615fd694b@arm.com>
On 2021-11-30 08:49, Vladimir Murzin wrote:
> One month and a week later...
>
> I observe that in terms of performance
>
> MRS r0, ipsr
>
> is equivalent to readl_relaxed(BASEADDR_V7M_SCB + V7M_SCB_ICSR)
>
> MOV.W r3, #3758153728
> LDR.W r0, [r3, #3332]
>
> Old compilers can produce less performant sequence like
>
> LDR r3,0xbcc0
> ADD.W r3,r3,#0xaf00
> LDR r0,[r3,#0]
>
> So, what would be your preference?
If there is no significant overhead to reading the MMIO register
and that you see a benefit in enabling COMPILE_TEST, then this
probably is the way to go.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2021-12-01 7:58 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 18:02 [PATCH 00/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 01/15] irq: mips: avoid nested irq_enter() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 10:38 ` Marc Zyngier
2021-10-22 10:38 ` Marc Zyngier
2021-10-22 15:05 ` Mark Rutland
2021-10-22 15:05 ` Mark Rutland
2021-10-24 15:31 ` Thomas Bogendoerfer
2021-10-24 15:31 ` Thomas Bogendoerfer
2021-10-21 18:02 ` [PATCH 02/15] irq: mips: stop (ab)using handle_domain_irq() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-24 15:30 ` Thomas Bogendoerfer
2021-10-24 15:30 ` Thomas Bogendoerfer
2021-10-21 18:02 ` [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-24 15:31 ` Thomas Bogendoerfer
2021-10-24 15:31 ` Thomas Bogendoerfer
2021-10-28 17:07 ` Guenter Roeck
2021-10-28 17:07 ` Guenter Roeck
2021-10-28 17:11 ` Mark Rutland
2021-10-28 17:11 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 04/15] irq: simplify handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 10:52 ` Marc Zyngier
2021-10-22 10:52 ` Marc Zyngier
2021-10-22 15:05 ` Mark Rutland
2021-10-22 15:05 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 05/15] irq: add generic_handle_arch_irq() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 2:10 ` Pingfan Liu
2021-10-22 2:10 ` Pingfan Liu
2021-10-22 9:02 ` Mark Rutland
2021-10-22 9:02 ` Mark Rutland
2021-10-22 2:33 ` Guo Ren
2021-10-22 2:33 ` Guo Ren
2021-10-22 8:52 ` Mark Rutland
2021-10-22 8:52 ` Mark Rutland
2021-10-24 1:53 ` Guo Ren
2021-10-24 1:53 ` Guo Ren
2021-10-21 18:02 ` [PATCH 06/15] irq: arc: avoid CONFIG_HANDLE_DOMAIN_IRQ Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 07/15] irq: nds32: " Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 6:35 ` Greentime Hu
2021-10-22 6:35 ` Greentime Hu
2021-10-21 18:02 ` [PATCH 08/15] irq: add a (temporary) CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 09/15] irq: arm: perform irqentry in entry code Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 15:18 ` Vladimir Murzin
2021-10-22 15:18 ` Vladimir Murzin
2021-10-22 15:36 ` Mark Rutland
2021-10-22 15:36 ` Mark Rutland
2021-10-22 16:34 ` Vladimir Murzin
2021-10-22 16:34 ` Vladimir Murzin
2021-10-22 17:58 ` Mark Rutland
2021-10-22 17:58 ` Mark Rutland
2021-10-22 18:43 ` Marc Zyngier
2021-10-22 18:43 ` Marc Zyngier
2021-10-23 12:06 ` Vladimir Murzin
2021-10-23 12:06 ` Vladimir Murzin
2021-10-23 13:18 ` Marc Zyngier
2021-10-23 13:18 ` Marc Zyngier
2021-10-23 13:36 ` Vladimir Murzin
2021-10-23 13:36 ` Vladimir Murzin
2021-11-30 8:49 ` Vladimir Murzin
2021-11-30 8:49 ` Vladimir Murzin
2021-12-01 7:56 ` Marc Zyngier [this message]
2021-12-01 7:56 ` Marc Zyngier
2021-10-21 18:02 ` [PATCH 10/15] irq: arm64: " Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 1:57 ` Pingfan Liu
2021-10-22 1:57 ` Pingfan Liu
2021-10-25 18:00 ` Catalin Marinas
2021-10-25 18:00 ` Catalin Marinas
2021-10-21 18:02 ` [PATCH 11/15] irq: csky: " Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 2:19 ` Guo Ren
2021-10-22 2:19 ` Guo Ren
2021-10-22 2:26 ` Guo Ren
2021-10-22 2:26 ` Guo Ren
2021-10-21 18:02 ` [PATCH 12/15] irq: openrisc: " Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 20:40 ` Stafford Horne
2021-10-22 20:40 ` Stafford Horne
2021-10-21 18:02 ` [PATCH 13/15] irq: riscv: " Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 1:59 ` Guo Ren
2021-10-22 1:59 ` Guo Ren
2021-10-27 21:22 ` Palmer Dabbelt
2021-10-27 21:22 ` Palmer Dabbelt
2021-10-21 18:02 ` [PATCH 14/15] irq: remove CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 15/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-22 10:05 ` Marc Zyngier
2021-10-22 10:05 ` Marc Zyngier
2021-10-22 15:06 ` Mark Rutland
2021-10-22 15:06 ` Mark Rutland
2021-10-22 1:26 ` [PATCH 00/15] " Linus Torvalds
2021-10-22 1:26 ` Linus Torvalds
2021-10-22 11:20 ` Marc Zyngier
2021-10-22 11:20 ` Marc Zyngier
2021-10-22 15:10 ` Mark Rutland
2021-10-22 15:10 ` Mark Rutland
2021-10-23 16:06 ` Marc Zyngier
2021-10-23 16:06 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78cc83d10cb6d251e53f5947ddc52735@kernel.org \
--to=maz@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=jonas@southpole.se \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nickhu@andestech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.