All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dragan Simic <dsimic@manjaro.org>,
	Jonas Karlman <jonas@kwiboo.se>, Coia Prant <coiaprant@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Coia Prant <coiaprant@gmail.com>
Subject: Re: [PATCH v5 3/3] arm64: dts: rockchip: Add devicetree for the 9Tripod X3568 v4
Date: Thu, 06 Nov 2025 23:51:40 +0100	[thread overview]
Message-ID: <7930630.EvYhyI6sBW@phil> (raw)
In-Reply-To: <20251103171702.1518730-4-coiaprant@gmail.com>

Hi,

Am Montag, 3. November 2025, 18:17:02 Mitteleuropäische Normalzeit schrieb Coia Prant:
> The 9Tripod X3568 v4 is an RK3568-based SBC, just like the RK3568-EVB.
> It always uses soldered connections between the X3568CV2/X3568CV3/X3568CV4 core board
> and the X3568bv4 I/O board.
> 
> The differences between the core boards
> - PCB size, layout
> - CPU (RKK3568B2/RK3568J)
> - Memory type (DDR4/LPDDR4/LPDDR4X) and size
> - eMMC size
> - DSI/EDP resistor values
> Although the components vary, they maintain full compatibility.
> 
> The X3568 board has multiple hardware revisions, and we currently support v4 (I/O board).

[...]

> Signed-off-by: Coia Prant <coiaprant@gmail.com>

I've dropped the camera overlay for the time being, when applying the
board, because there were a number of smallish issues with it.

So please submit it separately again. Also, how can you use the camera
yet, when the whole vicap work is still pending?

Details below

> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  11 +
>  .../rk3568-9tripod-x3568-v4-camera-demo.dtso  |  84 ++
>  .../rk3568-9tripod-x3568-v4-video-demo.dtso   | 154 +++
>  .../dts/rockchip/rk3568-9tripod-x3568-v4.dts  | 887 ++++++++++++++++++
>  4 files changed, 1136 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-video-demo.dtso
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index ad684e383..959a806a2 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -130,6 +130,9 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-cb2-manta.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-pi2.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-camera-demo.dtbo
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-video-demo.dtbo
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
> @@ -252,6 +255,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5-v1.2-wifibt.dtb
>  rk3576-armsom-sige5-v1.2-wifibt-dtbs := rk3576-armsom-sige5.dtb \
>  	rk3576-armsom-sige5-v1.2-wifibt.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-camera-demo.dtb
> +rk3568-9tripod-x3568-v4-camera-demo-dtbs := rk3568-9tripod-x3568-v4.dtb \
> +	rk3568-9tripod-x3568-v4-camera-demo.dtbo
> +
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-video-demo.dtb
> +rk3568-9tripod-x3568-v4-video-demo-dtbs := rk3568-9tripod-x3568-v4.dtb \
> +	rk3568-9tripod-x3568-v4-video-demo.dtbo
> +

when adding overlays, please sort them correctly,
rk3568-9tripod* should be above rk3568-wolfvision*


>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
>  rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
>  	rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
> new file mode 100644
> index 000000000..2b428ca71
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
> @@ -0,0 +1,84 @@

[...]

> +&csi_dphy {
> +	status = "okay";
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {

../arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso:41.8-56.4: Warning (graph_child_address): /fragment@2/__overlay__/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary


> +			reg = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			mipi_in_ucam: endpoint@2 {
> +				reg = <2>;
> +				remote-endpoint = <&ucam_out>;
> +				data-lanes = <1 2 3 4>;
> +			};
> +		};
> +	};

/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: phy@fe870000 (rockchip,rk3568-csi-dphy): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
        from schema $id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml#

not sure what is up with that.

> +};
> +
> +&i2c4 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	camera@37 {
> +		compatible = "ovti,ov5695";
> +		reg = <0x37>;
> +		clocks = <&cru CLK_CIF_OUT>;
> +		clock-names = "xvclk";
> +		avdd-supply = <&vcc_cam>;
> +		dvdd-supply = <&vcc_cam>;
> +		dovdd-supply = <&vcc_cam>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cif_clk>;
> +		reset-gpios = <&gpio3 RK_PB6 GPIO_ACTIVE_LOW>;
> +		pwdn-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			ucam_out: endpoint {
> +				remote-endpoint = <&mipi_in_ucam>;
> +				data-lanes = <1 2 3 4>;
> +			};
> +		};

/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: camera@37 (ovti,ov5695): port:endpoint:data-lanes: [1, 2, 3, 4] is too long
        from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml#
/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: camera@37 (ovti,ov5695): Unevaluated properties are not allowed ('port', 'pwdn-gpios' were unexpected)
        from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml#


> +	};
> +};



Heiko




WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dragan Simic <dsimic@manjaro.org>,
	Jonas Karlman <jonas@kwiboo.se>, Coia Prant <coiaprant@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Coia Prant <coiaprant@gmail.com>
Subject: Re: [PATCH v5 3/3] arm64: dts: rockchip: Add devicetree for the 9Tripod X3568 v4
Date: Thu, 06 Nov 2025 23:51:40 +0100	[thread overview]
Message-ID: <7930630.EvYhyI6sBW@phil> (raw)
In-Reply-To: <20251103171702.1518730-4-coiaprant@gmail.com>

Hi,

Am Montag, 3. November 2025, 18:17:02 Mitteleuropäische Normalzeit schrieb Coia Prant:
> The 9Tripod X3568 v4 is an RK3568-based SBC, just like the RK3568-EVB.
> It always uses soldered connections between the X3568CV2/X3568CV3/X3568CV4 core board
> and the X3568bv4 I/O board.
> 
> The differences between the core boards
> - PCB size, layout
> - CPU (RKK3568B2/RK3568J)
> - Memory type (DDR4/LPDDR4/LPDDR4X) and size
> - eMMC size
> - DSI/EDP resistor values
> Although the components vary, they maintain full compatibility.
> 
> The X3568 board has multiple hardware revisions, and we currently support v4 (I/O board).

[...]

> Signed-off-by: Coia Prant <coiaprant@gmail.com>

I've dropped the camera overlay for the time being, when applying the
board, because there were a number of smallish issues with it.

So please submit it separately again. Also, how can you use the camera
yet, when the whole vicap work is still pending?

Details below

> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  11 +
>  .../rk3568-9tripod-x3568-v4-camera-demo.dtso  |  84 ++
>  .../rk3568-9tripod-x3568-v4-video-demo.dtso   | 154 +++
>  .../dts/rockchip/rk3568-9tripod-x3568-v4.dts  | 887 ++++++++++++++++++
>  4 files changed, 1136 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-video-demo.dtso
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index ad684e383..959a806a2 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -130,6 +130,9 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-cb2-manta.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-pi2.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-camera-demo.dtbo
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-video-demo.dtbo
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
> @@ -252,6 +255,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5-v1.2-wifibt.dtb
>  rk3576-armsom-sige5-v1.2-wifibt-dtbs := rk3576-armsom-sige5.dtb \
>  	rk3576-armsom-sige5-v1.2-wifibt.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-camera-demo.dtb
> +rk3568-9tripod-x3568-v4-camera-demo-dtbs := rk3568-9tripod-x3568-v4.dtb \
> +	rk3568-9tripod-x3568-v4-camera-demo.dtbo
> +
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-9tripod-x3568-v4-video-demo.dtb
> +rk3568-9tripod-x3568-v4-video-demo-dtbs := rk3568-9tripod-x3568-v4.dtb \
> +	rk3568-9tripod-x3568-v4-video-demo.dtbo
> +

when adding overlays, please sort them correctly,
rk3568-9tripod* should be above rk3568-wolfvision*


>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
>  rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
>  	rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
> new file mode 100644
> index 000000000..2b428ca71
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
> @@ -0,0 +1,84 @@

[...]

> +&csi_dphy {
> +	status = "okay";
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {

../arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso:41.8-56.4: Warning (graph_child_address): /fragment@2/__overlay__/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary


> +			reg = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			mipi_in_ucam: endpoint@2 {
> +				reg = <2>;
> +				remote-endpoint = <&ucam_out>;
> +				data-lanes = <1 2 3 4>;
> +			};
> +		};
> +	};

/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: phy@fe870000 (rockchip,rk3568-csi-dphy): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
        from schema $id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml#

not sure what is up with that.

> +};
> +
> +&i2c4 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	camera@37 {
> +		compatible = "ovti,ov5695";
> +		reg = <0x37>;
> +		clocks = <&cru CLK_CIF_OUT>;
> +		clock-names = "xvclk";
> +		avdd-supply = <&vcc_cam>;
> +		dvdd-supply = <&vcc_cam>;
> +		dovdd-supply = <&vcc_cam>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cif_clk>;
> +		reset-gpios = <&gpio3 RK_PB6 GPIO_ACTIVE_LOW>;
> +		pwdn-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_LOW>;
> +
> +		port {
> +			ucam_out: endpoint {
> +				remote-endpoint = <&mipi_in_ucam>;
> +				data-lanes = <1 2 3 4>;
> +			};
> +		};

/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: camera@37 (ovti,ov5695): port:endpoint:data-lanes: [1, 2, 3, 4] is too long
        from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml#
/home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtb: camera@37 (ovti,ov5695): Unevaluated properties are not allowed ('port', 'pwdn-gpios' were unexpected)
        from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml#


> +	};
> +};



Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-11-06 22:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 17:16 [PATCH v5 0/3] Add devicetree for the 9Tripod X3568 v4 Coia Prant
2025-11-03 17:16 ` Coia Prant
2025-11-03 17:17 ` [PATCH v5 1/3] dt-bindings: vendor-prefixes: Add 9Tripod Coia Prant
2025-11-03 17:17   ` Coia Prant
2025-11-04  8:00   ` Krzysztof Kozlowski
2025-11-04  8:00     ` Krzysztof Kozlowski
2025-11-03 17:17 ` [PATCH v5 2/3] dt-bindings: arm: rockchip: Add 9Tripod X3568 series Coia Prant
2025-11-03 17:17   ` Coia Prant
2025-11-04  8:01   ` Krzysztof Kozlowski
2025-11-04  8:01     ` Krzysztof Kozlowski
2025-11-03 17:17 ` [PATCH v5 3/3] arm64: dts: rockchip: Add devicetree for the 9Tripod X3568 v4 Coia Prant
2025-11-03 17:17   ` Coia Prant
2025-11-06 22:51   ` Heiko Stuebner [this message]
2025-11-06 22:51     ` Heiko Stuebner
2025-11-06 22:54   ` Heiko Stuebner
2025-11-06 22:54     ` Heiko Stuebner
2025-11-07  5:45     ` Coia Prant
2025-11-07  5:45       ` Coia Prant
2025-11-07 11:00   ` Chukun Pan
2025-11-07 11:00     ` Chukun Pan
2025-11-07 11:36     ` Coia Prant
2025-11-07 11:36       ` Coia Prant
2025-11-13 13:00       ` Chukun Pan
2025-11-13 13:00         ` Chukun Pan
2025-11-06 22:58 ` [PATCH v5 0/3] " Heiko Stuebner
2025-11-06 22:58   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7930630.EvYhyI6sBW@phil \
    --to=heiko@sntech.de \
    --cc=coiaprant@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.