From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Avoid access time trashing in gfs2_inode_lookup
Date: Wed, 15 Jan 2020 08:43:22 -0500 (EST) [thread overview]
Message-ID: <793501366.2644404.1579095802763.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200115083040.32714-1-agruenba@redhat.com>
----- Original Message -----
> In gfs2_inode_lookup, we initialize inode->i_atime to the lowest
> possibly value after gfs2_inode_refresh may already have been called.
> This should be the other way around, but we didn't notice because
> usually the inode type is known from the directory entry and so
> gfs2_inode_lookup won't call gfs2_inode_refresh.
>
> In addition, only initialize ip->i_no_formal_ino from no_formal_ino when
> actually needed.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
Hi,
The patch looks good, but can we please change the description from:
"trashing"
to:
"thrashing"?
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
Thanks.
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2020-01-15 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 8:30 [Cluster-devel] [PATCH] gfs2: Avoid access time trashing in gfs2_inode_lookup Andreas Gruenbacher
2020-01-15 13:43 ` Bob Peterson [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-15 8:27 Andreas Gruenbacher
2020-01-15 8:37 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793501366.2644404.1579095802763.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.