All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Jimi Xenidis <jimix@pobox.com>
Cc: grant.likely@secretlab.ca, linux-next@vger.kernel.org,
	linuxppc-dev@ozlabs.org, benh@kernel.crashing.org
Subject: Re: [PATCH] powerpc/of: add OF_DYNAMIC for chroma
Date: Tue, 21 Feb 2012 10:16:10 +1100	[thread overview]
Message-ID: <7970.1329779770@neuling.org> (raw)
In-Reply-To: <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com>

Grant, 

This seems to be broken in your tree (since 301b605ff6), so you should
probably pick up this patch.

Mikey


In message <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com> you wrote:
> 
> On Feb 19, 2012, at 4:48 PM, Michael Neuling wrote:
> 
> > linux next-20120217 compiling ppc64e_defconfig fails with:
> >=20
> > arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
> > arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of =
> function 'of_detach_node'
> >=20
> > The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> Acked-by: Jimi Xenidis <jimix@pobox.com>
> 
> >=20
> > diff --git a/arch/powerpc/platforms/wsp/Kconfig =
> b/arch/powerpc/platforms/wsp/Kconfig
> > index 57d22a2..79d2225 100644
> > --- a/arch/powerpc/platforms/wsp/Kconfig
> > +++ b/arch/powerpc/platforms/wsp/Kconfig
> > @@ -25,6 +25,7 @@ config PPC_CHROMA
> > 	bool "PowerEN PCIe Chroma Card"
> > 	select EPAPR_BOOT
> > 	select PPC_WSP
> > +	select OF_DYNAMIC
> > 	default y
> >=20
> > endmenu
> 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Jimi Xenidis <jimix@pobox.com>
Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] powerpc/of: add OF_DYNAMIC for chroma
Date: Tue, 21 Feb 2012 10:16:10 +1100	[thread overview]
Message-ID: <7970.1329779770@neuling.org> (raw)
In-Reply-To: <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com>

Grant, 

This seems to be broken in your tree (since 301b605ff6), so you should
probably pick up this patch.

Mikey


In message <5A594805-C5CE-46E7-A15F-DF86E6FE6C42@pobox.com> you wrote:
> 
> On Feb 19, 2012, at 4:48 PM, Michael Neuling wrote:
> 
> > linux next-20120217 compiling ppc64e_defconfig fails with:
> >=20
> > arch/powerpc/platforms/wsp/h8.c: In function 'wsp_h8_getaddr':
> > arch/powerpc/platforms/wsp/h8.c:116: error: implicit declaration of =
> function 'of_detach_node'
> >=20
> > The below fixes this by selecting the new OF_DYNAMIC when PPC_CHROMA.
> >=20
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> Acked-by: Jimi Xenidis <jimix@pobox.com>
> 
> >=20
> > diff --git a/arch/powerpc/platforms/wsp/Kconfig =
> b/arch/powerpc/platforms/wsp/Kconfig
> > index 57d22a2..79d2225 100644
> > --- a/arch/powerpc/platforms/wsp/Kconfig
> > +++ b/arch/powerpc/platforms/wsp/Kconfig
> > @@ -25,6 +25,7 @@ config PPC_CHROMA
> > 	bool "PowerEN PCIe Chroma Card"
> > 	select EPAPR_BOOT
> > 	select PPC_WSP
> > +	select OF_DYNAMIC
> > 	default y
> >=20
> > endmenu
> 

  reply	other threads:[~2012-02-20 23:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-19 22:48 [PATCH] powerpc/of: add OF_DYNAMIC for chroma Michael Neuling
2012-02-19 22:48 ` Michael Neuling
2012-02-20 14:12 ` Jimi Xenidis
2012-02-20 14:12   ` Jimi Xenidis
2012-02-20 23:16   ` Michael Neuling [this message]
2012-02-20 23:16     ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7970.1329779770@neuling.org \
    --to=mikey@neuling.org \
    --cc=benh@kernel.crashing.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jimix@pobox.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.