[PATCH] ARM: dts: lager: Move cec_clock to root node

[PATCH] ARM: dts: lager: Move cec_clock to root node

[Geert Uytterhoeven]

cec-clock is a fixed clock generator that is not controlled by i2c-12
and thus should not be a child of the i2c-12 bus node. Rather, it should
be a child of the root node of the DT.

Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI transmitter")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7790-lager.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index b42579ea7a50d47c..3c66366f7c550034 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -247,6 +247,12 @@
 		};
 	};
 
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";
@@ -352,12 +358,6 @@
 			};
 		};
 
-		cec_clock: cec-clock {
-			compatible = "fixed-clock";
-			#clock-cells = <0>;
-			clock-frequency = <12000000>;
-		};
-
 		hdmi@39 {
 			compatible = "adi,adv7511w";
 			reg = <0x39>;
-- 
2.7.4

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Tuesday, 13 February 2018 15:40:45 EET Geert Uytterhoeven wrote:
> cec-clock is a fixed clock generator that is not controlled by i2c-12
> and thus should not be a child of the i2c-12 bus node. Rather, it should
> be a child of the root node of the DT.
> 
> Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI
> transmitter")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7790-lager.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index
> b42579ea7a50d47c..3c66366f7c550034 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -247,6 +247,12 @@
>  		};
>  	};
> 
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};
> +
>  	hdmi-out {
>  		compatible = "hdmi-connector";
>  		type = "a";
> @@ -352,12 +358,6 @@
>  			};
>  		};
> 
> -		cec_clock: cec-clock {
> -			compatible = "fixed-clock";
> -			#clock-cells = <0>;
> -			clock-frequency = <12000000>;
> -		};
> -
>  		hdmi@39 {
>  			compatible = "adi,adv7511w";
>  			reg = <0x39>;

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

[Simon Horman]

On Tue, Feb 13, 2018 at 03:54:56PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> Thank you for the patch.
> 
> On Tuesday, 13 February 2018 15:40:45 EET Geert Uytterhoeven wrote:
> > cec-clock is a fixed clock generator that is not controlled by i2c-12
> > and thus should not be a child of the i2c-12 bus node. Rather, it should
> > be a child of the root node of the DT.
> > 
> > Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI
> > transmitter")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

On Tue, Feb 13, 2018 at 03:04:31PM +0100, Niklas Söderlund wrote:
> Hi Geert,
> 
> Thanks for your patch.
> 
> On 2018-02-13 14:40:45 +0100, Geert Uytterhoeven wrote:
> > cec-clock is a fixed clock generator that is not controlled by i2c-12
> > and thus should not be a child of the i2c-12 bus node. Rather, it should
> > be a child of the root node of the DT.
> > 
> > Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI transmitter")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks, applied.

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

[Niklas Söderlund]

Hi Geert,

Thanks for your patch.

On 2018-02-13 14:40:45 +0100, Geert Uytterhoeven wrote:
> cec-clock is a fixed clock generator that is not controlled by i2c-12
> and thus should not be a child of the i2c-12 bus node. Rather, it should
> be a child of the root node of the DT.
> 
> Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI transmitter")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  arch/arm/boot/dts/r8a7790-lager.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index b42579ea7a50d47c..3c66366f7c550034 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -247,6 +247,12 @@
>  		};
>  	};
>  
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};
> +
>  	hdmi-out {
>  		compatible = "hdmi-connector";
>  		type = "a";
> @@ -352,12 +358,6 @@
>  			};
>  		};
>  
> -		cec_clock: cec-clock {
> -			compatible = "fixed-clock";
> -			#clock-cells = <0>;
> -			clock-frequency = <12000000>;
> -		};
> -
>  		hdmi@39 {
>  			compatible = "adi,adv7511w";
>  			reg = <0x39>;
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas S�derlund