From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>,
Yihang Li <liyihang9@huawei.com>,
yanaijie@huawei.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, chenxiang66@hisilicon.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, prime.zeng@huawei.com,
yangxingui@huawei.com
Subject: Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA_MINALIGN
Date: Tue, 26 Mar 2024 22:40:35 +0900 [thread overview]
Message-ID: <79bca118-5027-4153-9fea-bda4c5ad6edb@kernel.org> (raw)
In-Reply-To: <0ba9914d-7060-498a-beac-2b19770e1963@oracle.com>
On 3/26/24 22:32, John Garry wrote:
>> John,
>>
>> Unrelated to this patch, but I wonder if the GFP_KERNEL used here shouldn't be
>> GFP_NOIO... Is this ever called in the IO path or error recovery ?
>>
>
> These should not be called in the IO path - as they are management
> functions. But I am quite confident that they can be called in SCSI
> error handling (for libsas).
So it sounds like GFP_NOIO would be a lot safer...
>
> Thanks,
> John
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-03-26 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 12:43 [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA_MINALIGN Yihang Li
2024-03-26 13:14 ` Damien Le Moal
2024-03-26 13:32 ` John Garry
2024-03-26 13:40 ` Damien Le Moal [this message]
2024-03-28 6:35 ` Christoph Hellwig
2024-03-28 6:59 ` Yihang Li
2024-03-28 7:23 ` Damien Le Moal
2024-03-28 7:29 ` Christoph Hellwig
2024-03-28 7:36 ` Damien Le Moal
2024-03-28 7:45 ` Christoph Hellwig
2024-03-28 8:00 ` Yihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79bca118-5027-4153-9fea-bda4c5ad6edb@kernel.org \
--to=dlemoal@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@huawei.com \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.