* [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
@ 2023-08-04 9:01 Yang Yingliang
2023-08-08 1:21 ` Ping-Ke Shih
2023-08-21 16:13 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2023-08-04 9:01 UTC (permalink / raw)
To: linux-wireless; +Cc: pkshih, kvalo, yangyingliang
Use eth_broadcast_addr() to assign broadcast address instead
of memcpy().
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index 4fb16f5f6f83..3835b639d453 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -1656,7 +1656,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
memcpy(rtlpriv->sec.key_buf[key_idx],
key->key, key->keylen);
rtlpriv->sec.key_len[key_idx] = key->keylen;
- memcpy(mac_addr, bcast_addr, ETH_ALEN);
+ eth_broadcast_addr(mac_addr);
} else { /* pairwise key */
rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
"set pairwise key\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
2023-08-04 9:01 [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address Yang Yingliang
@ 2023-08-08 1:21 ` Ping-Ke Shih
2023-08-21 16:13 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2023-08-08 1:21 UTC (permalink / raw)
To: Yang Yingliang, linux-wireless@vger.kernel.org; +Cc: kvalo@kernel.org
> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: Friday, August 4, 2023 5:01 PM
> To: linux-wireless@vger.kernel.org
> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; yangyingliang@huawei.com
> Subject: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
>
> Use eth_broadcast_addr() to assign broadcast address instead
> of memcpy().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index 4fb16f5f6f83..3835b639d453 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1656,7 +1656,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> memcpy(rtlpriv->sec.key_buf[key_idx],
> key->key, key->keylen);
> rtlpriv->sec.key_len[key_idx] = key->keylen;
> - memcpy(mac_addr, bcast_addr, ETH_ALEN);
> + eth_broadcast_addr(mac_addr);
> } else { /* pairwise key */
> rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
> "set pairwise key\n");
> --
> 2.25.1
>
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
2023-08-04 9:01 [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address Yang Yingliang
2023-08-08 1:21 ` Ping-Ke Shih
@ 2023-08-21 16:13 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-08-21 16:13 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-wireless, pkshih, yangyingliang
Yang Yingliang <yangyingliang@huawei.com> wrote:
> Use eth_broadcast_addr() to assign broadcast address instead
> of memcpy().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
66311106b20b wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230804090120.1332091-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-21 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 9:01 [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address Yang Yingliang
2023-08-08 1:21 ` Ping-Ke Shih
2023-08-21 16:13 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.