Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@nabladev.com>, linux-usb@vger.kernel.org
Cc: fabrice.gasnier@foss.st.com, "Pankaj Dev" <pankaj.dev@st.com>,
	"Rahul Kumar" <rahul.kumar05@st.com>,
	"Clément Le Goffic" <clement.legoffic@foss.st.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Christian Bruel" <christian.bruel@foss.st.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Rob Herring" <robh@kernel.org>, "Rosen Penev" <rosenp@gmail.com>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	devicetree@vger.kernel.org, kernel@dh-electronics.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY
Date: Thu, 27 Aug 2026 14:54:01 +0200	[thread overview]
Message-ID: <7a16614a-bd1b-462a-be13-4a9c22aa588e@kernel.org> (raw)
In-Reply-To: <20260822074816.548662-2-marex@nabladev.com>

On 22/08/2026 09:46, Marek Vasut wrote:
> +description:
> +  USB2 PHY block in STM32 is attached to USB 2.0 Host controller and
> +  USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS
> +  connectivity. Both PHYs are the FEMTO-PHY, but their configuration
> +  bits in the system control register are different for each variant.
> +
> +maintainers:
> +  - Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> +  - Marek Vasut <marex@nabladev.com>
> +  - Pankaj Dev <pankaj.dev@st.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stm32mp25-usb2phy1
> +      - st,stm32mp25-usb2phy2
> +
> +  "#clock-cells":
> +    const: 1
> +

As pointed out by different patchset built on top of it, this is wrong.

I do not understand why Fabrice Gasnier cannot reply HERE that this is
wrong and instead another patch is sent for in-flight code. That's not
your Marek problem, but lack of responsible review from ST...

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy