All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com,
	Jonathan.Cameron@Huawei.com, etienne.carriere@linaro.org,
	vincent.guittot@linaro.org, souvik.chakravarty@arm.com
Subject: Re: [PATCH v4 11/12] [RFC] firmware: arm_scmi: Add sync_cmds_atomic_replies transport flag
Date: Wed, 25 Aug 2021 18:38:19 +0200	[thread overview]
Message-ID: <7a2f972d-fdd0-d0f7-cac2-1989980ed872@gmail.com> (raw)
In-Reply-To: <20210824135941.38656-12-cristian.marussi@arm.com>



On 8/24/2021 3:59 PM, Cristian Marussi wrote:
> A flag is added to let the transport signal the core that its handling of
> synchronous command messages implies that, after .send_message has returned
> successfully, the requested command can be assumed to be fully and
> completely executed on SCMI platform side so that any possible response
> value is already immediately available to be retrieved by a .fetch_reponse:
> in other words the polling phase can be skipped in such a case and the
> response values accessed straight away.
> 
> Note that all of the above applies only when polling mode of operation was
> selected by the core: if instead a completion IRQ was found to be available
> the normal response processing path based on completions will still be
> followed.

This might actually have to be settable on a per-message basis ideally 
since we may be transporting short lived SCMI messages for which the 
completion can be done at SMC time, and long lived SCMI messages (e.g.: 
involving a voltage change) for which we would prefer a completion 
interrupt. Jim, what do you think?
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com,
	Jonathan.Cameron@Huawei.com, etienne.carriere@linaro.org,
	vincent.guittot@linaro.org, souvik.chakravarty@arm.com
Subject: Re: [PATCH v4 11/12] [RFC] firmware: arm_scmi: Add sync_cmds_atomic_replies transport flag
Date: Wed, 25 Aug 2021 18:38:19 +0200	[thread overview]
Message-ID: <7a2f972d-fdd0-d0f7-cac2-1989980ed872@gmail.com> (raw)
In-Reply-To: <20210824135941.38656-12-cristian.marussi@arm.com>



On 8/24/2021 3:59 PM, Cristian Marussi wrote:
> A flag is added to let the transport signal the core that its handling of
> synchronous command messages implies that, after .send_message has returned
> successfully, the requested command can be assumed to be fully and
> completely executed on SCMI platform side so that any possible response
> value is already immediately available to be retrieved by a .fetch_reponse:
> in other words the polling phase can be skipped in such a case and the
> response values accessed straight away.
> 
> Note that all of the above applies only when polling mode of operation was
> selected by the core: if instead a completion IRQ was found to be available
> the normal response processing path based on completions will still be
> followed.

This might actually have to be settable on a per-message basis ideally 
since we may be transporting short lived SCMI messages for which the 
completion can be done at SMC time, and long lived SCMI messages (e.g.: 
involving a voltage change) for which we would prefer a completion 
interrupt. Jim, what do you think?
-- 
Florian

  reply	other threads:[~2021-08-25 17:00 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 13:59 [PATCH v4 0/12] Introduce atomic support for SCMI transports Cristian Marussi
2021-08-24 13:59 ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 01/12] firmware: arm_scmi: Perform earlier cinfo lookup call in do_xfer Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:28   ` Florian Fainelli
2021-08-25 16:28     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 02/12] firmware: arm_scmi: Add configurable polling mode for transports Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:29   ` Florian Fainelli
2021-08-25 16:29     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 03/12] firmware: arm_scmi: Add support for atomic transports Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:18   ` Jim Quinlan
2021-08-25 16:18     ` Jim Quinlan
2021-08-25 17:50     ` Cristian Marussi
2021-08-25 17:50       ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 04/12] include: trace: Add new scmi_xfer_response_wait event Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:30   ` Florian Fainelli
2021-08-25 16:30     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 05/12] firmware: arm_scmi: Use new trace event scmi_xfer_response_wait Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:31   ` Florian Fainelli
2021-08-25 16:31     ` Florian Fainelli
2021-08-25 17:52     ` Cristian Marussi
2021-08-25 17:52       ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 06/12] firmware: arm_scmi: Add is_transport_atomic() handle method Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:32   ` Florian Fainelli
2021-08-25 16:32     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 07/12] clk: scmi: Support atomic enable/disable API Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:33   ` Florian Fainelli
2021-08-25 16:33     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 08/12] firmware: arm_scmi: Declare virtio transport .atomic_capable Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 09/12] [RFC] firmware: arm_scmi: Make smc transport use common completions Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:35   ` Florian Fainelli
2021-08-25 16:35     ` Florian Fainelli
2021-08-24 13:59 ` [PATCH v4 10/12] [RFC] firmware: arm_scmi: Make smc transport atomic Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 11/12] [RFC] firmware: arm_scmi: Add sync_cmds_atomic_replies transport flag Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi
2021-08-25 16:38   ` Florian Fainelli [this message]
2021-08-25 16:38     ` Florian Fainelli
2021-08-25 17:17     ` Jim Quinlan
2021-08-25 17:17       ` Jim Quinlan
2021-08-25 18:49       ` Cristian Marussi
2021-08-25 18:49         ` Cristian Marussi
2021-08-26 18:29         ` Jim Quinlan
2021-08-26 18:29           ` Jim Quinlan
2021-08-31  5:56           ` Cristian Marussi
2021-08-31  5:56             ` Cristian Marussi
2021-09-23 15:03           ` Cristian Marussi
2021-09-23 15:03             ` Cristian Marussi
2021-10-04 17:50             ` Jim Quinlan
2021-10-04 17:50               ` Jim Quinlan
2021-10-04 18:00               ` Cristian Marussi
2021-10-04 18:00                 ` Cristian Marussi
2021-08-24 13:59 ` [PATCH v4 12/12] [RFC] firmware: arm_scmi: Make smc support atomic commands replies Cristian Marussi
2021-08-24 13:59   ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a2f972d-fdd0-d0f7-cac2-1989980ed872@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=cristian.marussi@arm.com \
    --cc=etienne.carriere@linaro.org \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.