All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Utkal Singh <singhutkal015@gmail.com>, linux-erofs@lists.ozlabs.org
Cc: chao@kernel.org, xiang@kernel.org, yifan.yfzhao@linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] erofs: harden h_shared_count in erofs_init_inode_xattrs()
Date: Wed, 18 Mar 2026 14:08:10 +0800	[thread overview]
Message-ID: <7ac4676c-f68b-4cfd-9356-0f26f8215aed@kernel.org> (raw)
In-Reply-To: <20260317152439.5738-1-singhutkal015@gmail.com>

On 2026/3/17 23:24, Utkal Singh wrote:
> `u8 h_shared_count` indicates the shared xattr count of an inode. It is
> read from the on-disk xattr ibody header, which should be corrupted if
> the size of the shared xattr array exceeds the space available in
> `xattr_isize`.
> 
> It does not cause harmful consequence (e.g. crashes), since the image is
> already considered corrupted, it indeed results in the silent processing
> of garbage metadata.
> 
> Let's harden it to report -EFSCORRUPTED earlier.
> 
> Signed-off-by: Utkal Singh <singhutkal015@gmail.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


  parent reply	other threads:[~2026-03-18  6:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 15:24 [PATCH v2] erofs: harden h_shared_count in erofs_init_inode_xattrs() Utkal Singh
2026-03-17 16:10 ` Gao Xiang
2026-03-17 16:41 ` [PATCH v3] erofs: validate " Utkal Singh
2026-03-17 16:48   ` Gao Xiang
2026-03-17 16:53     ` Gao Xiang
2026-03-17 16:59       ` Utkal Singh
2026-03-17 17:07         ` Gao Xiang
2026-03-18  6:08 ` Chao Yu [this message]
2026-03-18  7:39   ` [PATCH v2] erofs: harden " Utkal Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ac4676c-f68b-4cfd-9356-0f26f8215aed@kernel.org \
    --to=chao@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=singhutkal015@gmail.com \
    --cc=xiang@kernel.org \
    --cc=yifan.yfzhao@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.