From: Gao Xiang <xiang@kernel.org>
To: Utkal Singh <singhutkal015@gmail.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org,
yifan.yfzhao@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] erofs: validate h_shared_count in erofs_init_inode_xattrs()
Date: Wed, 18 Mar 2026 00:48:52 +0800 [thread overview]
Message-ID: <abmF9Nn85cz35C1k@debian> (raw)
In-Reply-To: <20260317164135.24892-1-singhutkal015@gmail.com>
On Tue, Mar 17, 2026 at 04:41:35PM +0000, Utkal Singh wrote:
> A crafted image can set h_shared_count to a value much larger than
> what xattr_isize allows. The loop in erofs_init_inode_xattrs() then
> reads shared xattr IDs far beyond the inode's xattr region, causing
> an out-of-bounds metadata read.
>
> Add a sanity check ensuring:
>
> h_shared_count <= (xattr_isize - sizeof(erofs_xattr_ibody_header)) / 4
>
> Return -EFSCORRUPTED when the check fails.
>
> Signed-off-by: Utkal Singh <singhutkal015@gmail.com>
What happens with your v3?
What happens with the commit message and the division?
Could you explain what happened?
Thanks,
Gao Xiang
next prev parent reply other threads:[~2026-03-17 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 15:24 [PATCH v2] erofs: harden h_shared_count in erofs_init_inode_xattrs() Utkal Singh
2026-03-17 16:10 ` Gao Xiang
2026-03-17 16:41 ` [PATCH v3] erofs: validate " Utkal Singh
2026-03-17 16:48 ` Gao Xiang [this message]
2026-03-17 16:53 ` Gao Xiang
2026-03-17 16:59 ` Utkal Singh
2026-03-17 17:07 ` Gao Xiang
2026-03-18 6:08 ` [PATCH v2] erofs: harden " Chao Yu
2026-03-18 7:39 ` Utkal Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abmF9Nn85cz35C1k@debian \
--to=xiang@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhutkal015@gmail.com \
--cc=yifan.yfzhao@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.