From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Chuck Lever'" <chuck.lever@oracle.com>
Cc: "'Sagi Grimberg'" <sagig@dev.mellanox.co.il>,
<anna.schumaker@netapp.com>,
"'Linux RDMA Mailing List'" <linux-rdma@vger.kernel.org>,
"'Linux NFS Mailing List'" <linux-nfs@vger.kernel.org>
Subject: RE: [PATCH v3 05/11] xprtrdma: Do not wait if ib_post_send() fails
Date: Thu, 10 Mar 2016 09:31:52 -0600 [thread overview]
Message-ID: <7b2101d17ae1$f88597b0$e990c710$@opengridcomputing.com> (raw)
In-Reply-To: <AC62FAB3-5569-4FA3-93AF-35CD2A1869EF@oracle.com>
> > On Mar 10, 2016, at 10:04 AM, Steve Wise <swise@opengridcomputing.com>
> wrote:
> >
> >>>> Moving the QP into error state right after with rdma_disconnect
> >>>> you are not sure that none of the subset of the invalidations
> >>>> that _were_ posted completed and you get the corresponding MRs
> >>>> in a bogus state...
> >>>
> >>> Moving the QP to error state and then draining the CQs means
> >>> that all LOCAL_INV WRs that managed to get posted will get
> >>> completed or flushed. That's already handled today.
> >>>
> >>> It's the WRs that didn't get posted that I'm worried about
> >>> in this patch.
> >>>
> >>> Are there RDMA consumers in the kernel that use that third
> >>> argument to recover when LOCAL_INV WRs cannot be posted?
> >>
> >> None :)
> >>
> >>>>> I suppose I could reset these MRs instead (that is,
> >>>>> pass them to ib_dereg_mr).
> >>>>
> >>>> Or, just wait for a completion for those that were posted
> >>>> and then all the MRs are in a consistent state.
> >>>
> >>> When a LOCAL_INV completes with IB_WC_SUCCESS, the associated
> >>> MR is in a known state (ie, invalid).
> >>>
> >>> The WRs that flush mean the associated MRs are not in a known
> >>> state. Sometimes the MR state is different than the hardware
> >>> state, for example. Trying to do anything with one of these
> >>> inconsistent MRs results in IB_WC_BIND_MW_ERR until the thing
> >>> is deregistered.
> >>
> >> Correct.
> >>
> >
> > It is legal to invalidate an MR that is not in the valid state. So you
don't
> > have to deregister it, you can assume it is valid and post another LINV WR.
>
> I've tried that. Once the MR is inconsistent, even LOCAL_INV
> does not work.
>
Maybe IB Verbs don't mandate that invalidating an invalid MR must be allowed?
(looking at the verbs spec now).
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Chuck Lever' <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: 'Sagi Grimberg'
<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
'Linux RDMA Mailing List'
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Linux NFS Mailing List'
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v3 05/11] xprtrdma: Do not wait if ib_post_send() fails
Date: Thu, 10 Mar 2016 09:31:52 -0600 [thread overview]
Message-ID: <7b2101d17ae1$f88597b0$e990c710$@opengridcomputing.com> (raw)
In-Reply-To: <AC62FAB3-5569-4FA3-93AF-35CD2A1869EF-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > On Mar 10, 2016, at 10:04 AM, Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> wrote:
> >
> >>>> Moving the QP into error state right after with rdma_disconnect
> >>>> you are not sure that none of the subset of the invalidations
> >>>> that _were_ posted completed and you get the corresponding MRs
> >>>> in a bogus state...
> >>>
> >>> Moving the QP to error state and then draining the CQs means
> >>> that all LOCAL_INV WRs that managed to get posted will get
> >>> completed or flushed. That's already handled today.
> >>>
> >>> It's the WRs that didn't get posted that I'm worried about
> >>> in this patch.
> >>>
> >>> Are there RDMA consumers in the kernel that use that third
> >>> argument to recover when LOCAL_INV WRs cannot be posted?
> >>
> >> None :)
> >>
> >>>>> I suppose I could reset these MRs instead (that is,
> >>>>> pass them to ib_dereg_mr).
> >>>>
> >>>> Or, just wait for a completion for those that were posted
> >>>> and then all the MRs are in a consistent state.
> >>>
> >>> When a LOCAL_INV completes with IB_WC_SUCCESS, the associated
> >>> MR is in a known state (ie, invalid).
> >>>
> >>> The WRs that flush mean the associated MRs are not in a known
> >>> state. Sometimes the MR state is different than the hardware
> >>> state, for example. Trying to do anything with one of these
> >>> inconsistent MRs results in IB_WC_BIND_MW_ERR until the thing
> >>> is deregistered.
> >>
> >> Correct.
> >>
> >
> > It is legal to invalidate an MR that is not in the valid state. So you
don't
> > have to deregister it, you can assume it is valid and post another LINV WR.
>
> I've tried that. Once the MR is inconsistent, even LOCAL_INV
> does not work.
>
Maybe IB Verbs don't mandate that invalidating an invalid MR must be allowed?
(looking at the verbs spec now).
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-10 15:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 16:27 [PATCH v3 00/11] NFS/RDMA client patches for v4.6 Chuck Lever
2016-03-04 16:27 ` Chuck Lever
2016-03-04 16:27 ` [PATCH v3 01/11] xprtrdma: Clean up unused RPCRDMA_INLINE_PAD_THRESH macro Chuck Lever
2016-03-04 16:27 ` Chuck Lever
2016-03-08 17:48 ` Sagi Grimberg
2016-03-08 17:48 ` Sagi Grimberg
2016-03-04 16:27 ` [PATCH v3 02/11] xprtrdma: Clean up physical_op_map() Chuck Lever
2016-03-04 16:27 ` Chuck Lever
2016-03-08 17:48 ` Sagi Grimberg
2016-03-08 17:48 ` Sagi Grimberg
2016-03-04 16:27 ` [PATCH v3 03/11] xprtrdma: Clean up dprintk format string containing a newline Chuck Lever
2016-03-04 16:27 ` Chuck Lever
2016-03-08 17:48 ` Sagi Grimberg
2016-03-08 17:48 ` Sagi Grimberg
2016-03-04 16:27 ` [PATCH v3 04/11] xprtrdma: Segment head and tail XDR buffers on page boundaries Chuck Lever
2016-03-04 16:27 ` Chuck Lever
2016-03-04 16:28 ` [PATCH v3 05/11] xprtrdma: Do not wait if ib_post_send() fails Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-08 17:53 ` Sagi Grimberg
2016-03-08 17:53 ` Sagi Grimberg
2016-03-08 18:03 ` Chuck Lever
2016-03-08 18:03 ` Chuck Lever
2016-03-09 11:09 ` Sagi Grimberg
2016-03-09 11:09 ` Sagi Grimberg
2016-03-09 20:47 ` Chuck Lever
2016-03-09 20:47 ` Chuck Lever
2016-03-09 21:40 ` Anna Schumaker
2016-03-09 21:40 ` Anna Schumaker
2016-03-10 10:25 ` Sagi Grimberg
2016-03-10 10:25 ` Sagi Grimberg
2016-03-10 15:04 ` Steve Wise
2016-03-10 15:04 ` Steve Wise
2016-03-10 15:05 ` Chuck Lever
2016-03-10 15:05 ` Chuck Lever
2016-03-10 15:31 ` Steve Wise [this message]
2016-03-10 15:31 ` Steve Wise
2016-03-10 15:35 ` Chuck Lever
2016-03-10 15:35 ` Chuck Lever
2016-03-10 15:54 ` Steve Wise
2016-03-10 15:54 ` Steve Wise
2016-03-10 15:58 ` Chuck Lever
2016-03-10 15:58 ` Chuck Lever
2016-03-10 16:10 ` Steve Wise
2016-03-10 16:10 ` Steve Wise
2016-03-10 16:14 ` Chuck Lever
2016-03-10 16:14 ` Chuck Lever
2016-03-10 16:21 ` Steve Wise
2016-03-10 16:21 ` Steve Wise
2016-03-10 16:40 ` Chuck Lever
2016-03-10 16:40 ` Chuck Lever
2016-03-10 17:01 ` Anna Schumaker
2016-03-10 17:01 ` Anna Schumaker
2016-03-04 16:28 ` [PATCH v3 06/11] rpcrdma: Add RPCRDMA_HDRLEN_ERR Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-08 17:53 ` Sagi Grimberg
2016-03-08 17:53 ` Sagi Grimberg
2016-03-04 16:28 ` [PATCH v3 07/11] xprtrdma: Properly handle RDMA_ERROR replies Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-04 16:28 ` [PATCH v3 08/11] xprtrdma: Serialize credit accounting again Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-04 16:28 ` [PATCH v3 09/11] xprtrdma: Use new CQ API for RPC-over-RDMA client receive CQs Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-08 17:55 ` Sagi Grimberg
2016-03-08 17:55 ` Sagi Grimberg
2016-03-04 16:28 ` [PATCH v3 10/11] xprtrdma: Use an anonymous union in struct rpcrdma_mw Chuck Lever
2016-03-04 16:28 ` Chuck Lever
2016-03-08 17:55 ` Sagi Grimberg
2016-03-08 17:55 ` Sagi Grimberg
2016-03-04 16:28 ` [PATCH v3 11/11] xprtrdma: Use new CQ API for RPC-over-RDMA client send CQs Chuck Lever
2016-03-04 16:28 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='7b2101d17ae1$f88597b0$e990c710$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.