All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Chen Yu <chen.yu@linux.dev>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,  Chen Yu <yu.c.chen@intel.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Vishal Badole	 <Vishal.Badole@amd.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	 platform-driver-x86@vger.kernel.org,
	K Prateek Nayak <KPrateek.Nayak@amd.com>,
	 Ricardo Neri <ricardo.neri@intel.com>,
	Kayra Cizmeci <kayracizmeci@gmail.com>,
	stable@vger.kernel.org,
	 Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Klaus Kusche	 <klaus.kusche@computerix.info>
Subject: Re: [PATCH v2] sched/cache: Honor asym packing over cache aware scheduling on hybrid systems
Date: Tue, 06 Oct 2026 10:27:38 -0700	[thread overview]
Message-ID: <7b407bbb5c0e10dae7925936e8fcf0aaa6b0c9dc.camel@linux.intel.com> (raw)
In-Reply-To: <asUT-eR9yteRmB_v@three-body>

On Tue, 2026-10-06 at 23:30 +0800, Chen Yu wrote:
> On Mon, Oct 05, 2026 at 11:29:53AM -0700, Tim Chen wrote:
> > Date: Mon,  5 Oct 2026 11:29:53 -0700
> > From: Tim Chen <tim.c.chen@linux.intel.com>
> > To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>
> > Cc: Tim Chen <tim.c.chen@linux.intel.com>, Chen Yu <yu.c.chen@intel.com>,
> >  Mario Limonciello <mario.limonciello@amd.com>, Vishal Badole
> >  <Vishal.Badole@amd.com>, linux-kernel@vger.kernel.org, x86@kernel.org,
> >  platform-driver-x86@vger.kernel.org, K Prateek Nayak
> >  <KPrateek.Nayak@amd.com>, Ricardo Neri <ricardo.neri@intel.com>, Kayra
> >  Cizmeci <kayracizmeci@gmail.com>, stable@vger.kernel.org, Vincent Guittot
> >  <vincent.guittot@linaro.org>, Juri Lelli <juri.lelli@redhat.com>, Klaus
> >  Kusche <klaus.kusche@computerix.info>
> > Subject: [PATCH v2] sched/cache: Honor asym packing over cache aware
> >  scheduling on hybrid systems
> > X-Mailer: git-send-email 2.32.0
> > 
> > A regression was reported on an AMD Ryzen AI HX 370 running a cache
> > intensive Clang full-LTO link. The little cores run at a much lower
> > frequency (3.3 GHz vs 5.1 GHz) and have only half of the L3 cache
> > (8 MB vs 16 MB), so pinning such a task to the little-core LLC
> > hurts twice, and full-LTO builds slow down dramatically compared to
> > pre-cache-aware-scheduling kernels.
> > 
> > Asym packing and cache aware scheduling express conflicting placement
> > strategies. Asym packing wants a task to run on the highest priority CPU,
> > whereas cache aware scheduling wants to co-locate the tasks of a process
> > on one LLC regardless of the priority of CPUs in that LLC.
> > 
> > When asym packing tries to migrate task to an idle core that has higher
> > priority than source cpu, let asym packing win.  Moving tasks to a higher
> > performing idle core will buy more performance than cache co-location.
> > 
> > Prioritize asym packing over LLC balancing for regular and active load
> > balancing.
> > 
> > Fixes: 23b2b5ccc45c ("sched/cache: Introduce helper functions to enforce LLC migration policy")
> > Reported-by: Klaus Kusche <klaus.kusche@computerix.info>
> > Closes: https://lore.kernel.org/lkml/2180ea5a-eb28-4152-8d4d-cd00b0c24b2e@computerix.info/
> > Suggested-by: Kayra Cizmeci <kayracizmeci@gmail.com>
> > Tested-by: Klaus Kusche <klaus.kusche@computerix.info>
> > Tested-by: Ricardo Neri <ricardo.neri@intel.com>
> > Cc: stable@vger.kernel.org # 7.2.x
> > Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> > ---
> > 
> 
> I leveraged AI to test it on top of 7.3.0-rc2 using an emulated hybrid setup on a symmetric
> AMD Ryzen 9 8945HX (Zen 4, 16C/32T, two 32 MB L3):
> 
> By hacking the AMD pstate driver and QOS to limit the L3 cache ways:
> 
>   - LLC0 "big/fast":   CPUs 0-7,16-23, max freq 5.46 GHz, 16 L3 ways (32 MB),
>                        ITMT prefcore ranking 236
>   - LLC1 "little/slow": CPUs 8-15,24-31, max freq 3.29 GHz, 8 L3 ways (16 MB),
>                        ITMT prefcore ranking 100
> 
> Workload: an 8-thread pointer-chase ring (24 MB working set).
> 
> This patch works as expected:
> Before the patch:
>                  cache-aware ON       cache-aware OFF
>   throughput     ~230 M/s             ~530 M/s           (-56.6%)
>   placement      6 of 8 threads       8 threads LLC0
>                  stuck on LLC1
> 
> 
> After the patch:
>                  cache-aware ON       cache-aware OFF
>   throughput     520.7 +- 18.3 M/s    512.9 +- 16.6 M/s   (+1.5%, noise)
>   placement      8 threads LLC0       8 threads LLC0
> 
> 
> Tested-by: Chen Yu <yu.c.chen@intel.com>

Thanks for validating the patch.

Tim

> 
> thanks,
> Chenyu 

      reply	other threads:[~2026-10-06 17:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 18:29 [PATCH v2] sched/cache: Honor asym packing over cache aware scheduling on hybrid systems Tim Chen
2026-10-06 13:59 ` Kayra Cizmeci
2026-10-06 17:04   ` Tim Chen
2026-10-06 15:30 ` Chen Yu
2026-10-06 17:27   ` Tim Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b407bbb5c0e10dae7925936e8fcf0aaa6b0c9dc.camel@linux.intel.com \
    --to=tim.c.chen@linux.intel.com \
    --cc=KPrateek.Nayak@amd.com \
    --cc=Vishal.Badole@amd.com \
    --cc=chen.yu@linux.dev \
    --cc=juri.lelli@redhat.com \
    --cc=kayracizmeci@gmail.com \
    --cc=klaus.kusche@computerix.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ricardo.neri@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.