All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCHv3] coresight: tmc: Add shutdown callback for TMC ETR
Date: Wed, 24 Jun 2020 12:23:24 +0530	[thread overview]
Message-ID: <7bfbef95a0ec59fd45b101ea05a9ce36@codeaurora.org> (raw)
In-Reply-To: <20200623172532.GA1843779@xps15>

On 2020-06-23 22:55, Mathieu Poirier wrote:
> On Tue, Jun 16, 2020 at 10:26:23AM +0530, Sai Prakash Ranjan wrote:
>> Implement a shutdown callback to ensure ETR hardware is
>> properly shutdown in reboot/shutdown path. This is required
>> for ETR which has SMMU address translation enabled like on
>> SC7180 SoC and few others. If the hardware is still accessing
>> memory after SMMU translation is disabled as part of SMMU
>> shutdown callback in system reboot or shutdown path, then
>> IOVAs(I/O virtual address) which it was using will go on the
>> bus as the physical addresses which might result in unknown
>> crashes (NoC/interconnect errors). So we make sure from this
>> shutdown callback that the ETR is shutdown before SMMU translation
>> is disabled and device_link in SMMU driver will take care of
>> ordering of shutdown callbacks such that SMMU shutdown callback
>> is not called before any of its consumer shutdown callbacks.
>> 
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
> 
> I have applied your patch.
> 

Thanks Mathieu.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCHv3] coresight: tmc: Add shutdown callback for TMC ETR
Date: Wed, 24 Jun 2020 12:23:24 +0530	[thread overview]
Message-ID: <7bfbef95a0ec59fd45b101ea05a9ce36@codeaurora.org> (raw)
In-Reply-To: <20200623172532.GA1843779@xps15>

On 2020-06-23 22:55, Mathieu Poirier wrote:
> On Tue, Jun 16, 2020 at 10:26:23AM +0530, Sai Prakash Ranjan wrote:
>> Implement a shutdown callback to ensure ETR hardware is
>> properly shutdown in reboot/shutdown path. This is required
>> for ETR which has SMMU address translation enabled like on
>> SC7180 SoC and few others. If the hardware is still accessing
>> memory after SMMU translation is disabled as part of SMMU
>> shutdown callback in system reboot or shutdown path, then
>> IOVAs(I/O virtual address) which it was using will go on the
>> bus as the physical addresses which might result in unknown
>> crashes (NoC/interconnect errors). So we make sure from this
>> shutdown callback that the ETR is shutdown before SMMU translation
>> is disabled and device_link in SMMU driver will take care of
>> ordering of shutdown callbacks such that SMMU shutdown callback
>> is not called before any of its consumer shutdown callbacks.
>> 
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
> 
> I have applied your patch.
> 

Thanks Mathieu.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-24  6:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16  4:56 [PATCHv3] coresight: tmc: Add shutdown callback for TMC ETR Sai Prakash Ranjan
2020-06-16  4:56 ` Sai Prakash Ranjan
2020-06-23 17:25 ` Mathieu Poirier
2020-06-23 17:25   ` Mathieu Poirier
2020-06-24  6:53   ` Sai Prakash Ranjan [this message]
2020-06-24  6:53     ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bfbef95a0ec59fd45b101ea05a9ce36@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.