[PATCH bpf-next] bpf: Sync comments for bpf_get_stack

[PATCH bpf-next] bpf: Sync comments for bpf_get_stack

[Geliang Tang]

Commit ee2a098851bf missed updating the comments for helper bpf_get_stack
in tools/include/uapi/linux/bpf.h. Sync it.

Fixes: ee2a098851bf ("bpf: Adjust BPF stack helper functions to accommodate skip > 0")
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/include/uapi/linux/bpf.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 9284dc1a1bba..9ef1f3e1c22f 100644
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -3009,8 +3009,8 @@ union bpf_attr {
  *
  * 			# sysctl kernel.perf_event_max_stack=<new value>
  * 	Return
- * 		A non-negative value equal to or less than *size* on success,
- * 		or a negative error in case of failure.
+ * 		The non-negative copied *buf* length equal to or less than
+ * 		*size* on success, or a negative error in case of failure.
  *
  * long bpf_skb_load_bytes_relative(const void *skb, u32 offset, void *to, u32 len, u32 start_header)
  * 	Description
@@ -4316,8 +4316,8 @@ union bpf_attr {
  *
  *			# sysctl kernel.perf_event_max_stack=<new value>
  *	Return
- *		A non-negative value equal to or less than *size* on success,
- *		or a negative error in case of failure.
+ * 		The non-negative copied *buf* length equal to or less than
+ * 		*size* on success, or a negative error in case of failure.
  *
  * long bpf_load_hdr_opt(struct bpf_sock_ops *skops, void *searchby_res, u32 len, u64 flags)
  *	Description
-- 
2.34.1

Re: bpf: Sync comments for bpf_get_stack: Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5371691516821504
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5371691516821504/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 1 failed test(s): selftest_diag 🔴:
  - Task: https://cirrus-ci.com/task/6497591423664128
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6497591423664128/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b02f75e52950

Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH bpf-next] bpf: Sync comments for bpf_get_stack

[Martin KaFai Lau]

On Thu, Mar 24, 2022 at 04:37:32PM +0800, Geliang Tang wrote:
> Commit ee2a098851bf missed updating the comments for helper bpf_get_stack
> in tools/include/uapi/linux/bpf.h. Sync it.
Acked-by: Martin KaFai Lau <kafai@fb.com>

Re: [PATCH bpf-next] bpf: Sync comments for bpf_get_stack

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Thu, 24 Mar 2022 16:37:32 +0800 you wrote:
> Commit ee2a098851bf missed updating the comments for helper bpf_get_stack
> in tools/include/uapi/linux/bpf.h. Sync it.
> 
> Fixes: ee2a098851bf ("bpf: Adjust BPF stack helper functions to accommodate skip > 0")
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>  tools/include/uapi/linux/bpf.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
  - [bpf-next] bpf: Sync comments for bpf_get_stack
    https://git.kernel.org/bpf/bpf/c/98870605b374

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html