All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Lai <justinlai0215@realtek.com>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net v3 4/4] rtase: Add defines for hardware version id
Date: Tue, 19 Nov 2024 07:22:46 +0000	[thread overview]
Message-ID: <7c1a67a1ec7b4b1eb4965575b625a628@realtek.com> (raw)
In-Reply-To: <Zzsh3AjTAnQoKKTl@localhost.localdomain>

> 
> On Mon, Nov 18, 2024 at 12:08:28PM +0800, Justin Lai wrote:
> > Add defines for hardware version id.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > ---
> >  drivers/net/ethernet/realtek/rtase/rtase.h      |  5 ++++-
> >  drivers/net/ethernet/realtek/rtase/rtase_main.c | 12 ++++++------
> >  2 files changed, 10 insertions(+), 7 deletions(-)
> >
> 
> The patch is addressed to the "net" tree, but "Fixes" tag is missing.
> Also, the patch does not look like a bugfix it's rather an improvement of coding
> style with no functional changes. That's why I doubt it should go to the "net"
> tree.
> 
> Thanks,
> Michal

Hi Michal,

This patch introduces multiple defines for hardware version IDs, rather
than addressing any issues related to the function logic, which is why it
does not include a "Fixes:" tag. The reason for isolating this change in a
separate patch is to maintain a "single patch, single purpose" approach.
Additionally, these defines will be used in other patches within the same
patch set, which is why they are included in this patch set as a whole.

Justin

  reply	other threads:[~2024-11-19  7:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  4:08 [PATCH net v3 0/4] Correcting switch hardware versions and reported speeds Justin Lai
2024-11-18  4:08 ` [PATCH net v3 1/4] rtase: Refactor the rtase_check_mac_version_valid() function Justin Lai
2024-11-18 11:59   ` Michal Kubiak
2024-11-19  7:23     ` Justin Lai
2024-11-18  4:08 ` [PATCH net v3 2/4] rtase: Correct the speed for RTL907XD-V1 Justin Lai
2024-11-18 12:09   ` Michal Kubiak
2024-11-19  7:23     ` Justin Lai
2024-11-19 11:42       ` Michal Kubiak
2024-11-20  6:40         ` Justin Lai
2024-11-18  4:08 ` [PATCH net v3 3/4] rtase: Corrects error handling of the rtase_check_mac_version_valid() Justin Lai
2024-11-18  4:08 ` [PATCH net v3 4/4] rtase: Add defines for hardware version id Justin Lai
2024-11-18 11:15   ` Michal Kubiak
2024-11-19  7:22     ` Justin Lai [this message]
2024-11-19 11:28       ` Michal Kubiak
2024-11-20  6:40         ` Justin Lai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c1a67a1ec7b4b1eb4965575b625a628@realtek.com \
    --to=justinlai0215@realtek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=larry.chiu@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.kubiak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.