From: Michal Kubiak <michal.kubiak@intel.com>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <kuba@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <andrew+netdev@lunn.ch>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<horms@kernel.org>, <pkshih@realtek.com>,
<larry.chiu@realtek.com>
Subject: Re: [PATCH net v3 4/4] rtase: Add defines for hardware version id
Date: Mon, 18 Nov 2024 12:15:40 +0100 [thread overview]
Message-ID: <Zzsh3AjTAnQoKKTl@localhost.localdomain> (raw)
In-Reply-To: <20241118040828.454861-5-justinlai0215@realtek.com>
On Mon, Nov 18, 2024 at 12:08:28PM +0800, Justin Lai wrote:
> Add defines for hardware version id.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase.h | 5 ++++-
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 12 ++++++------
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
The patch is addressed to the "net" tree, but "Fixes" tag is missing.
Also, the patch does not look like a bugfix it's rather an improvement
of coding style with no functional changes. That's why I doubt it should go
to the "net" tree.
Thanks,
Michal
next prev parent reply other threads:[~2024-11-18 11:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 4:08 [PATCH net v3 0/4] Correcting switch hardware versions and reported speeds Justin Lai
2024-11-18 4:08 ` [PATCH net v3 1/4] rtase: Refactor the rtase_check_mac_version_valid() function Justin Lai
2024-11-18 11:59 ` Michal Kubiak
2024-11-19 7:23 ` Justin Lai
2024-11-18 4:08 ` [PATCH net v3 2/4] rtase: Correct the speed for RTL907XD-V1 Justin Lai
2024-11-18 12:09 ` Michal Kubiak
2024-11-19 7:23 ` Justin Lai
2024-11-19 11:42 ` Michal Kubiak
2024-11-20 6:40 ` Justin Lai
2024-11-18 4:08 ` [PATCH net v3 3/4] rtase: Corrects error handling of the rtase_check_mac_version_valid() Justin Lai
2024-11-18 4:08 ` [PATCH net v3 4/4] rtase: Add defines for hardware version id Justin Lai
2024-11-18 11:15 ` Michal Kubiak [this message]
2024-11-19 7:22 ` Justin Lai
2024-11-19 11:28 ` Michal Kubiak
2024-11-20 6:40 ` Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zzsh3AjTAnQoKKTl@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.