From: Minda Chen <minda.chen@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Peter Chen" <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
"Aswath Govindraju" <a-govindraju@ti.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 0/3] Add JH7110 USB driver support
Date: Mon, 6 Mar 2023 18:35:43 +0800 [thread overview]
Message-ID: <7c314cc7-0377-ac42-8925-79abc9dcb86f@starfivetech.com> (raw)
In-Reply-To: <ZAW/DqprkKaop4bg@wendy>
On 2023/3/6 18:23, Conor Dooley wrote:
> Hey Minda!
>
> On Mon, Mar 06, 2023 at 05:52:12PM +0800, Minda Chen wrote:
>> This patchset adds USB driver for the StarFive JH7110 SoC.
>> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
>> The patch has been tested on the VisionFive 2 board.
>>
>> This patchset should be applied after the patchset [1] and patch [2]:
>> [1] https://lore.kernel.org/all/20230221083323.302471-1-xingyu.wu@starfivetech.com/
>> [2] https://lore.kernel.org/all/20230215113249.47727-4-william.qiu@starfivetech.com/
>>
>> patch 1 is usb phy dt-binding document.
>> patch 2 is the glue layer of Cadence USB3 and USB phy
>> setting. USB controller IP is Cadence USB3.
>> patch 3 is USB device tree configuration.
>>
>> Minda Chen (3):
>> dt-bindings: phy: Add StarFive JH7110 USB dt-binding
>> usb: cdns3: add StarFive JH7110 USB glue layer
>> dts: usb: add StarFive JH7110 USB dts configuration.
>
> Unfortunately, this patchset hasn't really landed correctly.
> Usually, in a series, patches are sent as replies to the cover letter.
> Git's send-email will do this for you if you pass it multiple patches
> and a cover letter (I do it by passing a directory, eg patches/foo/v1)
>
> It appears that you have sent each patch separately, and to different
> recipients, which makes this harder to review.
> Please re-submit this with proper threading (and as v2 ideally, so that
> Greg's bot doesn't complain).
>
> Thanks,
> Conor.
I am sorry about this. I will re-summit this patchset as v2 patch.
WARNING: multiple messages have this Message-ID (diff)
From: Minda Chen <minda.chen@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Peter Chen" <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
"Aswath Govindraju" <a-govindraju@ti.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 0/3] Add JH7110 USB driver support
Date: Mon, 6 Mar 2023 18:35:43 +0800 [thread overview]
Message-ID: <7c314cc7-0377-ac42-8925-79abc9dcb86f@starfivetech.com> (raw)
In-Reply-To: <ZAW/DqprkKaop4bg@wendy>
On 2023/3/6 18:23, Conor Dooley wrote:
> Hey Minda!
>
> On Mon, Mar 06, 2023 at 05:52:12PM +0800, Minda Chen wrote:
>> This patchset adds USB driver for the StarFive JH7110 SoC.
>> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
>> The patch has been tested on the VisionFive 2 board.
>>
>> This patchset should be applied after the patchset [1] and patch [2]:
>> [1] https://lore.kernel.org/all/20230221083323.302471-1-xingyu.wu@starfivetech.com/
>> [2] https://lore.kernel.org/all/20230215113249.47727-4-william.qiu@starfivetech.com/
>>
>> patch 1 is usb phy dt-binding document.
>> patch 2 is the glue layer of Cadence USB3 and USB phy
>> setting. USB controller IP is Cadence USB3.
>> patch 3 is USB device tree configuration.
>>
>> Minda Chen (3):
>> dt-bindings: phy: Add StarFive JH7110 USB dt-binding
>> usb: cdns3: add StarFive JH7110 USB glue layer
>> dts: usb: add StarFive JH7110 USB dts configuration.
>
> Unfortunately, this patchset hasn't really landed correctly.
> Usually, in a series, patches are sent as replies to the cover letter.
> Git's send-email will do this for you if you pass it multiple patches
> and a cover letter (I do it by passing a directory, eg patches/foo/v1)
>
> It appears that you have sent each patch separately, and to different
> recipients, which makes this harder to review.
> Please re-submit this with proper threading (and as v2 ideally, so that
> Greg's bot doesn't complain).
>
> Thanks,
> Conor.
I am sorry about this. I will re-summit this patchset as v2 patch.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Minda Chen <minda.chen@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Peter Chen" <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
"Aswath Govindraju" <a-govindraju@ti.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 0/3] Add JH7110 USB driver support
Date: Mon, 6 Mar 2023 18:35:43 +0800 [thread overview]
Message-ID: <7c314cc7-0377-ac42-8925-79abc9dcb86f@starfivetech.com> (raw)
In-Reply-To: <ZAW/DqprkKaop4bg@wendy>
On 2023/3/6 18:23, Conor Dooley wrote:
> Hey Minda!
>
> On Mon, Mar 06, 2023 at 05:52:12PM +0800, Minda Chen wrote:
>> This patchset adds USB driver for the StarFive JH7110 SoC.
>> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
>> The patch has been tested on the VisionFive 2 board.
>>
>> This patchset should be applied after the patchset [1] and patch [2]:
>> [1] https://lore.kernel.org/all/20230221083323.302471-1-xingyu.wu@starfivetech.com/
>> [2] https://lore.kernel.org/all/20230215113249.47727-4-william.qiu@starfivetech.com/
>>
>> patch 1 is usb phy dt-binding document.
>> patch 2 is the glue layer of Cadence USB3 and USB phy
>> setting. USB controller IP is Cadence USB3.
>> patch 3 is USB device tree configuration.
>>
>> Minda Chen (3):
>> dt-bindings: phy: Add StarFive JH7110 USB dt-binding
>> usb: cdns3: add StarFive JH7110 USB glue layer
>> dts: usb: add StarFive JH7110 USB dts configuration.
>
> Unfortunately, this patchset hasn't really landed correctly.
> Usually, in a series, patches are sent as replies to the cover letter.
> Git's send-email will do this for you if you pass it multiple patches
> and a cover letter (I do it by passing a directory, eg patches/foo/v1)
>
> It appears that you have sent each patch separately, and to different
> recipients, which makes this harder to review.
> Please re-submit this with proper threading (and as v2 ideally, so that
> Greg's bot doesn't complain).
>
> Thanks,
> Conor.
I am sorry about this. I will re-summit this patchset as v2 patch.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-06 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 9:52 [PATCH 0/3] Add JH7110 USB driver support Minda Chen
2023-03-06 9:52 ` Minda Chen
2023-03-06 9:52 ` Minda Chen
2023-03-06 10:23 ` Conor Dooley
2023-03-06 10:23 ` Conor Dooley
2023-03-06 10:23 ` Conor Dooley
2023-03-06 10:35 ` Minda Chen [this message]
2023-03-06 10:35 ` Minda Chen
2023-03-06 10:35 ` Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c314cc7-0377-ac42-8925-79abc9dcb86f@starfivetech.com \
--to=minda.chen@starfivetech.com \
--cc=a-govindraju@ti.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.