From: okaya@codeaurora.org
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oza Pawandeep <poza@codeaurora.org>,
Keith Busch <keith.busch@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 7/7] PCI: Handle link reset via hotplug if supported
Date: Sun, 01 Jul 2018 13:24:28 -0400 [thread overview]
Message-ID: <7d0180b065e4a06a644ee754fb34b702@codeaurora.org> (raw)
In-Reply-To: <20180701171443.GA28249@wunner.de>
On 2018-07-01 13:14, Lukas Wunner wrote:
> On Thu, Jun 28, 2018 at 03:31:05PM -0400, Sinan Kaya wrote:
>> +static pci_ers_result_t pciehp_reset_link(struct pci_dev *pdev)
>> +{
>> + struct pcie_device *pciedev;
>> + struct controller *ctrl;
>> + struct device *devhp;
>> + struct slot *slot;
>> + int rc;
>> +
>> + devhp = pcie_port_find_device(pdev, PCIE_PORT_SERVICE_HP);
>> + pciedev = to_pcie_device(devhp);
>> + ctrl = get_service_data(pciedev);
>> + slot = ctrl->slot;
>> +
>> + rc = reset_slot(slot->hotplug_slot, 0);
>> +
>> + return !rc ? PCI_ERS_RESULT_RECOVERED : PCI_ERS_RESULT_DISCONNECT;
>> +}
>
> This looks like a bit of a detour. There's a "struct pci_slot *slot"
> pointer in struct pci_dev. Any reason not to simply call:
>
> rc = reset_slot(pdev->slot->hotplug_slot)
pdev here is the bridge. Slot pointers are only valid for children
objects.
>
> Lukas
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (okaya at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 7/7] PCI: Handle link reset via hotplug if supported
Date: Sun, 01 Jul 2018 13:24:28 -0400 [thread overview]
Message-ID: <7d0180b065e4a06a644ee754fb34b702@codeaurora.org> (raw)
In-Reply-To: <20180701171443.GA28249@wunner.de>
On 2018-07-01 13:14, Lukas Wunner wrote:
> On Thu, Jun 28, 2018 at 03:31:05PM -0400, Sinan Kaya wrote:
>> +static pci_ers_result_t pciehp_reset_link(struct pci_dev *pdev)
>> +{
>> + struct pcie_device *pciedev;
>> + struct controller *ctrl;
>> + struct device *devhp;
>> + struct slot *slot;
>> + int rc;
>> +
>> + devhp = pcie_port_find_device(pdev, PCIE_PORT_SERVICE_HP);
>> + pciedev = to_pcie_device(devhp);
>> + ctrl = get_service_data(pciedev);
>> + slot = ctrl->slot;
>> +
>> + rc = reset_slot(slot->hotplug_slot, 0);
>> +
>> + return !rc ? PCI_ERS_RESULT_RECOVERED : PCI_ERS_RESULT_DISCONNECT;
>> +}
>
> This looks like a bit of a detour. There's a "struct pci_slot *slot"
> pointer in struct pci_dev. Any reason not to simply call:
>
> rc = reset_slot(pdev->slot->hotplug_slot)
pdev here is the bridge. Slot pointers are only valid for children
objects.
>
> Lukas
next prev parent reply other threads:[~2018-07-01 17:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 19:30 [PATCH V4 1/7] PCI: handle error return from pci_reset_bridge_secondary_bus() Sinan Kaya
2018-06-28 19:30 ` Sinan Kaya
2018-06-28 19:30 ` Sinan Kaya
2018-06-28 19:30 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 2/7] IB/hfi1: Use pci_try_reset_bus() for initiating pci secondary bus reset Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 3/7] PCI: Hide pci_reset_bridge_secondary_bus() from drivers Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 4/7] PCI: Unify try slot and bus reset API Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-29 21:43 ` Andy Shevchenko
2018-06-29 21:43 ` Andy Shevchenko
2018-06-29 21:43 ` Andy Shevchenko
2018-07-02 20:40 ` Sinan Kaya
2018-07-02 20:40 ` Sinan Kaya
2018-07-02 20:40 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 5/7] PCI: Deprecate pci_reset_bus() and pci_reset_slot() functions Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 6/7] PCI: Rename pci_try_reset_bus() to pci_reset_bus() Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` [PATCH V4 7/7] PCI: Handle link reset via hotplug if supported Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-28 19:31 ` Sinan Kaya
2018-06-29 21:39 ` Andy Shevchenko
2018-06-29 21:39 ` Andy Shevchenko
2018-06-29 21:39 ` Andy Shevchenko
2018-07-01 17:14 ` Lukas Wunner
2018-07-01 17:24 ` okaya [this message]
2018-07-01 17:24 ` okaya at codeaurora.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0180b065e4a06a644ee754fb34b702@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.