From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>,
linux@armlinux.org.uk, s.hauer@pengutronix.de,
kernel@pengutronix.de, p.zabel@pengutronix.de,
saravanak@google.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mach-imx: Fix refcount leak bug in src
Date: Wed, 22 Jun 2022 11:00:34 +0200 [thread overview]
Message-ID: <7db10f84-f4dc-e5eb-a143-3b9edad70bf1@kernel.org> (raw)
In-Reply-To: <20220617121235.4047670-1-windhl@126.com>
On 17/06/2022 14:12, Liang He wrote:
> In imx7_src_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>,
linux@armlinux.org.uk, s.hauer@pengutronix.de,
kernel@pengutronix.de, p.zabel@pengutronix.de,
saravanak@google.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mach-imx: Fix refcount leak bug in src
Date: Wed, 22 Jun 2022 11:00:34 +0200 [thread overview]
Message-ID: <7db10f84-f4dc-e5eb-a143-3b9edad70bf1@kernel.org> (raw)
In-Reply-To: <20220617121235.4047670-1-windhl@126.com>
On 17/06/2022 14:12, Liang He wrote:
> In imx7_src_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 12:12 [PATCH] arm: mach-imx: Fix refcount leak bug in src Liang He
2022-06-17 12:12 ` Liang He
2022-06-17 15:39 ` Philipp Zabel
2022-06-17 15:39 ` Philipp Zabel
2022-06-17 15:54 ` Liang He
2022-06-17 15:54 ` Liang He
2022-06-22 9:00 ` Krzysztof Kozlowski [this message]
2022-06-22 9:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db10f84-f4dc-e5eb-a143-3b9edad70bf1@kernel.org \
--to=krzk@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=saravanak@google.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.