All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] cpupower: Bump soname version
@ 2023-05-17 19:10 Salvatore Bonaccorso
  2023-05-17 22:55 ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Salvatore Bonaccorso @ 2023-05-17 19:10 UTC (permalink / raw)
  To: Shuah Khan, Thomas Renninger
  Cc: linux-pm, Ben Hutchings, Shuah Khan, Salvatore Bonaccorso

From: Ben Hutchings <ben@decadent.org.uk>

Several functions in the libcpupower API are renamed or removed in
Linux 4.7.  This is an backward-incompatible ABI change, so the
library soname should change from libcpupower.so.0 to
libcpupower.so.1.

Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 tools/power/cpupower/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
index 59bfa05dec5d..dc531805a570 100644
--- a/tools/power/cpupower/Makefile
+++ b/tools/power/cpupower/Makefile
@@ -53,7 +53,7 @@ DESTDIR ?=
 
 VERSION:=			$(shell ./utils/version-gen.sh)
 LIB_MAJ=			0.0.1
-LIB_MIN=			0
+LIB_MIN=			1
 
 PACKAGE =			cpupower
 PACKAGE_BUGREPORT =		linux-pm@vger.kernel.org
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] cpupower: Bump soname version
  2023-05-17 19:10 [PATCH RESEND] cpupower: Bump soname version Salvatore Bonaccorso
@ 2023-05-17 22:55 ` Shuah Khan
  2023-06-05 20:13   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2023-05-17 22:55 UTC (permalink / raw)
  To: Salvatore Bonaccorso, Thomas Renninger
  Cc: linux-pm, Ben Hutchings, Shuah Khan, Shuah Khan

On 5/17/23 13:10, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> 
> Several functions in the libcpupower API are renamed or removed in
> Linux 4.7.  This is an backward-incompatible ABI change, so the
> library soname should change from libcpupower.so.0 to
> libcpupower.so.1.
> 
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---

Thank you Salvatore. I will apply this for the next 6.4-rc

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] cpupower: Bump soname version
  2023-05-17 22:55 ` Shuah Khan
@ 2023-06-05 20:13   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2023-06-05 20:13 UTC (permalink / raw)
  To: Salvatore Bonaccorso, Thomas Renninger
  Cc: linux-pm, Ben Hutchings, Shuah Khan, Shuah Khan

On 5/17/23 16:55, Shuah Khan wrote:
> On 5/17/23 13:10, Salvatore Bonaccorso wrote:
>> From: Ben Hutchings <ben@decadent.org.uk>
>>
>> Several functions in the libcpupower API are renamed or removed in
>> Linux 4.7.  This is an backward-incompatible ABI change, so the
>> library soname should change from libcpupower.so.0 to
>> libcpupower.so.1.
>>
>> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
>> ---
> 
> Thank you Salvatore. I will apply this for the next 6.4-rc
> 

I was just about to send this in pull request and did a final
test. I am not really seeing any change in library name.

Does LIB_MAJ need bumping up instead of LIB_MIN?

Can you send me before and after build results?

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-05 20:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 19:10 [PATCH RESEND] cpupower: Bump soname version Salvatore Bonaccorso
2023-05-17 22:55 ` Shuah Khan
2023-06-05 20:13   ` Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.