From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: qiu.yutan@zte.com.cn, davem@davemloft.net, kuba@kernel.org
Cc: dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yang.chuan1@zte.com.cn,
huang.jian@zte.com.cn, zhou.shizhen@zte.com.cn,
zhang.dongyu1@zte.com.cn, ye.guojin@zte.com.cn,
yang.wei20@zte.com.cn, zhang.lin16@zte.com.cn,
li.hao40@zte.com.cn
Subject: Re: [PATCH net-next] net: neigh: Rename NEIGH_VAR_INTERVAL_PROBE_TIME_MS to NEIGH_VAR_INTERVAL_PROBE_TIME
Date: Fri, 15 May 2026 10:55:19 +0800 [thread overview]
Message-ID: <7e116785-46b4-4057-848a-090d5bc6779b@linux.dev> (raw)
In-Reply-To: <20260515101408635T6_cWDYOWVYQleZjRtUS1@zte.com.cn>
On 5/15/26 10:14 AM, qiu.yutan@zte.com.cn wrote:
> From: Qiu Yutan <qiu.yutan@zte.com.cn>
>
> During the initialization of arp_tbl, the enumeration constant name
> NEIGH_VAR_INTERVAL_PROBE_TIME_MS in the statement
> arp_tbl.parms.data[NEIGH_VAR_INTERVAL_PROBE_TIME_MS] = 5*HZ does not
> align with its actual meaning (jiffies).
I think the macro name NEIGH_VAR_INTERVAL_PROBE_TIME is just meant to
correspond
to the configuration item neigh/default/interval_probe_time_ms.
>
> Using NEIGH_VAR_INTERVAL_PROBE_TIME is a better naming choice.
>
> Fixes: bf48c3fae6d7 ("Merge branch 'net-neigh-introduce-interval_probe_time-for-periodic-probe'")
Do not carry Fixes tag since it's not a fix. On the other hand, it is a
merge commit not a regular commit...
prev parent reply other threads:[~2026-05-15 2:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 2:14 [PATCH net-next] net: neigh: Rename NEIGH_VAR_INTERVAL_PROBE_TIME_MS to NEIGH_VAR_INTERVAL_PROBE_TIME qiu.yutan
2026-05-15 2:55 ` Jiayuan Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e116785-46b4-4057-848a-090d5bc6779b@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=huang.jian@zte.com.cn \
--cc=kuba@kernel.org \
--cc=li.hao40@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiu.yutan@zte.com.cn \
--cc=yang.chuan1@zte.com.cn \
--cc=yang.wei20@zte.com.cn \
--cc=ye.guojin@zte.com.cn \
--cc=zhang.dongyu1@zte.com.cn \
--cc=zhang.lin16@zte.com.cn \
--cc=zhou.shizhen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.