From: Sean Anderson <sean.anderson@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
Michal Simek <michal.simek@amd.com>,
Daniel Borkmann <daniel@iogearbox.net>,
linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v2 1/5] net: xilinx: axienet: Always disable promiscuous mode
Date: Tue, 20 Aug 2024 10:24:11 -0400 [thread overview]
Message-ID: <7e6caa8b-ae79-4eb0-8ccb-d57471e8a3d5@linux.dev> (raw)
In-Reply-To: <20240819183041.2b985755@kernel.org>
On 8/19/24 21:30, Jakub Kicinski wrote:
> On Thu, 15 Aug 2024 15:36:10 -0400 Sean Anderson wrote:
>> If promiscuous mode is disabled when there are fewer than four multicast
>> addresses, then it will to be reflected in the hardware. Fix this by
>
> it will *not* be reflected?
> Something is off with this commit messages, or at least I can't parse
>
>> always clearing the promiscuous mode flag even when we program multicast
>> addresses.
>>
>> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
>
> I think we should ship it as a fix to net?
Yes, probably. I put these patches first so they could be easily cherry-picked.
--Sean
next prev parent reply other threads:[~2024-08-20 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 19:36 [PATCH net-next v2 0/5] net: xilinx: axienet: Multicast fixes and improvements Sean Anderson
2024-08-15 19:36 ` [PATCH net-next v2 1/5] net: xilinx: axienet: Always disable promiscuous mode Sean Anderson
2024-08-20 1:30 ` Jakub Kicinski
2024-08-20 14:24 ` Sean Anderson [this message]
2024-08-22 14:25 ` Sean Anderson
2024-08-22 15:24 ` Jakub Kicinski
2024-08-15 19:36 ` [PATCH net-next v2 2/5] net: xilinx: axienet: Fix dangling multicast addresses Sean Anderson
2024-08-20 1:33 ` Jakub Kicinski
2024-08-20 14:43 ` Sean Anderson
2024-08-15 19:36 ` [PATCH net-next v2 3/5] net: xilinx: axienet: Don't print if we go into promiscuous mode Sean Anderson
2024-08-16 10:53 ` Simon Horman
2024-08-15 19:36 ` [PATCH net-next v2 4/5] net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flags Sean Anderson
2024-08-16 10:54 ` Simon Horman
2024-08-15 19:36 ` [PATCH net-next v2 5/5] net: xilinx: axienet: Support IFF_ALLMULTI Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6caa8b-ae79-4eb0-8ccb-d57471e8a3d5@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.