All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>,
	Nadav Amit <nadav.amit@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Virtualization <virtualization@lists.linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	kernel@openvz.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory
Date: Fri, 14 Oct 2022 15:40:10 +0200	[thread overview]
Message-ID: <7e6f2d09-e5cf-7f8d-965d-a39bfb0ea286@redhat.com> (raw)
In-Reply-To: <5b1e0a13-8018-630d-d512-c3033db2f2e3@virtuozzo.com>

>>>
>>> Other problem is that there are drivers that do not use
>>> adjust_managed_page_count().
>>
>> Which ones? Do we care?
> 
> VMWare and Virtio balloon drivers. I recently proposed to unify them and
> the objection was that it would break existing users - which is valid so
> we must care i guess.

I'm confused, I think we care about actual adjustment of the total pages 
available here, that we want to notify the system about. These 
approaches (vmware, virtio-balloon with deflate-on-oom) don't adjust 
totalpages, because the assumption is that we can get back the inflated 
memory any time we really need it automatically.

-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>,
	Nadav Amit <nadav.amit@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel@openvz.org,
	Linux Virtualization <virtualization@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>
Subject: Re: RFC [PATCH v4 2/7] Enable balloon drivers to report inflated memory
Date: Fri, 14 Oct 2022 15:40:10 +0200	[thread overview]
Message-ID: <7e6f2d09-e5cf-7f8d-965d-a39bfb0ea286@redhat.com> (raw)
In-Reply-To: <5b1e0a13-8018-630d-d512-c3033db2f2e3@virtuozzo.com>

>>>
>>> Other problem is that there are drivers that do not use
>>> adjust_managed_page_count().
>>
>> Which ones? Do we care?
> 
> VMWare and Virtio balloon drivers. I recently proposed to unify them and
> the objection was that it would break existing users - which is valid so
> we must care i guess.

I'm confused, I think we care about actual adjustment of the total pages 
available here, that we want to notify the system about. These 
approaches (vmware, virtio-balloon with deflate-on-oom) don't adjust 
totalpages, because the assumption is that we can get back the inflated 
memory any time we really need it automatically.

-- 
Thanks,

David / dhildenb



  reply	other threads:[~2022-10-14 13:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  9:01 [PATCH v4 0/7] Make balloon drivers memory changes known to the rest of the kernel Alexander Atanasov
2022-10-05  9:01 ` Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 1/7] Make place for common balloon code Alexander Atanasov
2022-10-05  9:01   ` Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 2/7] Enable balloon drivers to report inflated memory Alexander Atanasov
2022-10-05 17:25   ` Nadav Amit
2022-10-05 17:25     ` Nadav Amit
2022-10-06  7:34     ` Alexander Atanasov
2022-10-06 21:07       ` Nadav Amit
2022-10-06 21:07         ` Nadav Amit
2022-10-07 10:58         ` RFC " Alexander Atanasov
2022-10-10  6:18           ` Nadav Amit
2022-10-10  6:18             ` Nadav Amit
2022-10-10  7:24             ` Alexander Atanasov
2022-10-10 14:47               ` Nadav Amit
2022-10-10 14:47                 ` Nadav Amit
2022-10-11  9:07                 ` Alexander Atanasov
2022-10-11  9:23                   ` David Hildenbrand
2022-10-11  9:23                     ` David Hildenbrand
2022-10-14 12:50                     ` Alexander Atanasov
2022-10-14 13:01                       ` David Hildenbrand
2022-10-14 13:01                         ` David Hildenbrand
2022-10-14 13:33                         ` Alexander Atanasov
2022-10-14 13:40                           ` David Hildenbrand [this message]
2022-10-14 13:40                             ` David Hildenbrand
2022-10-14 14:10                             ` Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 3/7] Display inflated memory to users Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 4/7] drivers: virtio: balloon - update inflated memory Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 5/7] Display inflated memory in logs Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 6/7] drivers: vmware: balloon - report inflated memory Alexander Atanasov
2022-10-05  9:01 ` [PATCH v4 7/7] drivers: hyperv: " Alexander Atanasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e6f2d09-e5cf-7f8d-965d-a39bfb0ea286@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.atanasov@virtuozzo.com \
    --cc=kernel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mst@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.