All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
	stable@vger.kernel.org
Subject: Re: [PATCH][stable-4.{4, 9, 14, 19}] KVM: arm64: Fix exclusive limit for IPA size
Date: Mon, 15 Mar 2021 11:44:13 +0000	[thread overview]
Message-ID: <7ec2199ed2b2c8e6d881461398882751@kernel.org> (raw)
In-Reply-To: <YE9FVw1PE9kClrdi@kroah.com>

On 2021-03-15 11:30, Greg KH wrote:
> On Mon, Mar 15, 2021 at 11:08:33AM +0000, Marc Zyngier wrote:
>> Commit 262b003d059c6671601a19057e9fe1a5e7f23722 upstream.
>> 
>> When registering a memslot, we check the size and location of that
>> memslot against the IPA size to ensure that we can provide guest
>> access to the whole of the memory.
>> 
>> Unfortunately, this check rejects memslot that end-up at the exact
>> limit of the addressing capability for a given IPA size. For example,
>> it refuses the creation of a 2GB memslot at 0x8000000 with a 32bit
>> IPA space.
>> 
>> Fix it by relaxing the check to accept a memslot reaching the
>> limit of the IPA space.
>> 
>> Fixes: c3058d5da222 ("arm/arm64: KVM: Ensure memslots are within 
>> KVM_PHYS_SIZE")
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> Cc: stable@vger.kernel.org # 4.4, 4.9, 4.14, 4.19
>> Reviewed-by: Andrew Jones <drjones@redhat.com>
>> Link: 
>> https://lore.kernel.org/r/20210311100016.3830038-3-maz@kernel.org
>> ---
>>  virt/kvm/arm/mmu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This file does not exist in 4.4.y or 4.9.y, so I can't apply it there 
> :(

Ah, git rename handling fixed that up for me, and I didn't pay
attention to the resulting path... Sorry about that.

I'll resend the patch for 4.4 and 4.9

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kvmarm@lists.cs.columbia.edu, kernel-team@android.com,
	Eric Auger <eric.auger@redhat.com>,
	stable@vger.kernel.org, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH][stable-4.{4,9,14,19}] KVM: arm64: Fix exclusive limit for IPA size
Date: Mon, 15 Mar 2021 11:44:13 +0000	[thread overview]
Message-ID: <7ec2199ed2b2c8e6d881461398882751@kernel.org> (raw)
In-Reply-To: <YE9FVw1PE9kClrdi@kroah.com>

On 2021-03-15 11:30, Greg KH wrote:
> On Mon, Mar 15, 2021 at 11:08:33AM +0000, Marc Zyngier wrote:
>> Commit 262b003d059c6671601a19057e9fe1a5e7f23722 upstream.
>> 
>> When registering a memslot, we check the size and location of that
>> memslot against the IPA size to ensure that we can provide guest
>> access to the whole of the memory.
>> 
>> Unfortunately, this check rejects memslot that end-up at the exact
>> limit of the addressing capability for a given IPA size. For example,
>> it refuses the creation of a 2GB memslot at 0x8000000 with a 32bit
>> IPA space.
>> 
>> Fix it by relaxing the check to accept a memslot reaching the
>> limit of the IPA space.
>> 
>> Fixes: c3058d5da222 ("arm/arm64: KVM: Ensure memslots are within 
>> KVM_PHYS_SIZE")
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> Cc: stable@vger.kernel.org # 4.4, 4.9, 4.14, 4.19
>> Reviewed-by: Andrew Jones <drjones@redhat.com>
>> Link: 
>> https://lore.kernel.org/r/20210311100016.3830038-3-maz@kernel.org
>> ---
>>  virt/kvm/arm/mmu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This file does not exist in 4.4.y or 4.9.y, so I can't apply it there 
> :(

Ah, git rename handling fixed that up for me, and I didn't pay
attention to the resulting path... Sorry about that.

I'll resend the patch for 4.4 and 4.9

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2021-03-15 11:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 11:08 [PATCH][stable-4.{4, 9, 14, 19}] KVM: arm64: Fix exclusive limit for IPA size Marc Zyngier
2021-03-15 11:08 ` [PATCH][stable-4.{4,9,14,19}] " Marc Zyngier
2021-03-15 11:30 ` Greg KH
2021-03-15 11:30   ` Greg KH
2021-03-15 11:44   ` Marc Zyngier [this message]
2021-03-15 11:44     ` Marc Zyngier
2021-03-15 11:30 ` Patch "KVM: arm64: Fix exclusive limit for IPA size" has been added to the 4.14-stable tree gregkh
2021-03-15 11:31 ` Patch "KVM: arm64: Fix exclusive limit for IPA size" has been added to the 4.19-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ec2199ed2b2c8e6d881461398882751@kernel.org \
    --to=maz@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.