From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chuanhong Guo <gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x
Date: Fri, 7 Feb 2020 15:54:45 -0800 [thread overview]
Message-ID: <7f53a397-0237-4c68-e284-d92adf19c368@gmail.com> (raw)
In-Reply-To: <CAJsYDVKXvAkQawwayX8JVrjvEKPuTyQXE8rw=BRiyVROKrdWrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2/6/20 9:55 PM, Chuanhong Guo wrote:
> On Fri, Feb 7, 2020 at 4:55 AM Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>>
>> On Thu, 6 Feb 2020 23:06:26 +0800, Chuanhong Guo wrote:
>>> Add binding documentation for SPI controller in Qualcomm Atheros
>>> AR934x/QCA95xx SoCs.
>>>
>>> Signed-off-by: Chuanhong Guo <gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>> Changes since v1: none
>>> .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++
>>> 1 file changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
>> Error: Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dts:20.28-29 syntax error
>> FATAL ERROR: Unable to parse input tree
>> scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml' failed
>> make[1]: *** [Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml] Error 1
>> Makefile:1263: recipe for target 'dt_binding_check' failed
>> make: *** [dt_binding_check] Error 2
>>
>> See https://patchwork.ozlabs.org/patch/1234394
>> Please check and re-submit.
>
> It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB
> isn't defined without a include of dt-bindings/clock/ath79-clk.h
> I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3.
You can include ath79-clk.h in your example, see for instance
Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Chuanhong Guo <gch981213@gmail.com>, Rob Herring <robh@kernel.org>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x
Date: Fri, 7 Feb 2020 15:54:45 -0800 [thread overview]
Message-ID: <7f53a397-0237-4c68-e284-d92adf19c368@gmail.com> (raw)
In-Reply-To: <CAJsYDVKXvAkQawwayX8JVrjvEKPuTyQXE8rw=BRiyVROKrdWrg@mail.gmail.com>
On 2/6/20 9:55 PM, Chuanhong Guo wrote:
> On Fri, Feb 7, 2020 at 4:55 AM Rob Herring <robh@kernel.org> wrote:
>>
>> On Thu, 6 Feb 2020 23:06:26 +0800, Chuanhong Guo wrote:
>>> Add binding documentation for SPI controller in Qualcomm Atheros
>>> AR934x/QCA95xx SoCs.
>>>
>>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>>> ---
>>> Changes since v1: none
>>> .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++
>>> 1 file changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
>> Error: Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dts:20.28-29 syntax error
>> FATAL ERROR: Unable to parse input tree
>> scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml' failed
>> make[1]: *** [Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml] Error 1
>> Makefile:1263: recipe for target 'dt_binding_check' failed
>> make: *** [dt_binding_check] Error 2
>>
>> See https://patchwork.ozlabs.org/patch/1234394
>> Please check and re-submit.
>
> It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB
> isn't defined without a include of dt-bindings/clock/ath79-clk.h
> I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3.
You can include ath79-clk.h in your example, see for instance
Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
--
Florian
next prev parent reply other threads:[~2020-02-07 23:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 15:06 [PATCH v2 0/2] spi: add driver for ar934x spi controller Chuanhong Guo
2020-02-06 15:06 ` Chuanhong Guo
[not found] ` <20200206150626.708649-1-gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-06 15:06 ` [PATCH v2 1/2] " Chuanhong Guo
2020-02-06 15:06 ` Chuanhong Guo
2020-02-06 15:06 ` [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x Chuanhong Guo
2020-02-06 15:06 ` Chuanhong Guo
[not found] ` <20200206150626.708649-3-gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-06 20:55 ` Rob Herring
2020-02-06 20:55 ` Rob Herring
2020-02-07 5:55 ` Chuanhong Guo
2020-02-07 5:55 ` Chuanhong Guo
[not found] ` <CAJsYDVKXvAkQawwayX8JVrjvEKPuTyQXE8rw=BRiyVROKrdWrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-07 23:54 ` Florian Fainelli [this message]
2020-02-07 23:54 ` Florian Fainelli
2020-02-08 9:36 ` Chuanhong Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f53a397-0237-4c68-e284-d92adf19c368@gmail.com \
--to=f.fainelli-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gch981213-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.