All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org
Cc: darrick.wong@oracle.com, dan.j.williams@intel.com,
	willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk,
	linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	david@fromorbit.com, hch@lst.de, rgoldwyn@suse.de,
	Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax
Date: Tue, 23 Mar 2021 20:57:50 +0530	[thread overview]
Message-ID: <7f9d5477-b156-e084-9412-307dd67149b1@linux.ibm.com> (raw)
In-Reply-To: <20210319015237.993880-1-ruansy.fnst@fujitsu.com>



On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> 
> This patchset is attempt to add CoW support for fsdax, and take XFS,
> which has both reflink and fsdax feature, as an example.


Thanks for the patchset. I have tried reviewing the series from logical
correctness and to some extent functional correctness.
Since I am not well versed with the core functionality of COW operation,
so I may have requested for some clarifications where I could not get
the code 100% on what it is doing.


> 
> (Rebased on v5.11)
> ==
> 
Thanks. Yes, I see some conflicts when tried to apply on latest kernel.

-ritesh

WARNING: multiple messages have this Message-ID (diff)
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org
Cc: darrick.wong@oracle.com, willy@infradead.org, jack@suse.cz,
	viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, david@fromorbit.com, hch@lst.de,
	rgoldwyn@suse.de
Subject: Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax
Date: Tue, 23 Mar 2021 20:57:50 +0530	[thread overview]
Message-ID: <7f9d5477-b156-e084-9412-307dd67149b1@linux.ibm.com> (raw)
In-Reply-To: <20210319015237.993880-1-ruansy.fnst@fujitsu.com>



On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> 
> This patchset is attempt to add CoW support for fsdax, and take XFS,
> which has both reflink and fsdax feature, as an example.


Thanks for the patchset. I have tried reviewing the series from logical
correctness and to some extent functional correctness.
Since I am not well versed with the core functionality of COW operation,
so I may have requested for some clarifications where I could not get
the code 100% on what it is doing.


> 
> (Rebased on v5.11)
> ==
> 
Thanks. Yes, I see some conflicts when tried to apply on latest kernel.

-ritesh
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org
Cc: jack@suse.cz, Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>,
	darrick.wong@oracle.com, david@fromorbit.com,
	ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk,
	dan.j.williams@intel.com, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH v3 00/10] fsdax, xfs: Add reflink&dedupe support for fsdax
Date: Tue, 23 Mar 2021 20:57:50 +0530	[thread overview]
Message-ID: <7f9d5477-b156-e084-9412-307dd67149b1@linux.ibm.com> (raw)
In-Reply-To: <20210319015237.993880-1-ruansy.fnst@fujitsu.com>



On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> 
> This patchset is attempt to add CoW support for fsdax, and take XFS,
> which has both reflink and fsdax feature, as an example.


Thanks for the patchset. I have tried reviewing the series from logical
correctness and to some extent functional correctness.
Since I am not well versed with the core functionality of COW operation,
so I may have requested for some clarifications where I could not get
the code 100% on what it is doing.


> 
> (Rebased on v5.11)
> ==
> 
Thanks. Yes, I see some conflicts when tried to apply on latest kernel.

-ritesh

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  parent reply	other threads:[~2021-03-23 15:29 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  1:52 [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax Shiyang Ruan
2021-03-19  1:52 ` [Ocfs2-devel] [PATCH v3 00/10] fsdax, xfs: " Shiyang Ruan
2021-03-19  1:52 ` [PATCH v3 00/10] fsdax,xfs: " Shiyang Ruan
2021-03-19  1:52 ` [PATCH v3 01/10] fsdax: Factor helpers to simplify dax fault code Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-23 15:33   ` Ritesh Harjani
2021-03-23 15:33     ` [Ocfs2-devel] " Ritesh Harjani
2021-03-23 15:33     ` Ritesh Harjani
2021-03-19  1:52 ` [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor() Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-23 15:48   ` Ritesh Harjani
2021-03-23 15:48     ` [Ocfs2-devel] " Ritesh Harjani
2021-03-23 15:48     ` Ritesh Harjani
2021-03-31  3:57     ` ruansy.fnst
2021-03-31  3:57       ` [Ocfs2-devel] " ruansy.fnst
2021-03-31  3:57       ` ruansy.fnst
2021-04-02  7:47   ` Christoph Hellwig
2021-04-02  7:47     ` [Ocfs2-devel] " Christoph Hellwig
2021-04-02  7:47     ` Christoph Hellwig
2021-03-19  1:52 ` [PATCH v3 03/10] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-23 15:54   ` Ritesh Harjani
2021-03-23 15:54     ` [Ocfs2-devel] " Ritesh Harjani
2021-03-23 15:54     ` Ritesh Harjani
2021-03-19  1:52 ` [PATCH v3 04/10] fsdax: Introduce dax_iomap_cow_copy() Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-23 16:08   ` Ritesh Harjani
2021-03-23 16:08     ` [Ocfs2-devel] " Ritesh Harjani
2021-03-23 16:08     ` Ritesh Harjani
2021-03-19  1:52 ` [PATCH v3 05/10] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-04-01  6:39   ` Ritesh Harjani
2021-04-01  6:39     ` [Ocfs2-devel] " Ritesh Harjani
2021-04-01  6:39     ` Ritesh Harjani
2021-04-01  7:03     ` ruansy.fnst
2021-04-01  7:03       ` [Ocfs2-devel] " ruansy.fnst
2021-04-01  7:03       ` ruansy.fnst
2021-03-19  1:52 ` [PATCH v3 06/10] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-04-01  6:45   ` Ritesh Harjani
2021-04-01  6:45     ` [Ocfs2-devel] " Ritesh Harjani
2021-04-01  6:45     ` Ritesh Harjani
2021-04-01  7:00     ` ruansy.fnst
2021-04-01  7:00       ` [Ocfs2-devel] " ruansy.fnst
2021-04-01  7:00       ` ruansy.fnst
2021-03-19  1:52 ` [PATCH v3 07/10] iomap: Introduce iomap_apply2() for operations on two files Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-04-01  7:12   ` Ritesh Harjani
2021-04-01  7:12     ` [Ocfs2-devel] " Ritesh Harjani
2021-04-01  7:12     ` Ritesh Harjani
2021-03-19  1:52 ` [PATCH v3 08/10] fsdax: Dedup file range to use a compare function Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-04-01 11:11   ` Ritesh Harjani
2021-04-01 11:11     ` [Ocfs2-devel] " Ritesh Harjani
2021-04-01 11:11     ` Ritesh Harjani
2021-04-08  3:21     ` ruansy.fnst
2021-04-08  3:21       ` [Ocfs2-devel] " ruansy.fnst
2021-04-08  3:21       ` ruansy.fnst
2021-03-19  1:52 ` [PATCH v3 09/10] fs/xfs: Handle CoW for fsdax write() path Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-19  1:52 ` [PATCH v3 10/10] fs/xfs: Add dedupe support for fsdax Shiyang Ruan
2021-03-19  1:52   ` [Ocfs2-devel] " Shiyang Ruan
2021-03-19  1:52   ` Shiyang Ruan
2021-03-23 15:27 ` Ritesh Harjani [this message]
2021-03-23 15:27   ` [Ocfs2-devel] [PATCH v3 00/10] fsdax, xfs: Add reflink&dedupe " Ritesh Harjani
2021-03-23 15:27   ` [PATCH v3 00/10] fsdax,xfs: " Ritesh Harjani
2021-04-02  7:49 ` Christoph Hellwig
2021-04-02  7:49   ` [Ocfs2-devel] [PATCH v3 00/10] fsdax, xfs: " Christoph Hellwig
2021-04-02  7:49   ` [PATCH v3 00/10] fsdax,xfs: " Christoph Hellwig
2021-04-02  8:18   ` ruansy.fnst
2021-04-02  8:18     ` [Ocfs2-devel] [PATCH v3 00/10] fsdax, xfs: " ruansy.fnst
2021-04-02  8:18     ` [PATCH v3 00/10] fsdax,xfs: " ruansy.fnst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f9d5477-b156-e084-9412-307dd67149b1@linux.ibm.com \
    --to=riteshh@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rgoldwyn@suse.de \
    --cc=ruansy.fnst@cn.fujitsu.com \
    --cc=ruansy.fnst@fujitsu.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.