From: Markus Elfring <Markus.Elfring@web.de>
To: Kaitao Cheng <pilgrimtao@gmail.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show()
Date: Fri, 12 Jun 2020 16:45:57 +0000 [thread overview]
Message-ID: <7fdada40-370d-37b3-3aab-bfbedaa1804f@web.de> (raw)
In-Reply-To: <20200612160946.21187-1-pilgrimtao@gmail.com>
> 'files' will be immediately reassigned. 'f_flags' and 'file' will be
> overwritten in the if{} or seq_show() directly exits with an error.
> so we don't need to consume CPU resources to initialize them.
I suggest to improve also this change description.
* Should the mentioned identifiers refer to variables?
* Will another imperative wording be preferred?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n151
* I propose to extend the patch a bit more.
How do you think about to convert the initialisation for the variable “ret”
also into a later assignment?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Kaitao Cheng <pilgrimtao@gmail.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show()
Date: Fri, 12 Jun 2020 18:45:57 +0200 [thread overview]
Message-ID: <7fdada40-370d-37b3-3aab-bfbedaa1804f@web.de> (raw)
In-Reply-To: <20200612160946.21187-1-pilgrimtao@gmail.com>
> 'files' will be immediately reassigned. 'f_flags' and 'file' will be
> overwritten in the if{} or seq_show() directly exits with an error.
> so we don't need to consume CPU resources to initialize them.
I suggest to improve also this change description.
* Should the mentioned identifiers refer to variables?
* Will another imperative wording be preferred?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n151
* I propose to extend the patch a bit more.
How do you think about to convert the initialisation for the variable “ret”
also into a later assignment?
Regards,
Markus
next prev parent reply other threads:[~2020-06-12 16:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 16:09 [PATCH v2] proc/fd: Remove unnecessary {files, f_flags, file} initialization in seq_show() Kaitao Cheng
2020-06-12 16:09 ` Kaitao Cheng
2020-06-12 16:45 ` Markus Elfring [this message]
2020-06-12 16:45 ` [PATCH v2] proc/fd: Remove unnecessary variable initialisations " Markus Elfring
2020-06-12 17:00 ` Matthew Wilcox
2020-06-12 17:00 ` Matthew Wilcox
2020-06-12 17:03 ` Markus Elfring
2020-06-12 17:03 ` Markus Elfring
2020-06-12 17:03 ` Markus Elfring
2020-06-12 17:03 ` Markus Elfring
2020-06-12 17:04 ` Matthew Wilcox
2020-06-12 17:04 ` Matthew Wilcox
2020-06-12 18:22 ` [v2] " Markus Elfring
2020-06-12 18:22 ` Markus Elfring
2020-06-12 18:28 ` Matthew Wilcox
2020-06-12 18:28 ` Matthew Wilcox
2020-06-12 18:43 ` Markus Elfring
2020-06-12 18:43 ` Markus Elfring
2020-06-12 18:47 ` Matthew Wilcox
2020-06-12 18:47 ` Matthew Wilcox
2020-06-12 19:00 ` Markus Elfring
2020-06-12 19:00 ` Markus Elfring
2020-06-12 19:00 ` Markus Elfring
2020-06-12 19:00 ` Markus Elfring
2020-06-12 19:02 ` Matthew Wilcox
2020-06-12 19:02 ` Matthew Wilcox
2020-06-12 19:49 ` Al Viro
2020-06-12 19:49 ` Al Viro
2020-06-14 7:12 ` [PATCH v2] " Greg KH
2020-06-14 7:12 ` Greg KH
2020-07-07 7:23 ` [PATCH v2] proc/fd: Adjust " Markus Elfring
2020-07-07 7:23 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fdada40-370d-37b3-3aab-bfbedaa1804f@web.de \
--to=markus.elfring@web.de \
--cc=adobriyan@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pilgrimtao@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.